►
From YouTube: A maintainer review for the GitLab SVGs project
Description
In this video Jeremy Elder walked through the process of reviewing a new addition to the GitLab SVGs project. This video would be helpful for anyone looking to become a maintainer for GitLab SVGs.
A
A
And
this
illustration
this
issue
is
adding
a
new
empty
state
for
looks
like
for
requirements
which
is
going
to
be
a
new
feature
in
the
product,
and
it
can
I've
worked
through
that
I've
actually
just
reviewed
his
sketch
file
for
the
workflow
and
kind
of
approved.
You
know
make
sure
that
the
design
specs
look
good
there.
A
So
that's
something
that
you
know
you
typically
do
in
the
the
front
end
before
it
becomes
an
something
that
you
add
into
the
SVG
library
and
then
once
it's
added
a
reviewer
there
with
them
again
just
kind
of
redo
those
specs
and
check
the
code.
Side
I
think
some
crickets
at
it.
So,
let's
just
I
think
my
next
step
here
is
to
actually
create
an
mr,
so
I'll
just
go
ahead
and
do
that
Thank,
You
KC
wish
screen
all
right.
Yep.
B
A
B
A
A
A
And
for
a
I
apologize
for
a
reviewer,
you
typically
wouldn't
have
to
do
all
this
right,
because
the
designer
would
be
adding
it
and
then
you
would
just
review
it,
but
I'll
just
show
you
this
kind
of
the
whole
workflow,
so
I
got
the
his
design.
I've
approved
it,
and
what
I'm
gonna
do
is
just
go
ahead.
Then
most
export
it.
It
says:
I've
got
that
branch
tricked
out
I'm
going
to
export
it
directly
into
the
SVG
per
project.
A
A
Dropping
in
the
empty
States
I
can
see
its
requirements
empty
state
large.
So
it's
all
lowercase
hyphenated,
that's
one
of
the
things.
I
usually
check
them
in
reviews,
making
sure
that
the
actual
file
name
kind
of
aligns
with
that
I'll-
probably
change
this,
so
that
it
starts
with
empty
I,
find
that
that
makes
it
easier
for
search
and
just
being
able
to
navigate
so
we
the
size
in
there
so
empty
requirements,
large
SVG
go
ahead
and
add
that
and
then
I
jump
over
here.
A
A
A
So
I
got
something
copy
and
paste
it
in
there,
and
so
what
I'll
do
locally
then
is
I'll
also
run
and
run
dev,
which
creates
a
local
instance
of
the
file
and
oftentimes
I'll.
Do
this?
Actually,
if
I'm
reviewing
I'll
check
out
the
branch
and
I'll
do
like
the
run,
dev
and
I'll
just
check
it
out
locally
and
when
I
do
that,
I
could
go
to
illustrations.
I
can
search
for
empty.
A
Requirements,
ok,
so
I
can
see
that
it's
there
I
know
it's
here.
Actually
that
okay,
you
know,
there's
no
white
background
here,
so
that
might
be
something
in
a
review
that
I
check
that
you
know
that
that
actually
should
be
part
of
that
design,
and
in
this
case
it
I
think
it
should
be
so
I'll
just
go
back
to
the
design.
That's
something
that,
like
you,
really
check,
if
you're
are
reviewing
it
locally.
There's
that
background
there
sorry
I'll
go
back
over
here.
A
B
A
A
A
B
A
Freshness
and
now
we
should
see
that,
like
that
pipelines
running
that
usually
doesn't
take
too
long
for
this,
and
this
is
where,
like
a
reviewer,
would
kind
of
step
in
right,
pipeline
screen,
you've
been
assigned
a
review.
I'd
like
to
do
is
I
initially
just
go
over
to
the
changes
and
see
like
what's
been
added
right.
So
in
the
dist
folder,
okay,
the
illustrations
there,
the
SVG
everything's
been
compressed
I'll,
look
at
the
JSON
and
just
see
okay,
there's
just
a
simple
addition:
that's
happened
all
right,
so
there's
minor
changes
right.
A
The
illustration
cannot
win
it
by
one.
So
I
know:
okay,
it's
effective,
there's
one
at
it,
and
I
also
see
that
the
new
one
has
been
added
in
the
empty
state
folder
with
the
correct
naming
and
the
size
is
just
up
to
do
that.
Typically,
you
know
that's
that's
kind
of
automated
number,
so
it
has
too
much
and
then
the
actual
design
you
know
I
can
see
that
that's
been
added
into
the
non
distorter,
so
I
checked
through
those.
So
that's
that's
kind
of
my.
You
know
initial
step
in
this
case.
A
A
It's
still
chugging
along
and
what
I'll
do
is
I
come
to
do
two
step
and
it
might
be
a
bit
redundant.
What
I
like
to
do
is
actually
view
the
review
app
make
sure
that
the
addition
is
there.
It
looks
correct
and
then
I'll
often
like
I've
mentioned
earlier,
like
check
out
the
branch
and
review
it
locally,
just
to
ensure
that
everything
is
it's,
you
know
tracking.
So
it's
pretty
pretty
simple
and
that's
that's
generally,
my
process
for
adding
these
so
from
a
visual
standpoint.
A
I'll
go
over
to
our
guidelines
and
for
here,
okay
I
actually
have
open
on
sure.
Like
the
colors
are
consistent.
You
notice
there
was
green
added
in
there
and
that
that
happened
and
I'm
a
different,
a
different
issue
recently,
where
we
just
discussed
adding
green
so
that
we
could
indicate
like
a
success
state
in
an
illustration.
So
the
this
doctor
has
to
be
updated.
Probably
that
green
and
palate,
but
I'll,
just
Italy
ensure
that
the
illustration
follows
kind
of
the
palate
guidelines,
the
shape
stroke.
A
You
know
border
radius
if
I
notice
that
something
looks
to
rebounded
I.
Might
you
know
the
quest
that
gets
dialed
in
sizing
is?
Is
the
other
major
thing
that
I
take
a
look
at
so
based
on
the
original
issue?
I
know
that
that
you
know,
based
on
the
original
issue,
I
noticed
that
we're
you
know
this
is.
This
is
an
empty
state.
It
looks
like
it's
probably
the
large.
It's
not
the
medium
based
on
the
requirements
and
so
I'll
make
sure
that
okay
do
the
dimensions
for
that
fall
within
that.
B
A
You
know
go
over
into
sketch.
I
can
see
that.
Indeed
it
is.
You
know
the
240
by
212,
which
is
for
a
large
state,
is
less
than
the
dimension.
So
I
know
it.
It
satisfies
that.
It's
not
gonna,
be,
you
know,
shrunk
down
in
the
UI
or
scale
down,
and
so
that's
that's.
Basically
what
I
review
I
make
sure
that
everything
looks
good
in
that
in
that
regard,
that
you
know
shapes
elements
that
are
used
are
consistent
with
other
things
in
our
library
and
how
we
use
the
product,
and
that
is
it
so
pretty
simple.
A
A
One
of
the
things
we
we
don't
really
have
is
the
ability
to
kind
of
scale
it
to
well,
but
even
even
in
a
quick
test
here,
I
can
see
that
that
illustration
is
going
to
scale,
there's
some
other
issues
with
actual
SVG
site
that
it's
causing
some
weird
scaling
problems.
But
that
is
it's
the
basic
process,
so
that
was
actually
a
little
bit
of
the
process
since
actually
with
you.
B
A
And
exactly
and
then,
when
I'm
in
the
review
up
with
icons,
since
we
have
this
configuration
thing,
what
I'll
do
is
you
know,
I'll,
typically
isolate
the
icon
that
I'm
looking
at
and
I'll
make
sure
that
all
the
different
tests
and
say:
okay,
the
color
changes?
Okay,
that's
great!
Let's,
let's
change
the
size,
okay,
so
I
know
size
and
color.
A
Pipeline
is
passed
so
and
that's
why
that
review
up
so
I
could
see.
You
know.
One
commit
I,
got
all
the
changes,
so
there's
not
there's
not
really
not
a
ton
review
there.
There
are
some
that
get
a
little
more
complex
because
adding
a
new
illustration,
a
new
icon,
creates
a
new
release
for
this.
What
we
we
try
to
do
is
kind
of
do
a
batch
release
at
least
four
icons.
A
Make
sure
that
excuse
me
that
it's
been
added
and
then
it
looks
correct
that
it
scales
color
changes
all
of
that
yeah,
but
pretty
straightforward,
and
that's
where
that's
where
you
have
the
ability
to
you
know
it's
primarily
a
visual
change,
but
on
the
code
side,
you're,
just
making
sure
there's
no
conflicts
and
everything
looks
good
as
well.
Yeah.