Layer5 Meshery Development, 20 Jul 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Meshery Development Meeting (July 20th, 2022)

Description

Meshery Development Meeting (July 20th, 2022)

Agenda:
[Pranav] Reset Database: Panic on Reset issue#5800 PR#5817
[Gaurav] Progress demo on support for source-type, import type specific modal and downloading source content on Applications UI #5775
[Harkirat] Added Details to Applications/filters #5853
[Debopriya] Discuss Forum changes.
[Ashish/Abhi/Uzair/Gaurav/Ruturaj] Enhancing applications to include explicit source type.
[Ashish] Refactoring `Version` in Core components and enforcing `Version` field in Patternfile Service.
[Rohith] Copy to Clipboard tooltip not aligned #767
[Aaditya] Workflow to update components of the adapters to Meshery repository.
[Alpha] Progress on fixing golang unit test bugs #5843
[Manik] Navigator Active Tab Enhancement #5834
[Abhi] Fix e2e tests for Filters, Ask for volunteer for applications and Designs Tests #5794
Maintainer @Mario A. made a great doc for those wishing to contribute to Cypress tests in the project - End-to-End Testing
[Abhi] Fix version issue in Pattern-configurator #5793

Join the community at https://layer5.io/community

Find Meshery on:
GitHub: https://github.com/meshery
Twitter: https://twitter.com/mesheryio
LinkedIn: https://www.linkedin.com/showcase/meshery/
Docker Hub: https://hub.docker.com/u/layer5/

A

Okay, are we good to go.

A

Okay, so hey guys welcome to the machine development call so to start things off. Let's begin with getting to getting to know our newcomers, any newcomers on the call who would like to introduce themselves voluntarily.

A

I'm gonna start taking names.

A

Okay, christopher yeah, okay,.

B

Yeah, oh sorry, to interrupt. I thought you said for a moment that it was voluntary to be able to introduce yourself.

A

B

Otherwise, you'll twist their arm nice, so christopher, is uh has been been around the block um before so he's. um I I think he's introduced at um once or twice. I'm pretty sure on this call he's got an open pr at the moment that scares me. It's like it's like a great pr and I'm scared about it.

B

He's he's moved he's moving a lot of uh uh he's cleaning he's doing some house cleaning and it's um I don't know it's so easy to miss. I mean anyway, it's nice to have christopher with us.

A

All right, so I don't seem to see any more newcomers. Anyone else who would like to reintroduce them. Yeah sure can I go yeah yeah sure go ahead.

C

uh Hello, everybody. I think uh there are some people who don't know me and whom I don't know so I'll, introduce myself, uh I'm zainab movies and known as them here in the community. I've been here before.

A

But I have I, I was a bit.

C

uh Off for some time- and now I'm back here so hi, everybody.

A

A

Anyone else who wants to introduce themselves before we move on to the minutes.

A

Okay, I guess not so let's get started off with the agenda, then uh pranav you're up first yeah.

D

I'll quickly talk about my topic. It's like um the problem was that, like michelle, provides a feature for resetting the database database is basically a place where all the objects which we get from sync are saved. So, for example, if your, if your database is corrupted or you want the steel data to be deleted to be removed, and you want a new um instant of database, so we had, and we decently added a new feature for doing a hard reset, which basically means from deleting everything deleting the object.

D

I'm deleting the current battery in my database instead and creating and generating a new one. So um like I, we um observed that there were few like the mystery was going to a panic state because of it and like sometimes I when I was testing it.

D

I see this error like the reason for this was basically because our initial approach was like. We were like I've explained here. The approach was like we were um deleting the we were closing our like initial database handle and we were generating a new database channel for that and- and I believe that, since the data, the new database handler was not being passed to the all the operations which required it in the like, which is which taked it from the main goal routine.

D

While misery started for the first time, but since we were not passing it again, while regenerating the handler, it was leading to a few errors. So I what I did was I um like. I, I just changed the approach in which I'm now, instead of like closing that connection and like instead of closing the connection and generating a new connection like we do on the machine loading machine for first time.

D

What right now I'm doing is that I'm just I'm deleting every um every object, deleting every table which measures for storing data and then I'm regenerating them so like this doesn't lead to that problem which we're having initially, which was like something we were seeing. Panic state or something we were saying like error log like sql, is closed. Sql database is closed so now, if I quickly demo it like this here is already merged.

D

So if I already say I'm already running it- and I already have few objects in my database, if you as you, can see it over here so now, if I do, if I just proceeded so now, what happens? Is that um that I've also added for logs this means that the current all the database tables are being dropped? If that was successful, then we see this log, then we are migrating.

D

The mesh database, which basically means that we are generating new tables which would be used for storing the data and then once both of these steps are successfully completed. Then you see this log that hard reset was successfully completed now like as soon as hardy city successfully completed. We then we have. uh Then we have an operation that is resync mesh, releasing the connection with broker, which basically means all the the current um state of cluster is reasync and all the the mystery data is sent back towards the um to the machine server.

D

Then these are those are again saved in the database. So that is that you can see again all these objects were added. So now it works successfully.

D

A

D

E

Yeah sure I'm sharing my screen.

E

Okay, so I'll be uh discussing about um all of the collaborative work which is done on this pr ad source type and support for downloading source content. So this pr contains all the backend and the front end changes done by uh ashi user natish me raj and lee.

E

So this has some active bugs and some feature needs to be implemented completely so I'll be uh demoing the import process and downloading the token from this uh source column type. So, let's start with first importing an application. So here you can see. I have added a drop down over here, which shows all the possible file types yaml via ml, rg, zip, docker, compose gate manifest and helm so and like for ux perspective. You can all also see that if I uh click yaml from the drop down, so it automatically automatically gets updated over here.

E

Also, so the user would be like knowing that yeah my file type uploaded would be amazing. So if I select yaml over here and like hit browse so it will just show yaml files over here, and let me also show you this thing so my uh this folder contains uh text file, zip file, yaml uh jpeg file and a js file.

E

So currently, but I have selected a type yaml, so it would just show me the ml file so I'll, just uh import this emoji ammo so- um and this is our type column for uh source type, which will uh this needs to be done. Some work so currently it's just showing the gate manifest column for this thing later on, it will be soon updated with docker, compose and helm.

E

So, if I hit um do this like over on this communities icon, it would show click to download, but, uh like a suggestion was made that um it might not be much intuitive, that for the a new user that uh this thing is clickable, so for that we will be replacing it with some more uh relevant and relevant icons. So, if I hit over this um communities, I can so this file would be downloaded.

E

And yeah the file type needs to be updated when it's get downloaded. So here we can get the downloaded uh application from there.

F

By the way in the source type, can you go back to the import? Can you click on import application and go back to the drop down yeah here uh the query parameter the thing that we pass in our query parameter. Are these docker compose creates manifest in helm? Are these things hard coded or are you using slash aps application, slash types to extract the available types.

E

No no for this thing I'm like currently I'm hard coding it because helm is only available for rgz and undocker compose composite manifest for yaml environment.

F

Yeah, so, okay, so first thing that the file type, the file extension and the file type uh here are two different things. So it can be a yaml, but then, along with being a yaml, it can be a docker compose yaml or it can be k. It's manifest. So uh these things uh sitting together, don't uh look like that. Doesn't like quite make sense to me. Yeah, the file type should be asleep arrested.

F

It should be just docker compose helm, chart and communities manifest these three things, and um this thing that you would pass in the query parameter you. That would be what you would get from slash api applications such types that you can you'll get an array back and those are the available types you can beautify those and put it in a user-friendly way, although that comes in a user-friendly way and that yaml and tgc can be another column, so basically a file type in a file extension.

E

Yeah I'll be using that.

F

Yeah, actually, uh I should actually not use file type. Please write, I should say application type, so file type can be the yaml tgn and then your file, the application type, are those three things. So we need a way to select both these things.

E

F

And don't hardcode the application type only uh like so that you can in future. If you support a new application type, you don't have to make a ui change. Just uh your head, slash api size, application types, get the array and use that content so that.

E

Only these uh four yamaha ml and charge easy and they would be hard-coded first I'll, be.

C

E

Yeah, okay, yeah I'll, be fetching from the endpoint.

F

Yeah after fetching from uh the thing you know the api should be there, you know yaml and dot email. That is easy. I think it's not required.

F

Again, uh I think I heard that uh gaurav said that uh he will be truncating. You know uh your api endpoint results with the yaml yml entire cc. So uh I don't think so. Don't don't append that, though two different things you can. Basically what I'm saying is that uh you can in your head. You can imagine that the application type will be used as the query parameter source type. That would not be used to constrain the way ux looks like and that yaml tdz can be used to. You know that file name or whatever.

F

That thing is like you can select specific files or specific folder or whatever that thing that would be controlled by that file. Extension thing, and that is completely separate and the other thing is the application type which would be used as a query parameter in the post request that would be sent.

F

Okay, uh last thing I would like to add is when you click on browse, uh uh when you select one of the files, so it doesn't uh wait for import. uh You know: click on import, right, akara,.

E

What uh it does not make an important browse.

F

Select any one of these.

E

Yeah, it won't.

F

Yeah so I'll just uh you know, assume imagine a situation where you know if you click on the upload import application again and then uh then this last uh drop down that you are seeing here, a user may be wanting to fill it at the end, not before you know, browsing the file. So that may be one of the condition where uh this whole source type thing will be missed, so uh first uh yeah, so import only on import. uh Click on you know clicking on import yeah.

A

F

Yaml or doesn't look, you know uh very intuitive. What is dot yaml, so a new. You know, label that it is a source type or how it you know, a caption or whatever it's fine. Okay,.

F

Is that you needed to add something on this thing or what are you going to demo? The same thing.

A

No, I was going to demo this same thing with the that it.

D

Is downloadable and we can change the types and different helm chart? We can upload and okay.

F

And we would need uh according to you, what do you think we would need the pr and mystic cloud to land first or uh is basically the changes that you have made in mystic cloud? Are these backward compatible with, uh or rather I should say forward compatible? So if we merge that message cloud pr, uh would that be? Will there be any problems with the master of machine machine or saving applications?

F

For now? I don't do I don't think so, but I will test at local and then I will and the.

D

God of, can you click on deployments.

E

It has some issue with the source type quantum conflicting.

E

Yeah so I'll be fixing more bugs and like removing the hard coding for the source types.

A

Any other feedback.

A

All right, thank you, gaurav ashish, for sharing that with us moving on. Would you like to share your screen share.

C

F

If you click on the table view the import application button uh goes back to like. Can you click on the table view yeah, so is that? Is it intuitive that the button goes backward and forward so or should we place the import application there and.

C

F

C

It when used to go back and forth.

F

Bad at ux or someone might have a better position, but it just looked to me that the button goes from one place on. So I just pointed it out.

C

I think we shouldn't show the switcher if you don't have any applications.

D

E

Can just show the option to import.

C

And you multiplication.

F

I I think that would be an extra if logic, that if there is no application, then do this and I think that seems redundant. We can just. We can show both these things.

F

uh If, basically, if we don't really really, we have a very good reason not to then we should have this extra if condition that if there are, if there is nothing, then not don't do this table, because you know more if conditions means more uh possibilities of power.

A

Yeah, I think the switcher should be there. We shouldn't remove that. Instead of that, we should have a better empty state. What ashish was saying about the button makes sense it should it should be at the same place in both the views but and a better empty state than just saying no application found, uh maybe a couple of instructions on how to import an application or something like that, something more helpful than not no application found like that's what I think.

C

But as she said, I will do that.

A

Lee do you have any parts yeah.

B

Yeah, I hope that this is a transient problem in which um some work that root raj is doing with respect to, and some of the rest of you are doing with respect to mesh recloud will help facilitate.

B

Well, will help get us over the hump here in terms of users of the local provider. Strangely, they have sample applications available to them users of mastery cloud. Don't that's a weird place to be um and so yeah I don't, uh but I um aditya what what was your suggestion other than this.

A

I said that having a more uh helpful, empty state like maybe having instructions on how to import the application or what type of applications we support like some information, instead of just saying no application found yeah.

B

Yeah, totally and by the way, first of all, um um hakarat, it's just a great step that we have an empty state in the first place. So that's good, that's so often missed. So this is a good step. Then yeah subsequent steps would be.

B

You know like we're indicating we're you know um intimating to the user, where they how they can resolve their problem, which is to click the button. The only button on the screen, basically, which is great, um although when they get a browser, a file browser window, if they're a new user, they may not have um necessary context for what they're supposed to do from there and so to aditio's point yeah.

B

This isn't the only place in mesherie where, outside of just having a generic sort of empty state message, some additional help and guidance and like what is an application and and what are those different ways you can import, and you know and yeah. If, hopefully, in the very near future, there will be sort of perpetually there will be sample applications to pick from, and so we could almost well.

B

It wouldn't be the case that we would never have an empty state here, but hopefully, in almost all instances, there basically wouldn't be unless the user themselves deleted them all and was an advanced user or had some experience with measuring anyway. All of that to say great, this is the first. This is a great first step and then the next steps also, I would pluralize application just to um I probably anyway,.

A

All right any more thoughts or feedback.

A

Okay, I guess not uh all right. Thank you very much. Would you like to discuss the changes that you made on the discuss forum.

C

uh Yeah, you can go to the site.

C

So we now have a separate category for mesh map on the discussion forum so as and when you guys sign up for mathemata and even before that, if you have any questions about mesh map or if you face any problems or you want to know more anything, any sort of discussion, please make use of the discussion forum and especially under this component. This is just a small note that I wanted to uh bring up so that all of you are aware.

C

Yeah. That's all.

A

All right, uh thank you deborah for sharing that with us. Moving on, we have ashish abhi ozer gaurav raj is that is this the same demo or.

F

Yeah, that's that's the same thing or although this name is there because I guess it was meshes changes, but we haven't uh this last year. I don't think we have gotten.

F

Can I come back after the next uh thing, I'm looking for a document uh that I wanted to squeeze here, but I can't find it so just give me one second or or the next person can go. Then you can come back to me. Yep.

A

Okay, uh we'll circle back to you, then uh the copy to clipboard topic. Would you like to share your screen.

C

Yeah one second.

C

C

So um there's actually this error, where the clipboard wasn't uh aligned properly. So this is how it was during the initial stages. uh I actually made a pr that is now aligned properly uh and uh yeah. When this mode, however, um has the aligned it's aligned properly, and I added so my uh solution was to add flexbox to this, so um I mean it behaves properly. It's also responsive, and uh somebody told me to you know, extend the flexbox to the initial uh any other single page component as well.

C

So I did the same to the initial page component as well, um and then in in my pr there was actually a linting issue that I had to solve, uh which we brought it up. So I did that as well, um so yeah and uh one last thing I actually had I was also tasked to you- know change the styling of this drop down menus.

C

So um this is how it was first. This is how it is first, and uh this is how it is now. I'm still uh you know, I still need some information to choose icons for these two. So if anyone could uh suggest me some that would be good.

B

And a service mesh interface, it has its own logo, okay, um the icons that you're using be sure to colorize them in accordance with with the same color, the diaper links themselves are using or or even that.

C

um But when it has a silver background, it looks uh good when it is blacked out. um That was that was my initial thought, but yeah I yeah.

B

Or yeah, or not the background, but the fill or the stroke. Okay,.

C

This one right, yeah, yeah, yeah,.

C

Yeah, that's it for me. I guess.

B

That's nice, by the way you added, did you add a drop shadow to the I might have or to the you know, you rounded the corners of the menu.

C

Yeah yeah just around the corners yeah, okay,.

B

C

B

C

And if, if there's nothing, I know if there's no changes, um if everything is good with the model, uh because I can.

B

Complaints questions. Oh I've got a couple of you. Okay, is it possible to be rid of that scroll bar.

C

Yeah not this, uh this is actually the uh yeah. This is actually the previous thing. Actually there's.

C

C

B

The other thing that might be kind of nice is to distinguish a bit between the two controls, the link to the full page and the close of the modal.

B

With like something of a title bar, you could potentially make a title bar that has the name basic istio, install the two controls and then that segregates it from the rest of what the content is.

C

B

Or something something.

C

C

Okay, I think I know uh in my initial build it.

C

I remember removing the uh the scroll down on the right side. Let me just pull it.

B

I'll take your word for it: yeah I'm.

C

Struggling right here.

B

C

B

C

Is um it's removed yeah.

B

Oh, that's: nice yeah! You know this seems like it's a statically sized uh modal. If that's the case, uh you know it's like statistically.

C

No, it doesn't, it doesn't: okay, yeah it resizes when there is a lot of content.

B

Yeah or you get this scroll bar the size of the modal, I think probably stays the same, which.

C

B

Which is probably okay, except you know in the case where there are like no related patterns and there's a very small description yeah. It almost feels a little empty just because you could try this if you would leave the width statically defined, which it might help with positioning center positioning like you are, but um I wonder if, if you were to make, if you weren't, to define the height but have it fit the content, I wonder if.

C

B

Actually tried.

C

Doing that, but uh it wouldn't work. So I have to read this. I I I'm up for you know refactoring the whole design, but yeah that wouldn't work.

B

But yeah okay got you, but it would be good to push forward with the improvements that you have and then and then maybe maybe consider that yeah.

C

B

The two updates that you were sharing um between the menu and the modal here- those are two independent, colorectal.

C

Independent ps, yes, correct nice, yeah.

B

Nice, this, the catalog, is gonna, be highly used as a matter of fact, if it's successful well, I don't know if this is good or bad but like if it's successful, that's in part because of what you're doing it also is likely that we would need a different catalog uh because yeah, but but we've got to have this in order to make it successful, and this is um some good stuff, like collectively any questions did you know in terms of folks that might come and want to share a design which you are all welcome to do.

B

That's part of what we're trying to get to is that people might have designs that they want to to share, so there should be instructions um out there on how to do that. I think there are um the reason I'm bringing this up is to ask.

B

Oh, um is the so the download button, then, if someone does contribute a design or a filter or an ebpf program or whatever else, we have a opal policy, the download button. That would be that that the intention is for that to always point to meshri.io like locally. I assume, because the patterns the designs would be uploaded here right.

B

So yeah so aditya is probably taking notes and sub eddie is probably being shy, but just so that all of you know like yes now that you've added contributing instructions on how to allow people to add their own when they add their own they're, going to add it to the site, and so the download button should you know, download the the yaml from the site. The copy url should be a public reference to mestre.io, slash catalog, something something it should. Actually.

B

It would be very similar to the if you were to open the full page on the in the upper right hand, corner.

A

The format that I've given for the copy url is raw, github, user name, okay and for download yeah. You have to put in your own pattern file into this repository.

B

For download that doesn't make sense to me that if the user.

A

You can do it with binaries as well like a dot zip file. If you put a link to that, that would also work.

B

Okay but yeah, and that still doesn't make sense to me. It seems like the if it's a catalog, the cattle, if you're, going to make an entry in the catalog, which is a super lightweight catalog. If what you're doing is just making a brief description and pointing people elsewhere, the content isn't controlled, then isn't revisioned isn't guaranteed um it's potentially unreviewed.

B

The link can go away, like my suggestion would be that we're mandating that the user upload the upload the ammo and follow the spec for a successful design and as such the download button and where that location is, is not negotiable.

A

Okay, I'll just remove that from the instructions.

B

Nice yeah and then, but then add back-end support for ensuring that you know that its location is always specified that that, whether that's by convention.

A

Like if you don't put it under that specific location, it will not download.

C

C

Yeah, that's it from me. I guess.

A

Any more thoughts or feedback on that.

A

I guess not uh thank you, rohit for sharing that with us.

A

All right, we'll circle back to ashi's, then ashish.

C

Yes, I will like wait.

D

F

So this was uh this was something that I wanted to talk in last meeting as well, so this was about refactoring, the aversion field. So before this actually not before this, I should say right now: we don't um in the design spec, we don't mandate uh the presence of a version. So if you go and look at any pattern, you won't see a version field along with the type uh and a while back. uh So we have two things I'll go. So go back to this diagram that I have so suppose.

F

We have a pattern file in each pattern file. We have multiple services in service. We have type.

F

This can be your virtual service, dot, hto your http route, dot traffic, something like that and when you have settings inside of settings you have the spec for that and we didn't have a version field up until now, but uh in the uh in the mesh map designer we needed that version field to persist the version, otherwise it was going away uh because, uh depending upon from which of which version, we dropped that component, we needed to persist it somewhere.

F

So this was added a while back, and this was added in mesh remeshery uh now when, although this was added in hd still when the this service actually gets converted into this structure, we called component and that component is what's being passed around to the uh handlers of that component, which can be an adapter or it can be anyone who have registered its capabilities against that component. So if this virtual.

F

virtual service dot istio is the adapter, if it's traffic, mesh message, the traffic, adapter and so on and so forth, so that version field was not being uh propagated upwards because the handlers didn't care about the version we weren't mandating that and there was a pr made by me, and this is merged right now, although this is not being used uh so inside of component. I introduced this new field version so basically coming back to this diagram. So here this version- and this version is the same as the version you have in service.

F

So the whole idea is that to persist this version in we have in service, and the second idea is to kind of mandate it. So all components can expect that the com, all component handlers, can expect that when they will receive components there would be a subsequent version attached to it, and this will mean that we have three types of um three types of components uh which is a service mesh component. The the components that are handled by individual service meshes like, uh for example, virtual service and destination rule handled by seo.

F

We have uh kubernetes components like pods and deployments handled directly by kubernetes, and then we have our core components, which are our own components. We have the logic for them and they are higher order. Components designed, for uh you know, specific use cases. For example, if you don't want your deployment and service to be deployed, you can use an application which is a core component. So now, basically, what this will mean that all those three types of components will have this version field and all those component handlers so for core components.

F

Measuring is the handler for service mesh components. The adapters are the handlers and for kubernetes components. Right now. Measuring has that code. So these handlers, when they will receive this component struct, they can make use of this version field and do different things accordingly, uh so and uh related to that I had a pr up in the uh mystery adapter, so this was the first place.

F

I thought I should propagate propagate that change, and here I was doing the same thing so uh before this we had like a core component istio mesh core component uh and inside of the schema of that core component. We were introduced in version, but what uh I did with this vr is that uh the core component itself will have a version, so I removed it.

B

It's a quick uh time check. If we can, I think your your point is like hey. The designs, are the components are versioned.

F

Oh yeah components are versioned and this will remove the measuring version that we see in the design the drawer that we see that will remove the mesh version, that that would be the consequence of it, and the conference would be worse than that.

C

B

There there is some awesome detail behind this, though, that um I suspect is just waiting to come out either in measuring docs or a blog post or somewhere. So this is that's great, and this has this um ties into. I think you'd mentioned the capabilities registry as well, and so.

F

Yeah, so the definitions are stored in capability registry, so yeah the data stored in the capability registry would be different. It will include the version.

B

Now the capabilities registry for myself and everybody else here, that's a logical, that's kind of like the measuring database in a lot of respects. Right.

F

Yeah so yeah, so it's like hcd, but it's not persistent. So it's an in-memory key value paired database, uh which stores uh our registered components. So it stores capabilities such as, which include definitions and schemas and yeah. It's not persistent and it doesn't store anything other than the definitions in schemas.

F

It only stores those.

B

It's pretty lightweight, then, okay, so so to just, if again for me and everybody else, the components that get registered with mesherie these, like common examples of those components, are, are what.

F

uh The common example would be: let me go back to this adapter, so, for example, if I go into adapters.

F

Here, inside of templates, we have those component stores.

F

So uh for any so, let's say this: okay, so for each type we have a definition and a schema. So the example of one component would be that uh basically, a combination of these definition and schema so, for example, authorization policy. This this one is the schema, and this one is the definition both of these things would be sent in a single json file to uh to the registry and the data from this.

F

um This is the schema sorry, the data from this definition file will be used as a key, and the hash of the data from the schema would be used as a sub key, so that, even if something changes in the schema, we generally generate that component. So there is the key changes so for every key. We have a new value.

F

The value is the entire json, which includes this schema, and this definition and some other metadata also like uh host metadata like who registered it and that extra stuff that we do dynamically while registering so that's the value and key, is the hash of schema and the definition so.

B

Thanks for that, that's that's fantastic.

A

Anymore, comment or feedback on that.

A

Okay, I guess not thank you. Ashish uh moving on aditya the workflow to update components of the machine adapters, yeah.

D

I'll share my screen.

A

So yeah I've been working on an workflow to update the components, uh supported components to docs and show it in a table or forms, so the components are present in each of the adapters in workloads folder. So what I.

F

A

F

Workflow basically does is, it goes to.

A

The whenever a pr is merged merged in the master branch, it goes through all the uh all the components and then creates an md file uh such uh such in such a way.

C

And then it pushes to the.

A

Master of uh like in message repository, so I just figured out something that while ahish was giving his demo that there are two uh two there's a schema and definition of same thing. So I think I think we only need one of these.

F

Yeah yeah, you can, you can just filter definition and uh yeah yeah. You can just take definition. Okay, so just definition will be yeah and yeah even after, uh and even in that you we all only need the first, uh the if you you know dot separate these things. We need the first index, the zeroth thing, and maybe the first thing that linker isn't depending on where, while you're filtering and stuff the rest of mystery dot, layer privates, uh it's not uh important for in this particular table. We've already said.

C

A

Yeah that can be worked, and these are the like other two things that I figured out, but this this one is trivial that it basically says that we need to create a folder and measure report to actually to make this vr work, and this is the one which I was I stumbled on, because I, when I looked into the e2e test, there was a skip rule added.

A

I could not figure out what what it was uh so instead of the skip tool, I did a little bit change uh to run the only on push on master branch so like if this.

C

A

So earlier it was so I copied this on thing from the e to a test earlier. It was.

F

Pushed to push to master- and uh you know that you basically release and push to masters so yeah.

A

It is interesting.

F

Okay, I'm sorry, I didn't see that I was just looking at the comment in the desktop sorry.

A

So this works right so on push branch, master.

A

uh Okay, then I'll I'll make changes so that only the definitions, like only this part of the definition, is uh stored in the md.

F

File, do you have a demo or basically a view of how that would look like in the table.

A

F

A

This is just for the workflow I just.

F

Made a work with that copies: okay,.

D

So that would be.

F

A second that would be a second step from here: yeah yeah, okay,.

A

A

Any other thoughts.

A

I guess not. Okay, uh thank you for that. uh Moving on alpha would you like to share your progress.

D

D

All right, so, basically, I've been working on the fixing, the muni testers on the golang files. um If you are contributing to the mystery project, you might see this error often like this go like unit test has been filled.

D

uh Please look on it and that's because, due to the some of the changes recently made on the measuring ctl files- and they are not updated in the test files simultaneously, so I have been working on it and the my progress so far is uh one by third of the unit test has been resolved, but this bus. Actually, this part is actually missing in the app sub command. Then I had to figure it out and after adding it, the error was totally resolved.

D

So the other errors present remaining of the measuring ctl system context bugs and they help us grow box. uh But there is one uh doubt which I had in my which keeps in my mind. Right now um is: is there any changes made recently in the system? Context sub command in this month or last month?

D

Maybe because, like I've been seeing this formatting issue in the uh file right now that give me a sec right controls yeah after this uh giving some tap spaces in the test file, that's been working, uh it's being run actually right now, so.

D

Is there any recent changes made in this system context command? Anyone, if that's not, then it's fine, then I can just edit you or any comments from you.

B

um Yeah, it's a dj. Sorry, I wasn't watching the um I think the cpx adapter was deprecated in the recent past, which may or may not have affected some of these golden um there's always like using golden stuff like this always comes with fragility and so yo. I don't know, I'm always at odds with these, which is in part of my response to pranav about having a default user preferences reset. That means you're going to have to have a some golden set here anyway. um Yeah you might look for cpx uh changes.

D

B

The reason I'm asked.

D

Yeah go ahead. Sorry.

B

I mean yeah. No just this is just a total side comment. It's always unnerving to me to see the default token capitalized, because it's like the only one. That's thing: that's capitalized and I can see us making a mistake at some point in the future, but but yeah cpx.

D

Okay, so, due to the changes made in the cpx adapter this, for instead of two spaces, four spaces have been occurred in the actual context, so which causes the error in the expected right now. So.

D

I guess the test has been completed. Let me check quick.

D

Okay, still, no luck! It's been returning here. Even now, white space has been torturing a lot.

B

Okay, um any other feedback, any other feedback that you're looking for.

D

Nothing much that's it from my side. Oh no.

A

Thank you alpha for sharing that. uh Next up, we have manic with the navigator announcements.

C

Yeah, um hello, uh am I audible.

A

Yeah we can hear you.

C

Okay, okay, I'll just share myself.

E

Can you guys see my screen.

C

E

C

So this was the uh issue I was assigned, and uh this was a pr I have made and it's running here so you can check it. So this was the uh see uh in this we have to like.

D

uh Highlight the tab, uh we are.

C

Currently on so I have made this change and there was some reviews there, so I wasn't sure what to do, because uh there was some confusion here.

C

So lee- and I guess abhishek have reviewed this and suggested some changes, but I wasn't sure what to what are all the changes.

C

So if anyone can review this.

B

Yeah here let me give I'll give some extra context. I'm not sure I think monica I'm not sure if you got started on these changes or where you got started on them from there was a prior discussion about um changing the design of the menu.

B

There were some different thoughts um that this clearly isn't anyway, there's some different thoughts uh like this. The the issue with something like this is that it's you know unless the indentation is quite clear, it can be difficult to for the user to understand comprehend the fact that they're in a sub-category a sub-menu, hence the separate coloring that you see today, this um blue just conflicts with the light green and conflicts with the dark charcoal or whatever. This is um so. This isn't great like like I don't.

B

I don't think that there's a gonna, we're gonna arrive at like a clear answer for you on this call. Necessarily these are a bit higher contrast, still arguably less ugly, with this darker green on the dark background, the blue, those suffering these downward ticks unnecessary or should be made to be unnecessary.

B

If you have when you use separate coloring for the background here, it's not necessary to use those. So there's there's um a surprisingly a lot of thought that ends up going into um potential change.

B

I think this is your best reference, though I'll pop a link to this in.

B

I think, there's already a link to this on your pr.

B

My counselor to use to you know think through think through the need for high contrast, think through the or ascribe to the principle of less is more. If you would- and you know in context of those carrots that we were seeing those little triangles.

C

B

Yeah, I wish you luck like because it's not a it, you have to give it. You have to really give it. Some thought is otherwise.

A

F

Yeah yeah, so, uh first of all, uh these items are from the previous quality, uh but the time to you know attend one. So uh first first is the e2 we test uh fixes for filters and thus are fixing all the end-to-end tests. So the all the newer peers are should be. You know, uh should have all the uh end-to-end test, as well as integration left passing before merging and uh over over it.

F

The one of the most important thing that I want to uh ask is the call for volunteer, so we have already written tests for pattern as well as application. It is just uh commented out or due to the some issue at the time you are, you know, uh writing these tests. So uh it's no way uh like it's very similar to what we have written in filters.

F

In fact it is, you know the tests are already written, so you have to just uncomment it. uh You know anyone who is volunteering to take this off. uh We just have to uncomment it and you know, fix some errors in the way out. So uh I think that's much required uh from the perspective that we had.

F

uh You know seen some recent issues that we are trying to solve the same bug again and again, and that creates another side effect or some other works as a you know, consequence or whatever it is so uh you know adding these patterns and application tests will help and you are voluntarily like anyone who is uh just uh uh willing to start with cyprus and uh measuring way, it's a great first forward, step so yeah, and uh so, if you are interested, then uh we have two channels for our tests, uh that is cypress ui test and us measuring ci.

F

So you can just uh show your interest there. Second, is the pix uh version issue in pattern? Configurator? So I guess uh we had the issue where uh you know the patterns versions. You know the kubernetes versions are uh no only with the kubernetes version. uh It was not showing the correct version of the kubernetes component inside our pattern: configurator or design configurator now, so uh that is fixed and uh yeah.

F

That is much so these are the two updates from my site and yeah, since we are out of time, so uh we can move forward or if you have any comments or if you are willing to you know, act on any one of the issue or want to volunteer. Then yeah. You can unmute yourself invite.

A

Any volunteers, you guys, can write your names down in the minutes as well. If you want to volunteer to write some of these end-to-end tests and, like we said, there's a cypress testing channel on slack, you can join that as well and share your interest. There.

A

Any comments, thoughts, feedback.

B

Yeah those tests are just highly impactful and they get run all the time. um There's there's some running right now. As a matter of fact, we were watching them run on this call, so like yeah, they're super important.

F

One of the one of the uh thing that uh you know I would like to just add uh on the top of the heart is: don't you know, uh write all the tests at once. I'm I'm just asking for you to uncomment any one of these. Whatever you like uh and give it a go or try to learn cyprus, or at least try to store it. So you will you'll, you know really like it. So that's what I want to ask and that's what you have to deliver.

F

It will be a great first step.

A

All right, thank you away for sharing that with us, uh so we are right at time. uh Yes, do you have any major uh ui d structuring updates.

D

um Yeah uh not much, but uh I can show the scheming because we are updating the.

E

Theme for the restructuring I can show.

C

That and I started making the application uh page for the authority factor.

A

All right, if it's a small update, you can go right now. If you want, we can discuss it on the next call.

E

Okay, we will discuss it in the next call and I will also.

C

Give a demo uh write a message on mystery, ui channel, so that everyone.

A

Is in explicit way in which we are doing the theming? It would be great if you write it down in the readme as well, so that it's helpful for other people to contribute.

A

Okay, then uh all right, then we can discuss that on the on the next week's caller. Okay, thank you all for joining uh see you guys next week again bye. Everyone.

C

I need you bye.