Magento Adobe Stock Integration, 19 Nov 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Adobe Stock Integration public meeting, 19th November 2019

Description

Adobe Stock Integration public meeting, 19th November 2019

A

Alright, should we get started.

B

A

Hey so today, I'll be master of ceremonies and give the boss man saturday a break for one week, not really because I'll ask that he'd demo something later so he only get a bit of a break. So he not a big one. Today, hmm okay, well, lots of stuff was merged in the last week.

A

So, let's start with some demos from what was merged is by any chance Vladimir. If he's chanko call like for him as well, he said he might show up, does not look like it he's.

B

Not on the call and though I wanted.

A

Okay, well, he merged something. Let me see if I can pull it up. I think.

B

He might join a bit later.

A

B

A

C

Time sounds good. We're.

A

Gonna look back with him later.

A

Ok in that case, then, you didn't get a very long break. I said he. What about your change that you got in this week around some sensitive fields.

B

Yeah, that's actually changed from yesterday. Just want to show you my screen.

B

Well, I cannot share my screen. Can you go on? I will need to relaunch the application. Sure.

A

Okay, in that case, I have a couple things I wanted to demo, or at least highlight oh.

A

Well, you can see the screen. This is the PR. It was I mentioned this on the slack channel as well. The boats leveraging the sensitive credential storage that is built into em, FTF or functional test runs so I think for everyone. Who's running MFT of tests locally.

A

Definitely you'll need to move over to this new way of storing sensitive credentials, so the basically the for sensitive creds that the test sees right now, our API key and private key for Adobe stock integration, as well as Adobe IMS account email and Adobe I, and this account password. Those four things should be stored in a credentials file.

A

So under the Adobe stock image admin UI test, M FTF directory, there's a bit more detail about what what variable should be stored in that end file versus what variable should be stored in the credentials file and also a link to the relevant relevant dev Doc's documentation for both of those one being the M file configuration vs.

A

credentials, file figurations, so the heads up there please move over to this. It is a bit more secure if you are still using or running MF key F tests with all of the sense information in your M file. Then your test output will actually log out things like your API keys or passwords. Your emails so might not be a big deal, but it's safer to use this new method. So that's up there.

A

That was one thing.

A

One more thing: that's in process not merged, yet soon you're. My screening image is y'all, can see. This is enabling automated running of MFT F tests on Travis for all pull requests. It's kind of a big deal, as at least we'll be able to get n ft F test feedback on pull requests relatively quickly. The let me load up being just an overview of the Travis build as it relates to the project, so everyone can have an idea of what it looks like.

A

So we run a PHP stand as well as the more classic static tests in in Travis, as well as on Jenkins, so we get feedback from both runs. Why not?

A

We definitely run the unit tests in here, as well as on Jenkins and the new bits. Are these functional test? Suites you'll see that there's many of them right now we're running seven of them and the reason for this is a to try to paralyze parallel eyes. The runs just speed up give this up run a lot at the same time, we'll take less time overall, but also we, the I, think Travis is a 50 minute maximum build run time.

A

So if we run all of the NFT of tests in one build, it may take more than 50 minutes, so we split it up in this way. There might be a better way to do this, I'm, not sure open the feedback and for sure these are failing right now. All seven of these are failing. Some are worse than others.

A

Most of them, I think just have one failure, each which I think for a first pass is pretty good.

A

um The last functional test, suite last I, checked the c-more one I think has several failures, so we still have some work ahead of us to get these passing and the pull request is not merged yet, but expect this to be merged in pretty soon final note about this- and this is really important- is that, because of the sensitive credentials used as part of this, these are stored as encrypted environment variables in the Travis settings for the repo, which means that these encrypted environment variables are not available.

A

The pull requests sent from Forks so for some of our partners and community maintainer z-- that have access push access to the Magento repo great you can use. You can push branches there and issue pull requests from that and you'll get proper feedback there, but for people who don't have push access to the repo you know this might be something that will require a little bit of manual. I, guess: management of the pull requests just to get that em FTF best feedback over time yeah. So hopefully that makes sense. Are there any questions about this.

D

When you mention drinking is that the test suite that is running in magenta, sighs, I, wonder recently start implementing right. That's.

A

Correct yeah, okay,.

D

Okay, that was so.

A

A

Yeah so I think regarding the management of incoming pull requests once the Travis stuff is merged in you know, post review, if a member of the project reviews a pull request coming in from the fork and there's nothing malicious in that pull request like no attempt at stealing credentials or anything like this, then all of us collectively as maintaining the project, could do the work of pulling down the branch from the fork and pushing it up as a branch on the repo to then get the MFT f-test feedback, at least in the short term longer term.

A

The plan is to run the MFT of tests on Magento infrastructure, so this Travis based song-and-dance won't be necessary. That's that's the idea. Just the other way.

B

I'd like to it that there is while MFDs tests will not be passing on the pull requests will not be passing on your environment in environment because there are no credentials set up.

B

You still can add the credentials, your credentials to your Travis, built on your repository and run the tests on internal, like on internal pull, pull requests in your repository that that's how you can ensure that them, if you have dealt that you are preparing or the functionalities that you are going to deliver, is passing the functional tests just make sure to keep all the sensitive data encrypted and tries.

A

That's a really good point, and actually I should probably include that in documentation somewhere for the project. I'll make a note of that nice bring that up.

A

Okay, are you good to demo some stuff for a 30.

B

It looks like I have some issue after upgrading their bluejeans application I. Basically, it's very simple change that they wanted to share with you. So I can just explain: we've changed system configuration field types for API key and for client secret from password type to obscure type. There is a more proper type for the credentials fields and that also supports damping of the configuration.

B

So the situation and configuration is stored. A sensitive configuration is start in NV dot. Php file is as instead of database, so that should enable set in this configuration using the magenta cell I, secure secure can fix that command and also yep. It also basically covers all the cases of storing the configuration.

B

So in case you will notice any anything unusual with configuration. Please drop the message to shut. However, I don't expect that it will affect an a your configuration after the update or any functional test set. Oh that shouldn't have any effect.

A

Cool. Thank you.

A

Okay, I didn't have any other pr's lined up specifically, but maybe I could open the floor to any one present. Is there anything anyone would like to demo while we're in demo mode here.

E

I like to demo some key arts which I have created in further documentation. There goes oh nice.

A

Yeah, please go ahead.

E

Okay, I will share my screen right now. Oh.

E

Are you guys able to see my screen yep.

D

E

I'll create a TR for the machinery component, which we added in the magenta to repo by Sergey I'll created as the Dave dogs and it's much to the develop branch, so it will be telling in 2.3.4 version and I can choose. The demo also has a very great component or topic like the description and the configuration option. We have added here and also I added some example.

E

How we can I see a mercenary great in UI component and also added examples and a screenshot just taken from the adopts work, integration project and I also created another poll Ricou. Okay, thanks I also created another pull request for the image preview component same like the grid component, which is also I, have just created, and it still need to review.

E

So if you guys want to just quickly check it out and see all the options and description, and it would be pretty like the same as the image driven component dependencies and the configuration options which we have added and also the source files and another put another pod, because I'm going to too soon it's on the development mode.

E

That's the okay huh yeah! Much talks as we are started, working on much dogs, I have assigned I just assigned a task from so Phil might have assigned me. So it's rigged, it's the adult integration section for the configuration options, so I have also finished that just need to review and create a pull request in much talks. Here is their office of integration, configuration screenshot and the fields which describes what it's kind of going to do.

E

B

Just have a comments regarding them: the configuration section. If you could take a look on the latest latest version. There is some update or the layout of fields. Just some comments are reordered by the request of our designers, so I think the screenshot should be updated. Otherwise, I called and yeah labels are changed a bit so otherwise, like the configuration still the same and.

B

Yeah one more one more thing: I would like to ask if you could request me and feel as a river or any opening a pull request to any other part too much enter to repository, for example, or to Doc's repository cuz. Sometimes we can just miss out. That means that, to be sure for us to review it and and get them and give the best recommendations on the podcast. Thank you.

E

A

Thanks Shankar, it looks great.

A

Okay, any other brave volunteers to demo some cool stuff, maybe.

F

Maybe I can start, can I yeah.

A

F

Okay, nice, but my presentation will be a little bit unusual just so we are also talking about some successfully logits or pull requests of request and progress, but today I want to represent the one which it was closed. It was open and closed, but this pull request is a really interesting and it's in touch with them. From my point of view with a very interesting issue and if anyone from our community and today's music will try to solve it, it will be great. So what what the problem?

F

So the issue was created here stood four days ago and it's described like when you say if lisent image or even a preview image and then delete it when you open the grid after pressing the delete button, you will see the locate, but not the safe preview or life on safe and license button check. So I thought that this problem, as a result of some back-end stuff I made during May Adobe media gallery implementation, but no it's just interesting behavior.

F

You and I created a pull request for it where implements and Samba can start with which we can get image.

F

Image asset data on request, but you can read our conversation with Sergei and just try to understand. What's going on and what solution we needs shortly speaking, we need to modify somehow the way we communicate with the my sonal greet and our asset collection when we press something called a media gallery.

F

Navigation delayed image show maybe move it to another. Folder or I, don't know what else, but we need somehow to tell that our Adobe stock integration that the data was changed and yep. Maybe that's also if you want you, can just take this issue and proceed.

B

It thanks for sharing this Alex I think if somebody's.

F

Like very nourishing.

B

To start working on this issue, it would be good to contact me or Alex cause. We had a long conversation today about the implementation and we have some ideas on how we should approach that.

B

So probably we can help to start at least to start to provide some high-level approach for the implementation, yeah.

F

It's not a simple thing, but- and it also connected with some may be mostly UI components area than the cancer.

D

Initially she closed and then we I.

B

Think no, no, it's not the issue that was close to the polar quest that was closed.

B

The pure quest was resolved in the deletion, not the optimal way like having the request for updating that the information when we are open in a preview so considering the volume of browsing images that we can have that, probably not the best solution, a solution from performance and and loading point of view. So, while discussion, we identified that probably the best solution would be to update information when the slight panel is opened.

B

So once you open an Adobe stock integration side panel, it's loaded, but if you close and reopen it, it's not free loaded, it's not updated. So once you switch back to media gallery and delete some images from media gallery, you will not have updated information on Adobe stock integration side panel. So the idea is to simply reload the panel, but there is also a first entrance point like right. Now we are preparing the information when the media gallery is opened.

B

So once you open the media gallery in background Adobe stock integration is loading the data and preparing the top to open. That's why it's opening so fast, so considering that, at this point, user might also perform some work in media gallery that will affect possibly effects images, non-domestic integration right now. The only such case we are thinking about is deleting images we'll need to refresh the information on dee-uring when the tab is opened and here icon.

B

First initial initial opening not to perform double requests like to requests to back-end I, think it's better to initially load the information when Adobe stock integration panel is opened not when media gallery panel is open, so do it a bit later yeah, but I think the feeds the approach we is just refreshing information when the panel is open will resolve the issue. However, it's not the.

B

Yeah, so it will resolve the issue, but a bit more optimal solution is also to handle that first initial opening of the panel.

B

So apart from refreshing, the information in the grid in data provider, we also need to refresh the information in enable image preview panel and like in conversation with Alex. We thought that Alex is a very good specialist of we can develop development, so there are much more like there are a lot of back-end tasks and that Alex can work on. So if there are any front-end developers here or if you know any good front-end developers that would like to work with JavaScript, that would be a good task for them.

D

A

Okay, where we had here anything else, demo.

A

A

Did radomir fishtank, oh yeah,.

A

Would you be able to demo your recent pull request that coverage to the project or just talk about it, throw it to us yeah.

G

There's probably not into demo, but I can talk about it. So.

G

Yeah so I was, after my recent piston.

G

Improvement I decided to check all of other constants and I. Think I ran the test and it was fine and then I decided to check how.

G

How magenta checker works so there's a life caught test.php file, which has a few few checks, and one of them is checking for trick types, and it turns out that it checks only changed files, but it never changed the files you already have in the project and which are not changed so I decided to check. If we have this issue and I.

G

Found a few files and then sorry, that's it's time to nights and checker, so we will never see there again.

G

So it was not easy first time but then I simplified the test and it said basically it checks all of the PHP files in the register and search for strict echelon and set. And if you have any file which doesn't have it, you will get failed.

G

Travesty I check so after I check that it works I just fixed everything, rich it found met. Another comment so I think there should two comments, not one. That's right.

G

Yeah and that's kind of everything, so if somebody else will join it, the file which doesn't have straight three types, it will fail immediately, so our hundred years will not have to check it manually.

G

That's kind of a written ah yeah, maybe I, will check something else this week and maybe find some some other idea. What checking? What's ultimate, because this is kind of the thing which I like.

G

Yeah that's project code. Quality is good already such kind of heart. You know when you have something easy to find this one thing: okay, let's see you after. Thank you. That's everything. Thank.

B

A

Okay, I think that may be it for demos this week unless I miss someone I missed, you speak now.

D

One last thing: I couldn't avoid notice that when Shanghai was Damon his full request, he was also looking at a screen that shows.

D

Lack of Oktoberfest and I know that that's been going somewhere. I just wanted to see if we have any plan to to add those tasks, tax story to our issues in order to to get some points for the people that is competing to get those t-shirts.

A

It would be nice I'm, the new guy, so maybe I, don't know how it's been done in the past and maybe I've changed healthy things, but we've compiled the list of winners already and it wasn't based on tagged, pull request. It was more based on opened requests so.

D

Really, well, that's that's that's good, then yeah so I can show you I.

D

Remember. Last year, last year was based on issues with attack. Haku Oktoberfest. Maybe they didn't participate this year at all. No.

A

You were you in the I thought. I saw you in the list. You didn't get mentioned here, really, maybe not star to get your hopes up. Nope, you didn't mean.

D

I did participate last last year, but not this year. Okay,.

A

That's why well in any case, I think we it's almost 40 people in dimension to land who qualified according to our number crunching and we're up to about 10 or 12 people in Adobe land, so the gist of squashed, Ober fest is, if you issued five pull requests to either repose in the Magento github organization or repose in the Adobe github organization. You would presumably come up in our github search or who opened five pull requests in either organization. So we've done that search and compiled the winners.

A

And so, if you got mentioned on this issue under this repo Adobe's quest over fest, then you will be getting a t-shirt from us.

A

But you need to email me, your details, so I think some of you I recognize some of the names from this call. This community meeting. Some of you definitely got made the cut. So thank you for your contributions and hope you enjoy the t-shirt. I'm still waiting for a few details from a few people, but we'll be putting in the orders for shirts shortly and then as soon as they arrive, we'll be shipping them out.

A

So, looking forward to seeing pictures of you all in your snazzy shirts on social media lots of selfies, hopefully in the future, oh.

H

A

That was a little squashed over fest tangent.

B

Just a small of top question: if we started talking about square tobert, first I'm just curious what is the most popular repository in Adobe organization for the contributors? Probably you might know it mmm based on the data.

A

Yeah I reviewed the data yesterday, I, don't I can't tell you definitively, but I can give you a sense. I.

A

Had some really high quality pull requests issued to the CLA bot, the Adobe, the github app that checks, whether you signed Adobe CLA, there's some really good, pull requests that came in from that, but in terms of most popular I, think the Java testing framework adobe ride. It's called got mini documentation, improvements, tester under improvements improvements, all of them, and so that was a really popular one. That would be okay. That's.

C

Cool that's interesting. This.

B

That's really interesting how Adobe and merchants open source our margin to get room right now, yeah.

A

Slowly, very, very slowly but surely, and on the Adobe side we have lots to learn from how Magento does things in the open, I think the size of the winner lists kinds of shows you, the volume and the ease of contributing on each side right, so yeah we're getting together and working more closely together, but I think also adobe. Has it's still always to go to learn and get to that level that magentas that hopefully one day.

D

Okay, Magento site. We also have many things to learn about the VM and all the tools available resources and all the as you say it slowly push hardly be too bad.

A

Yeah, slowly but surely yeah for sure you know: I've worked at Adobe for many years and coming now, just in the last few months to work in on the Magento side more, it's truly incredible how the community offers I mean. This is me I think this meeting is a testament to how closely the business and the community work together.

A

I've never seen anything like this and it's a real treat to be involved in it and to experience it firsthand, and so what I mean that adobe has a lot to learn that that's the kind of thing I'm talking about is you know, it's I think it's easy to entice people to contribute with a t-shirt but to get the community involved to the degree where there's consistent and recurring involvement on a weekly basis.

A

That's very rare, and it's really impressive. So that's what I would like to see on the Adobe side and it the Adobe repos, are very all over the map. You know, whereas Magento for obvious reasons is much more focused, there's one product and the ecosystem around it, whereas the Adobe open-source repos you have eight different languages, supported from native mobile applications to web 2, you name it so it's all over the place and so I think it's also harder to find a and get a cohesive community built around it. But anyways I digress.

A

I can talk about open source stuff on it'll, be side all day. Let's get back to Adobe stock integration project, which is why we're all here so I think we're done with demos. um I, don't think we have mock-ups to talk about grooming, the to new user stories that landed and issues list this week or late last week, so unfortunately I don't think we'll be able to get to those unless I'm mistaken, I'm. So correct me, please.

A

C

B

Will be good that that's if at least, if all and I would like to quickly go through the stories without the mock-ups just to prepare us and that we can return to them back to them next I.

H

Heard my name sorry I was just like half listening and heard my name.

B

Oh no yeah I was saying that it will be good if, if you would like to like, show us the stories that you added to to the project or something while I run all mock-ups, but maybe we can get some short description just for us to be ready, watch to what we can expect to see with mock-ups on the for further meetings.

A

H

I recently updated the wiki page with the face 3 I guess.

H

So we can start from there.

H

It just gives an overview, yes go to the roadmap link.

H

It's like link link link that is code link, yes, scroll down, okay, so this is face. We are we kind of go through some of that stories, I believe, and we have some of their mock-ups I, don't remember specifically, which stories we kind of looked into details already and which we didn't.

H

So, if you'll give me like some hint on that, so what should I start with? And, alternatively, I can like start with the entire purpose of the face 3 and what is in the scope of phase 3 I.

B

Think first three stories already, but that was a few meetings ago. So I think you can just introduce the phase three and refresh us a bit then describe.

H

B

Recent arrest force again Thanks yeah.

H

So the main business objective for the phase three is to display the image status in terms of whether the image is licensed or not, and provide the ability to license the preview images directly from the media gallery for the users. So they don't need to search for the same stock ideal that they saved the preview off and licensed that preview directly from the media gallery.

H

So this is like the overarching goal of the phase 3 of Adobe stock integration.

H

So with that we are, we are updating their entire interface of the media gallery and adding the ability to display some of the basic attributes of the images right in the image grid. So it's not necessary to go into the details of the image to see that, let's say this is the stock image and it's licensed or it's not licensed.

H

So this is something that user will be able to see right from the image grid in the media gallery.

H

Well also, we add the ability to kind of open the image details and see more information about the image like, for example, when the image was added to the media gallery what what when it was modified last time? What is the source of that image like? Is it manually applauded or it was downloaded from stock, the keyword, the keywords associated with dead images, where that image was used on the storefront? Let's say: okay, this image is used on some on some number of products and some number of pages and some number of blocks.

H

So this is something that we can display when user views the image, detailed image information in the media gallery. So with that, we also add the ability to filter.

H

Images by their keywords, to kind of provide the better navigation through the images that are in the media gallery. So when user like select the keyword, we refresh the grid and display all of the images that have the same award and in addition to that, there will be some option to filter the images by the date when they are added to the media gallery and the date when they modified. They have been modified. So this is like their very brief overview of what is in the scope of face 3.

B

Sounds really thank you. Thank.

D

H

Yeah so Eugene promised that by their next meeting, which I don't know, are we going to have a meeting next duty or we skip the things given week.

B

Well, I, don't so we don't celebrate these things given in Ireland I think so I will be. I will be able to make this meeting if you would like to skip it because of Thanksgiving. We can postpone it until the Tuesday in in then next week. After next.

H

Yeah I mean most of us are going to be gone for entire week, so.

H

But anyway, yes, next.

C

H

Next week is Thanksgiving week yeah in u.s.. It's kind of May like make holiday used to be in Ukraine just like officially two days, but in fact it's like an Terra week, nice yeah so but anyway, Eugene promised to have the mock-ups ready and I will complete the stories.

H

So you will be able to go through them like without me. I don't know if Eugene is going to be available, but I guess so so you will be able to go through that and like. If you have some outstanding questions, we can have a follow-up, I think it's. It will be like more efficient than you just keep the entire week.

B

Yeah think I will be able to do it feel there the week off as well. Next week, no.

A

Canada Thanksgivings in October, so I already, okay,.

C

Good, so we will be able to go through it. Oh yeah.

H

That would be great, I think.

B

We could just go through stories if the mock-ups will be added and they will be completed and take notes all the questions and have them ready for the meeting when you'll be back yeah.

H

Yeah, that would be ideal and.

B

Hope you guys will have a very nice things given week. Yeah.

H

We will we promise.

A

Okay, thank you for that. Elena well, open call anything. Any discussion points to bring up Mike.

A

Right balance means no, though we will give everyone ten minutes back. Thank you for those in Europe for staying up late and we'll see some of you next week, thanks Ron, bye.

H

Guys right see.

B