Magento Adobe Stock Integration, 12 Nov 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Adobe Stock Integration public meeting, 12th November 2019

Description

News
Commands
PHPStan
Bugfixes
Dependency between modules

A

Okay, I think we can actually start the meter so last week was really important for us, as we.

A

We actually extracted to the components for some components and media gallery modules to margin decorum and right now they are available in.

A

Magenta to repository into three develop branch, so well, I, guess everybody's up to date with.

B

A

Here on this meeting right now, some of other Vista, some of great features developed and under the stock integration project, were actually developed, a magenta core, but we are continuing the stabilization and bug fix for the current milestone under bistec integration. However, probably we will also start to grow a bit of stories and features that we're planning to do in milestone 3.

A

So if you might notice, but like everybody right now, is working on develop branch in the mystic integration project, bursaries, one-zero-zero, release branch that was created for the first release of our project and the results so 1.1 developed branch that will be used for development of the next milestone, so that so that we could work on stabilization, bug, fixes and features for milestone, 3 at the same time, I'm not sure if we'll create tasks for next master, the new features soon, but it may it may happen even this week or the next week, and if you will be working on such features, you'll need to create a pull request to 1.1 develop branch.

A

Instead of develop branch were we are stabilizing the implemented first. Not all so. Let's say that Adobe stock integration is going to be a bundled extension who is magenta to the next release, so probably it will be. It will be by default available when you install the magenta to matter package.

A

So these are some news and updates to start the meeting and now, let's actually, if anybody has any questions about what I just said, I'm ready to.

C

Maybe one quick question about grooming. Sorry, maybe I need something, but we have planing going or.

A

Next milestone and when yes, I think Yujin is hearing the call, he probably will be able to share some new mock-ups or the master on tree development. We have groomed three steps, three stories already from the mountain tree. Probably we will repeat it revisit them, I hope next meeting when Elena will participate.

A

And yeah, yes, sir, we we are planning to start groomings on Austin tree as soon as possible. Okay,.

C

Nice, how I want to join it, because I have two ideas: the first one about common sense assets, parts of the Adobe stock integration and the second one is just about the multiply five actions. It will be nice to discuss some stuff. Okay,.

A

Misery, you can create issues for that ideas like a feature requests so that we can even review them before the meeting may be discussed so that will we can be more productive during the next mission. Where will groom this meeting man and groom? These features like discard this features and consideration. Okay,.

C

I will try to prepare them, but it will be nice just to see you what we, what vision you have for the next milestone another just not to create the same stuff. Maybe we have one common idea. So if you have a link to possible stores- and it's just place and it's a little review and that I.

D

Believe we will already like to groom in the next two weeks, because, right now we have some kind of little reorganization and, like most of our resources, all right now focus on focused on it so and I believe in the next future. We will have clear, clear time, estimates and clear the scope of work.

D

What we need to do- but this again is Sergei mentioned, like always, cool, to have some kind of cool request to see the idea and I believe it won't be some kind of overhead what we already have and we plan to do. Oh, okay,.

C

Nice, an arrow at. Thank you for details. We.

D

Can discuss even even before doing so.

C

A

A

Good then, let's continue to pull requests demo.

A

Who would like to be the first.

C

Maybe I can okay, one second, I will yeah. Do you see my screen? Yes, okay, nice. So today, I want to report about to I want to discuss two things. The first one is just the open pool requests the first one, the media gallery: module where I provide you unit test block forget by ad comment talk currently it's under review, Thank, You, Sergei and rest up for reviewing this stuff, so I implemented all required changes and waiting just for test finishing. Also.

C

If the spooler class will be approved, we will represent the new way for current test for comment with current unisys. It's very from my point of view interesting and constructive.

C

So, but I don't describe it's only will this way will be approved, but I would say that we decided to divide divide test on several classes, and this makes them more clear for understanding so, and the second part of my report also will be linked to the comments approach, and this pull requests already mentioned already merge it and its main role is just to provide stabilization for several comments. We use in Adobe stock integration. You see, we decided to use comments, approaches the main principle to deliver a composition in our project.

C

From my point of view and the point of view of Magento community developers. Yes, composition is a great that forward sister, the Lester's make a great, stable and plea upon the staining application, because, when you use common to you just follow the KISS principle and you make your quads really as simple as possible and at the same, at the same time it does things so in this pool. Quests I provided next changes for Commons.

C

Firstly, we pay a lot of attention of the way how we provide how will present exception, because something can happen, and it's really useful for integrators and magenta users to understand where the problem happens and what the reason we tend, how we can how we can solve it quickly. So we use this style for logging messages. So we include logger, make it's a critical service called that, and every exception has its own.

C

Mindful guard cells, we use integration exception for general things, and this value as well and as you can see a message constructed from the text and we also provide some arguments. Is this just static test? But maybe this is not so critical but nice to have, and also the final version of this tile which we implement. Our performance looks like this.

C

The common hand has one public method execute and inside is we have a try-catch block where we provide needed project and just catch every exception, so maybe this will be the way for all commons who represents its in the Bisto configuration and media gallery module.

C

The yep made is at all. So this is how we built really simple and beautiful honking god.

A

Yeah, that's very nice. Thank you is just one.

D

A

Yeah I just wanted to say that we we had actually you using pointed out to the to our approach of login the exception yes asking to provide as much information to the blogger as possible, and that was last week when we were reviewing the pull request to Magento into core and that is still not applied in this code.

D

Yeah, that's actually what I want to mention that it's actually good question to raise a discussion because, like if you're talking just about simple case, when only developers work with this lock and this local, like oh, oh, like the magenta configure it to use only monologue. It works very probably some like extra work like to localize this exception, because, probably from my perspective, I all like.

D

Usually we work with English language in like in different system and probably it's better to always see like a lie, not like a lies exception, but the original error message without any localization and additional stuff. The question is, for example, if you use some customs, a party system to poor login message not always will be enough, and it's better to look like exception with tech trace, etcetera, yeah,.

C

Yes, thank you I, remember this Harry your review and I'm working on the implementation, where they'll fix the way. Previously we up messages so I'll I will I will lock only exceptions over the back-trace. This is really useful case think that we should create message only for maybe some localized exception and not it could not safe exception. I, don't know integration accession because really it doesn't make sense on on this level of architectures I.

A

Think, apart from that, that's perfect, thank you. Yeah.

D

A

D

Has own opinion about localization of federal messages? Just let's discuss it. I.

E

Actually have a doubt in the previous PR which he mentioned regarding the unit test which she wrote forget de ID class I'm, looking at the pier and I noticed that you have you've created different files for each kind of exception and one for a successful case. What's actually the reason for this just.

C

That explains they say stuff. Do you know that we use the peach PMS detector and the gate by the comment has reaccept and one successful result? Yes, name.

E

C

And if we will collect all this stuff in one test, tersely, it's really hard to understand. What's going on, and next we will have exception in the PHP maze detector, because we include more than 13 injections. So this is why I decided to to divide them into several classes. So what test classes and every taste the test class has its own, mindful name so yet by addy exception could not find such entity exception tests and something like this and the reason just in this don't not to cover unit tests with do not suppress exception.

C

Firstly, and just ladies at all, yeah.

E

I am, and but you are telling that creating different methods for each test case in the same test class is causing those mess. Detector exceptions just kidding. Okay,.

A

Okay, it's happening between objects. Coupling between objects is modern. Okay,.

E

Because I yeah I've seen in Magento core code that usually like only one test class is used, and if that mass detector exception is thrown, then you know you just suppress it.

E

So is there any reason we are splitting it and not suppressing that mess detected exception or.

A

Well, yeah, it's always better to not suppress the static test. Our static tests are actually running to to recommend us how to write code better. The reason why they're supposed suppress in some core files- maybe just after the enabling after enabling these tests there were lots of lots of files in these folders that were not that Magento was not able to updated at once and that's why they were suppressed, maybe, but for new code, it's better to follow the static tests. Actually, what that's?

A

What this this error is telling us that there are too many objects involved too many classes involved in one file and that's why the file might be too complex for readability, so, dividing this this class into several classes will improve the readability and will improve the beauty of the code.

A

Okay, thank you.

A

Kelex, the Darsh as you started, what do you like to write next.

E

Yeah, so yes, let me just share my screen.

E

Yep, so one of my peers were the licensed label would be thrown off the image if the image is too short in height, so I fixed it by calculating a dynamic height based on how high the images or how tall the images so I calculated and always make sure there is around 30 pixels in the bottom of the image, I mean below the label, so there will be like 30 pixels in the bottom and in the label and in the image, so I fix it by putting a dynamic top displacement and I can demo it right here.

A

C

E

The image which was posted in the issue, which had the issue and it's fixed, and if you see the stop displacement to the container, it is 87 which is dynamically calculated and, for example, this one, which is a slightly taller image. The top is 81, so we can see that it's dynamically calculated and it ensures that there's always some space here so yep.

E

That issue is fixed now and something else which I noticed and I learnt today and Sergei suggested that I share it with you guys is the module dependencies which is either hard or soft. So I learned that in the composite die Jason, if you put it as a require, then it's a hard dependency and if you put it as a jest, it's a soft dependency, and actually this is actually in cut. There's a missing example here and I'm submitted a PR for that as well.

E

So if you yep, if you put suggest it's a soft dependency and if you put a require it's a hard dependency and the module sequence, node is not actually a hard dependency, whereas it just defines the module load order and it is considered a soft dependency. For example, you need the module, but it can work without that module as well. So that's something I learned today and the dev dogs actually has a missing example, which I have committed a fear for too, and that's about it from my side. Thank you.

A

Great. Thank you. Thank you.

A

Okay: let's go who's next Oh. What what? What? What join the call hello? Would you like to go.

A

To show us some pitch pistol, I.

F

Know yes, okay, yeah, okay, so PHP I cannot give a lot of information about pitch piston, so each piston the what? What can I say that each piston can actually find errors in your code, which will be missed by linter or just some testing or some tactics. So, for example, you can find so if you have some code used, for example, in the catch part of the of your method and while testing you usually even don't you never go there and in the this part you can have an error.

F

For example, you can have fun defined variable, so the variable which you.

F

Actually create inside try or you just don't, have it or I fixed another project where there was just missed import, though there was a phrase. I think there was something like a new exception, throw in with a phrase and inside and price was not important. I, don't know it sounds like this and when you run a quote, it doesn't give you any errors. While pitch piston will actually check everything and you have different levels of checks.

F

A

Well, let me just give some context: Wolle have opened the pull request to atomistic integration, introducing page based on tests to Travis, and those tests discovered a lot of code smells that were not discovered by our static tests and existent static tests yeah, but basically by Magento static tests. So we decided to include the pitch based on as our Travis tests, our Taurus test and fixed oh yeah, and we'll also fixed all hot smells that were discovered a please.

C

F

So I believe that on any project that so you have different types of checks like from level 0 to level 7 and level 0, we'll find actual errors like level 2, we'll find some possible errors or problems with your types and level. 7, we'll probably find something which is not really important, so I believe that level 2 must be included in any project because it just gives you like. It shows you errors like real errors in their code, and it's good that we didn't have it at all. On Adobe stock module.

F

Most of the errors were found in level 2, which is something I usually find with code. You during code review, so I check. If that type you provide in the method, is the one you you actually use inside. So the example is you provide all their interface or their variable inside the methods and then inside you use get data.

F

So in of the cases that will work because, instead of order interface, you will get order, object, reach as that which is inherited from data object. So it has this, but it's not good design and it's actually error and you will find it in that I'll also. So we.

F

Included tests for level two and they fixed all of the errors, I found more or less. They were like this type in sirs and if you undefined things and from now I think it will check it and Travis every single time as soon as it will be merged to develop right. Oh.

A

Yeah I guess I guess it is merged to develop. However, I'd like to say that if you, if the Travis tests like page based on, fails on your pool request- and you have doubts- because we don't have too much experience in our project- is based on so right now it's an experimental mode it can. It can give you a good advice on how to adjust the code, but if there is some situation that you are not sure that test results are correct, just let me know feel free to.

D

It doesn't have suppress warning like, for example, mess detector has it, and in our case it might be important because we use plugins and in some cases we don't use the arguments, the original method. In this case we will have the unused method argument and their fixed and will fail on it, and there is no way to suppress. It only may be playing this. The error check level but I'm not sure actually, yeah.

F

So maybe it's on the higher, maybe some level, 3 or symptom, is so yeah, because for right now it's not failing. So, let's see anyway for everything I found with level 2 I would probably ask person to change it if I would see by myself in the code review. So it's kind of good check for yourself this kind of automated code review, so it's like code, style checks and peach based on checks, you more or less covered entirely. The only thing you have to actually code review is logic or if you are doing stupid things.

F

Yeah another good thing that it's very, very fast I checked it on the project where we had think 30 thousand lines, and it's like a few seconds, so you can check it every single time.

F

Okay, so we do want me to go through the bags were found so like a common common errors.

D

Quick, quick, quick question: yes, you can figure it to work on the d4 for the whole project.

F

For the whole project for the Jeep, we'll probably have to I I dunno how to step it. Forgive if you know please share it.

D

F

D

I know a few guys they are also playing with it. They also like working on how to work it this deep because for magenta it will be like it wastes a lot of time to just run this test, because the project itself is very big in general, doesn't make sense to run the test again over the project, because you probably want to have like to check on this difference between two two commits I.

F

Think it's important when you have already approached with a lot of errors. So if you have fixed like in your level project, it's not a big deal, because it's very very fast I haven't seen anything working so fast. Even all of this code, sniffers or everything works slower.

F

So you can actually run it every every single.

D

Because they base it on.

F

D

A

Yes, Oh, probably you can check how it's called like how its executed in the traditional and run in the page, based on locally even before commit and before waiting for bills, to pass. Considering the speed.

F

Yeah also in the I, don't know a good way for us right now, but in theory we can all of us can just configure procore meathooks or something this.

F

So there is a way to have share it with your meat hooks.

F

So when you setup a project, you can have this requirement hooks set up automatically and there can be checks running, for example, for code styles or each piston, and all of this, so you will find errors before you will even commit which will save you a lot of time.

F

You will not have to wait while trials will finish all of this and there's I know a good way to do it for the if you have a full project, but for us it's a bit different, because we have to kind of have Magento in our module separately and to be a bit more complicated yeah. If I will find the variable over shared with us.

A

F

A

Sounds interesting, yeah we're thinking about hooks I'm, not sure it's actually not used on us other projects as well. I have to actually check the what experience our guys from community engineering ahead with other projects like a Masai graph, kill and so on, and why the hooks are not used. They're. Probably there is a reason for that, but maybe not yeah.

D

I believe few years ago, we had some kind of pre-configured hooks to do not allow commit empty messages. It was like one of the rules inside their company, but.

D

No, actually, probably something we do something with it.

F

Again, I use it right now, but for the project. So it's just the way to stop there. If you will want a person to set it up, you will have to add, like part of the readme or Vicki, when you set up your Adobe stock project. What else you have to do to make it work, because I think we cannot include it inside our like repository, it's kind of not related.

F

Sorry I can think about it and maybe I should make.

A

A proposal- or sometimes this yes sure, feel feel free to add page to week here and describe and describe it, and that probably you cannot the hook as some text inside the week. If you don't want to commit it to repository.

A

Yeah and yeah, we can take a look on it and discuss it. Thank you.

F

Yeah see it's March now.

A

Great. Thank you very much more.

F

A

Sure other any other volunteers to demo something.

A

E

Just a moment something to the routines.

A

If, if you need, if you need a bit more time to stop the environment, we can we can first a clue. Ok,.

E

Jenny share my: can you see my stream right now? Yes,.

A

E

Ok, cool I will start the demo from the from the issue which we have found in our previous meeting that remove the first image from the related images like more from model and more from series. I have created a full request, but also form then issue related that.

E

Currently, we have remove the first image from the more from series and more from model, but I saw some of the cases in which the first image is not not the same in the mode from series or more or more from model, as you can see here, that mode from series doesn't have same and mode from model doesn't or does not have the same force image. But if you go for some any other image like this.

E

Here we don't see the same image, but if you check out the model here, the second image is the same as the preview, the into the same image as the image preview, so I don't have any idea. So what we can do here to fix this issue that we move from the more from the more from this model, could we add a check maybe to check if the image ID is the same for both and then, if it is, then skip the image and not return it.

E

Can do that still.

E

Limited of the related image like we are passing the unilateral image that it's a fixed amount like 5 of 4, so I, don't think that it would work. I. Think.

A

You there is I'm, not sure if it's possible, but can we try to adjust the request for the images when we are requesting the same series or some same model images.

A

So the request right now is model ID equals to the image ID right and we can add another filter, same image: ID not equals to exist in image to the image. The treasure.

E

Yeah we can try that that filtering the image ID with the mole from series or more from from this model. We can even try yes, oh I. Will that and my another key erase license overly liberal is missing or just license image, as we are just now discussing as I now Sergey that this license image.

E

License image here doesn't needs to close the preview and also had some confusion about why we need to because this provider, as I started working on this I just started I just directly called the provider here directly in the same part, but I am getting an invalid error that the provider is not found all rights undefined. So this is the best way to follow the data they provided from the image preview to the view config.

E

But I'm not sure how it's working right now, because the same issue was happened for the part of this pull request, but from series ID and model ID filters as I check this. For like couple of weeks there / I, didn't find any solution, but, as I put the provider over the in the you can pick configuration and it's fixed the issue as you can steam that if I see more from the model.

E

The values persisted and if I log out and login again.

E

Oh, so it's not political that I thought that it is related to the.

E

This provider issue, but I yes, it's not I trusted for the couple of time, but I always got the model ID, but I guys saw the preview, it didn't fall, so I guess it. It needs to be someone at any other issue, but as I checked, the model ID its persisted in the local storage as I check the series ID and model ID both are present so I think it might be an issue because we need to clear the filter or somewhat it's. The model idea should be persisted in the test.

E

Local storage and it should be visible over here. I. Don't know why it's not showing over here.

A

E

Money, ideas, yeah and.

A

Serious ad is not actually a filters that is, that are available in the filter section. That's why I think they actually emergently compromise by not might skip those values and not added to the while rendering the active filters. That is just an assumption for me. So in these geese.

A

They just wondering if we should initialize those filters, our success as we are setting them from our components and we might need to initialize them from our components as well. But here he basically that's an assumption. But what we really need to do is to check how the saved filters the applied filters are actually loaded by them urgently compounds and then okay.

E

Okay, I can tie some other way to fix this issue, but I will try to image, lies in our component and type of instance. That's it from my side.

A

Okay thanks so yes for in hidden hiding the preview.

A

So if preview is not hidden.

A

There is an issue were series Syrian model images cannot be loaded because we update the data, so I guess all the information that we are storing in the record right now, it's better to store it not.

E

A

In the property of the our components, just to be able to reload the record and not rely on some custom fields that we are adding to the record during the routing.

A

E

But I think yes, I think the issue is regarding with the the related images, the related images are invoked on the on only when you click on an image preview. You click on that. So function is initiated and in this show function that all the observer observable array is initialized in the show image. So if we rewrote the data provider, then the show show function is not in slash, so the CDs ID is not initialized. So that's what we are getting with you I think, but not sure.

E

As I check the code, the only place where the related images related images are invoke is in the to function.

A

Ok, let's, let's take this offline; actually, that's a complex discussion or a public meeting.

A

Thank You Shankar, so.

A

Yeah, usually I think who we we are down this proposed demo. So if you can show us the new mock-ups that you have prepared or the milestone, 3 implementations, that will be great.

B

This one second, though, I have redesigned current media gallery slightly. So let me show you the full well, so user opens media gallery somehow, and we still have folder structure would not change in that. Perhaps we can redesign it a little bit to look modern, but the main thing happens here, so we changed how the actual assets are displayed a little bit.

B

So, apart from selecting assets that you can do previously, when you click on it and you can add selected one to the page, we also added this kind of like more menu, if contextual to each asset, and if you look at the ones that our stock image in its unlicensed, we can also license it from here allowing the same flow that we have.

B

The stocks without I can also see. The special I can hear that this is actually the bespoke asset and we will show if the asset is unlicensed, we're not sure licensed.

B

Label because we assume that most of the assets in a merchant gallery would be licensed, and they don't want to see that so we'll highlight on their line first one. So if you click on the big details, we're gonna show a slide-out panel with all the information we store on the particular asset. So there's like a details panel with file data, maybe you can also show where the SF is used, its tags and the other be stock specific data.

B

It will also show the full image preview as one else so user can also delete the effort and uploading I propose to move from the this view to the button bar have a blowed action there.

B

Yes, apart from that, it's still not very detailed, like there's. No, for example, there's no specs for all the sizes I'm working on creating a spec sheet, so you can actually start developing it you, you know all the colors and all the sizes for this, but this is the general flow people would take.

B

You have any questions.

B

Yes, so I haven't I, know I. Actually this before with this link, I know I, know showed before the search and filtering mechanism I just decided not to so we definitely can edit is that I think the important part right now to concentrate is actual actions that you can do to images, but you guys, if you want to tackle that first, the filters I can definitely add to this mocha plan and think about how filters would work with folders as well, because technically, a folder is also a filter right.

B

My assumption was, we just concentrate on the on the efforts list and make the efforts be able to license and V details from here and we tackled the filtering and all that advanced searching later but again, correct me if I'm wrong, and we can also do that as well.

A

And I guess, considering that we are going to use existing magenta eye components, that components and the filter that filters that were shown on previous mock-ups are, like their appearances, exactly as far as I remember much as to Kieran to other greets in magenta. That's okay!

A

But if we are going to consider any custom styles or filters, then it's better to bring up as soon as possible so that we can that we can plan, probably build some prototype and understand how complex is it and how deep we should customize the existing UI components to achieve the desired design and be here. Okay,.

B

So my question, then, would be if we use the grid component and we show the filters, do we still retain the folder structure?

B

Can we basically somehow replicate this thing in the new UI component world.

A

I'm not ready to transfer this question right now. Yes, I think it's possible to use it like we def pass to the image is actually one field of the image right now and folder structure is basically the representation of image pass field filter. So, theoretically we could apply. Probably the approach similar to the approach that we are using right now for filtering websites and stores like there are stores filter. That is also that also have several levels and yeah that that looks similar to that one.

B

Okay, yeah, then definitely we'll be adding the the bar with the search and filter here. I still think, there's some disconnect between that UI when you basically have a flat table, structure or grid structure and current media gallery folder structure still needs need to resolve that, but yeah definitely we'll be adding certain filters here.

A

B

Thank you guys that that's it for me.

A

Yeah you just got one more question. Actually from me, I noticed there is a checkbox right. When you select an image, it's it's actually a checkbox. Does it mean that we can select several images and taught them to and is it either.

B

The case right now so from now, as far as I understand in magenta, you can only add one image at a time when you are requesting a media gallery, it opens up and the basically direction if you select one and then you proceed so for now, we can, we can I, think, retain this functionality, but the check box is actually idea that we can then later use to add multiple images on maybe perform actions on own images like bulk actions, when we can select multiple images and say, delete them or remove them or edit metadata or whatever.

B

Definitely good question, though, like if you, if you don't, if you don't think we're gonna have multi select anytime soon, because again, this model is only for selecting one image. We can just remove the check box for now and have just border around the image and not use checkbox and basically add the check box later when this whole model would be allowing multi-select.

A

That's yeah, that's that! Might that make sense. Probably the question on these: are we going to implement Maltese legs and some multi actions during the next Maelstrom or later it's if and yeah yeah.

B

I definitely think that is like a work for later when we add additional functionality to the media gallery I as I. My point of view is that math on three would be simplifying the licensing process and previewing process from the media gallery. So you don't need to go to Adobe stock slide-out panel. You can save time and easy easier preview. Your all your assets in one place.

A

Yeah I also think that considering the number of customizations you'll need to implement well, we will not have so much time to handle multiple Ardan if we want to to synchronize the releases of a domestic integration. Imagine I'm not sure if we will follow this approach yet, but yeah, then probably it's better to just highlight an image and remove the check box. Okay,.

B

Yeah I agree: it's not needed right now.

E

Regarding that delete functionality in your design in the default Magento, the delete button is outside. Why exactly? Is it like move inside a menu.

B

So, just to I don't know just to make all the actions available on the image, contextual and available here instead of like in the bottom bar, because the button bar for me at least it's more related to the whole slide out panel and the experience of actually selecting an image and heading into the page. But I definitely would like to hear your feedback. Do you think we still need to pursue the top bar?

B

Because we're just you know we'll be adding more bottoms here whenever the image is selected, and you already see that there's quite a few bottoms here? What is.

E

What I was thinking was: maybe we could eliminate this contextual menu and on clicking that dot menu icon, the slider could open and you could have the delete button there or if it's an unlicensed image, you could have the license button here. Yeah in this slide out, so we can have a delete or license button here. Yes,.

B

Definitely makes sense, I was thinking about adding a slider panel here, I'm. Sorry, a button bar here with the actions that you can perform with the image. I will definitely consider that as well. But I really don't want this to be the only place you will do. This I still think that the this grid is a go-to place by default, but I agree with you. We definitely can duplicate them here, because it just makes sense right.

E

B

That's it, you can do stuff with it as well. Here yeah.

E

I thought: maybe you could just eliminate an extra click by moving those buttons here and removing that contextual menu and directly opening this slide out panel I mean yeah just a solution. Yep.

B

Good good point yeah, but I don't want you know. Primary action on the asset would be opening a slide-out panel, because, again, this model is about selecting an image, adding it to the to the stage or you know, to your editor, using the image as a as a content, rather than just viewing the details and that that's flow yep.

B

Thank you. Thank you.

B

The animal questions we're on time, I think.

A

Here just some time, thank you very much for a new mock-ups and presentation thanks everybody who participated and presented the pull request and just attended if there are any last last-minute things that you would like to bring up, you have the last chance to do it on this mitten.

A

Great, thank you guys have a nice evening night or morning and.

A

Happy contributions and see you next week, next Tuesday, bye, bye, thank.

B