Magento GraphQL Community, 25 Oct 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 25 October 2018

Description

Agenda:
-) GraphQl-39: Manage Shipping methods on Cart (@Yaroslav Rogoza)
-) GraphQl-45: Product textarea field format (@Vitalii Boiko)
-) GraphQl-45: Show only active categories (@nuzil)
-) GraphQL-41: [Query] My Account - My Orders (@matthew Matei Purcaru)
-) GraphQl-51: [Query] My Account - My Product Reviews (@Valentin Sandu)
-) GraphQl-216: Prototype for Test Framework Modularity (@Alex Paliarush)

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

So today, I will tell about managing shipping methods or shopping cart about this mutation, and then Vitaly will tell us about product exterior format. Also.

A

Alex several tell about a possibility to show on active categories and Matt a will to help out my account my orders functionality, cocoa graph, then Valentin will introduce my account, my product reviews and finally Alex polar colors will tell us about for the type of test framework modularity. So I'm going to start this meeting, so I've been working on them with the for setting shipping methods for ship and cargo during a few weeks and finally, I have some good results on this matter, so using the following mutation.

A

Currently, we are able to set a ship one of the predefined shipping methods for the shopping cart. So for this purpose, we need to ask to this mutation: shopping, cart, ID. We still we're still discussing at this point, because maybe it's a good idea to get this car to get from session, but it's discussion is progress, and so we we are passing ship, a method, called shipping carrier code and also address ID. By using this mutation we have. We also can request some data.

A

We need from shopping cart, for example, the addresses data, so I have introduced a separate resolver for this purpose, so this result can return different data from address such as name Jerusalem. So.

B

It looks like you forgot to start chain if you were something yeah.

A

Sorry sorry wrong idea.

A

Yeah, did you see my screen? Yes, yeah, so here's an invitation and, as I said, we should pass the shuttlecock ID. Then the shipping method code, the shipment carrier code- and we can request some data from the shopping cart here. So we can request name address fields we can put city here and by secreting this very, as you can see, we can. The mutation will return the information about. Currently it's at shipping method here, and also the description of this shipment method. For example,.

A

If I don't remember exactly the order, so what is the code? What is the shipping method yeah? So, as you can see, if I put some data that doesn't correspond any shipping matter to registered in the system, we will have the corresponding parent message, so we need to swap.

A

Yeah, as you can see, we have set a new shipping method here and we also have the corresponding description of this shipping matter. So I still proceed working on this pull request, because it's quite big and I need to finalize the shopping, cart, addresses, resolver and I. Believe I'll have some new updates in the next meeting. Thank you and I'll pass the word to Vitaly Tori. Please share your screen. Tell us about the textarea format.

C

Thank you yeah. Did you hear me yeah sure and because I facet miss about internet connection, so I was working on small tasks. It's named.

C

Emma graphical text fields to contain what does it means it means active and we have just drink. It's kind of a CML which we.

C

Should part and break into some other formats like Jason, so we need to phone out just out there. This extension point so I show you.

C

Like this, but I face it with some issues in my local environment, because after a functional test, I lost my products. Well now, so you see the errors, but it working with products. So we'll show you an Asian.

C

New type called complex text value this complex, like text value, was added to and because it will be reuse, it will be using not only this product, probably others other fields and.

C

Here graph kill him a.

C

Complex x-value is one hildesheimer and it can be extended in future in json whatever so and there's over of this HTML few, this it's for now it's doing nothing because initially it's HTML, but when we will add some, it will protest some logic, some specific logic. So any question.

C

D

B

I'm sorry guys I can also give a brief overview. Why we need this and the reason main reason is because our PWA may require JSON representation instead of HTML, because they want to build the page gradually and they want to have access to all kinds of fields in the object in the structured way, and that's why we need to have a way to extend it in the future.

B

So we you may notice a JSON implementation is not available at the moment, but what we did we just enabled future extension of the schema and now for description. We have just HTML or presentation, but officially we can add JSON or any other representations, so that that is actually the main reason why we have a.

A

Great thank you for the explanation. Thank you for a great presentation and our next presenter is Alex with possibility to show only active categories.

A

Exqueeze Bashir.

E

No I would say: may maybe some of you guys surprising why I'm showing this already I guess in a short time, because it's quite small feature and basically I'll share my screen. What was done during this during development on this issue journey? The issue was quite simple, so which I said to the returned. Only active categories for the category graphical call forget cat, forget categories, but we face the problem that current graph, chaotic implementation for categories is working wrongly with Charles. That was a developer.

E

Current developer branch I just made a screenshot because I were this speech to another one: don't wanna waste time now to recompile it and current category tree. This looks like this in magenta back-end, so I have three. Then you have those child's inside of Street and true and the same like extra levels. Deep and that's a current response of the get katika categories. Call.

E

If you have a look more deeply, you will see that we have here the first level categories here and then all childs are coming all this was to the last one and then child's again always coming to the last one. So this means journey that the tree is wrong, so we can build a menu out of it or category on on the PWA or somewhere else. If you wanna use it and then journey I would Janice says maybe beat another scope not in the same ticket but is already founded to return.

E

This development I decided to work on it, and here was a problem. I guess is if I will explain it, that generally limitation was done like it's get it all categories, swatted by level and then render and never level by level. This means that next level, it'll always could come to the most current or the previous level.

E

So that's why we have those those of you that the old child's agreement always to the last category and I change this implementation and currently Oh smashed it and currently the same call get in now like you, you can get this response back so and here you can see that it's it good, because for me, it's it's slow, maybe because of sharing, but that category for in the caves category has a child and all three one is child.

E

Three one one and then the same for the second and for the first one I just honestly like two minutes ago, see the comments from colleagues and yeah you're right there. We have some unit tests or not a unit test. We have some already test covering the categories, but I guess we don't have a test which taken particular this implementation is a child and I will extend them for those cases also and get some minor comments for the Naviance of the metrics yeah. That's all for now any questions.

C

A

Yep, thank you Alex and the next presenter is matei. They look to us about my orders very flossy orders from customer Iwate. Please share your screen and proceed.

F

Serious graphical in order to extract the api, the orders from my account- you know in my gentle, so here we have the so, let's start with.

F

The call from here.

F

This is how the query should look like I added, just those pills for for the moment. If they are more required, we cannot do easily on others for the moment this, so this module doesn't work because it depends on a foreign interface which is missing here but will come. The interface is created in the next pour request for the next presentation presentation.

F

So, for the moment this is built for the test will break so will not run. We also have a taste for an a/b functional test for this. For this query, which should be.

F

F

So the things too is just inserting a customer check for generates a notification key for that customer, and then we have some expected data which we want to be the same after the article. And then we have the episodes here.

F

I you all points, I can run the test, but I have to remove the the interface from the code. So, okay, here we have the schema.

F

So we have the type query with the customer orders that should be an array of of orders and, as I said, there is only those those fields here in that's kind of old things of any questions.

F

So there is no vision, everything is okay,.

A

Yeah, thank you looks great. It's really nice that to be a moving forward with my account Aquarius and our next presenter is Valentin. It's he worked on. The similar part is my product reviews from my account section, and it in please proceed with your presentation.

D

Okay, so is anyone able to hit me? Yes, just gonna start the screen.

D

Everyone is seeing my screen yeah, okay, so for this presentation we have customer productive views from from my account and after that, I will just continue with reviews from product page product listing, including widgets and so on.

D

Currently we have this query for the product customer productive use from my account, which pretty much we have these fields for now, but it should be changed because it gets kind of weird with the product review page. If we're going to use the same object to forum for both let's say functionalities so running this query will result. Result will have us result.

D

This data, as you can see here, on the right side of the screen I, have some reviews.

D

So they should be.

D

Okay, until we get this done, I'm just gonna continue it with the schema. So the schema looks like this. We have customer product reviews, query, that is an array of review objects and the review object looks like this. Currently, there is also an RP functional test, and that's also what mati was saying earlier. I have implemented this module that interface, that is required by by his modules, so pretty much. His parts is depending on what I've done here, so we won't have to duplicate code or something like that he's over.

D

In second I have something to make stuff here: okay,.

D

D

We have the customer product review resolver that extracts.

D

Customer reviews, the collection used here- is pretty much. This I mean pretty much is kind of the same that is used in is used in my accounts, but currently I'm, trying to find the solution to below have the same way to extract data from database that is going to be used in product review page as well, but I'm not sure yet how to do it.

D

So this is anything else.

D

It's a provider. No! This is pretty much it for this. For this implementation, I can show you the happy functional test as well. Give me a second, so we have got customer product reviews.

D

We also have the identification headers for the current customer, so we make sure it's extracting the right, the right data and then some expected data forum for the test. So we want only to.

D

To bring to show, in my account only the reviews that are assigned to the current logged in customer either if they are approved, not approved and so on, because the customer has to have a way of seeing his review status. So.

D

There should be no approved filter here if you're taking two into consideration with the product view page should only the active use. So this is it if we have any questions open for it,.

D

So I suppose doesn't know I think everything looks.

A

D

I do I do have a question but I'm not sure if I shouldn't discuss it now or later. Regarding the structure of the object.

B

We can discuss it after the meeting you can reach out are directed to me. This is Alex Collier, okay,.

A

Okay, thank you. So the next topic is closing in topic for this session and Alex will share a some information on really interesting topic: prototype for test framework modularity. Let's proceed.

B

Okay, so the initial idea of this task was just enable modularity and extensibility for graph QL and other volatile test, but in scope of investigation. Actually, we came to several interesting conclusions and ideas. I will just give very brief overview cuz.

B

This is pretty complex topic, but in general looks like we are going to have some unified testing framework, which will allow us to write MF, Jeff and Rob API tests like in in scope of like one scenario, say you write a scenario for test and check out with simple product, and then these scenarios will be executed using different adapters in graph QL rest. So maybe so one should also and say UI. It can also be executed as integration test with service contract adapters.

B

If you interested in details, you can go here and read this and we can discuss it, but overall looks like this is going to be a pretty significant effort and it's not just extracting existing graphical tests into modules somehow, because it is very difficult to make it a module without declarative, declarative configuration. So, if you're familiar with how MFT F works, this unified testing framework should be doing something. You know and we'll all substitution of some steps of scenario, extension of existing scenarios and also it should allow extensions basically by different modules.

B

So say you can extend Chicago scenario by check out agreements and, let's say gift message: module. If you don't have those modules installed. Steps related to those modules will just not be executed, and it will also enable third parties to run the core tests on their own installations, with a custom set of modules, because I believe currently in most cases is not possible because, as soon as you install some one which modifies existing scenario scenario becomes invalid and you cannot use contest and just to probably briefly explain what would be the benefit.

B

First of all, you can get away by extensibility unification of web api and fgf test, and potentially we can probably get rid of most of integration test and unit tests. We can also get input or request processing performance by using hood, says the fastest adapter, which is the integration or web api to test business logic, modifications in scope or request processing.

B

It also gives us flexibility in case if you know that we made changes in customer module, then the golden on all possible s4 customer module, only cost tests become modular, and it also allows us to save some time on not running all the tests. On other modules, just say: small business case scenarios on other models.

B

It is also proposing to start use and DB snapshots would say the sample data. Instead of creating fixtures, it is still possible to use the system code and then create one or two extra data items on top of the business shot, but it should be possible to just rely on the Beast and shot in most cases and in the indication we'll just take time on writing fixtures, and also we will save time when we run the test on our environment by not instantiating all those entities.

B

My follow me, let's say in your eye. We have to follow all the steps to create some entity, you'll be able to save the time, and we will also have ability to create unified, C, alright for all our tests and then from that Sarah you should be able to run tests for specific module would say, you want to say, run all kinds of tests for this module or you can run tests for using specific adapter for the whole instance.

B

If you want- and it also enables some futuristic stuff like test writing, wizard you'll- be able to suggest you what steps available after you have put a you are on product page. It will be able to suggest what what steps you can do next and in such way it can safeguard basically writer of the test from another scenario, and it's also name. It can potentially enable much easier and straightforward test writing.

B

This is possible when you have library of actions, basically those business actions and how these tests are different from additional same fgf and after, if you looked at them, they have say quick, feeble checksum field on on the page. So basically, those are very low-level tests and what's proposed here, is to have some high-level business case scenario test which will not have any details on implementation of specific you are adopted, so would say he will not specify in this test. What button you should click.

B

He will say, simple product to cart, said shipping address cell billion addresses like behavior-driven test, and basically you will be able to say, I want to execute these actions and then specific adapter you'll say how specific action will be executed in case of mobility I to be some way, they'll call in case of MFT F. We will just migrate existing steps which we have into this framework, and it should be straight forward and backward compatible for a mafia.

B

It's a lot of information, but this is general idea, and hopefully we will have somebody from MFG FTM to work on prototype zone.

B

Yeah, so probably that's it and again, if you're interested feel free to review this proposal in the ticket and reach out to me directly thanks a.

A

Thank you. That's interesting to see some results um and I'm just surprised that such great feature is developed within a scope of graph KL, because it's I believe it will be very useful for all Magento functionality. Yeah.

A

Okay, thank you guys, that's all for today. Thank you for sharing the progress for great presentations and see you next week. Thank you. Thanks.

B