Magento GraphQL Community, 1 Nov 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 1 November 2018

Description

Agenda:
-) General updates (@vnayda)
-) GraphQl-192: [CONCEPT] GraphQl shipping address coverage (@Vitalii Boiko)
-) GraphQL-202: [Mutations] adds sendEmailFriend Logic (@Tobias M)
-) GraphQl-51: [Query] My Account - My Product Reviews (@Valentin Sandu)

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

In my life go ahead, thank.

B

You so cold guys. We start our weekly craft will sync up a shared agenda.

B

And as usually pretty short from my side, mostly children, first week, we had contribution day at :. It was absolutely great a couple of date. Thank you guys and go Brenda for hosting and in scope of this contribution days. We workers on wish list on Santa my friend logic and some technical, some technical stuff, but today is holiday in : and most of guys off line, I see only two days here, so I view these guys join us next demo and demonstrates his pro request.

B

Also, during last week, we create a few another cool request was created. We created like eight configurable product to cart and manage store payment methods, but these requests steal under B and the next update from my site. Tomorrow we will help contribution day at Magento ki office. We expects about sixty contributors, so it's looks will be very very hot day and after this event, we do have focus on percentage of this pull request.

B

Because you see now we have a lot of requests under review and after tomorrow this count will be increase it and if you next week we will have big focus on logic and processing. All this pull request so I think that's all from my site and our next presenter is Vitaly buco. He will share updates related to graph QL shipping address coverage.

C

Thank You Valerie hi guys, so it hasn't been passed a lot of time science. We have a conversation about my topic last time, so I will briefly in general, remind what I'm trying to do so here we have mutations on what and I managed to implement such shivanand recent card intubation.

C

So under this notation we have such a dress song called input so and I change. One thing: science. Last time, I added a new input. It's a she undressed input. I did in order to.

C

Have a convenient way to figure out if we have single ship or multi shipment, because when we will pass.

C

Will be using into shipping float, so let's go back to the simmer.

C

Who do you contain customer address ID and address, but it is gonna be useful for flow.

C

C

That address method- and we will check if we have any of these- are inputs or inputs. If you have address ID or address input or also, we will check if we not define both of them, because we need to have one for one address.

C

To figure out if our this new or its address has been gotten from customer address book so but then there is no I would say some big changes, its way, mostly the same like in REST API. Let's show you a shipping way, so we should figure out if multi shipping use used motion can be used only for logging customer. So, first of all, we check it and then, for each address we will create, will create some array, specific structure which will be used by multi shipping model for sidings addresses.

C

Let's I show you more so here we will convert our input into a specific area and then we will process this in a magician model, but I have here. One question: is it's okay? If we I'm sorry, is this this multi shipping model working in this fashion, but as far as I know, we should avoid this. Is it okay.

D

Actually, we are not supposed to work recession so.

C

D

How we can avoid it.

C

Okay, okay and I have other one question: how can I move this output to some another place because I've tried to create new resolver.

C

New resolver here, but the system not I, can stop the buggers there. So I, don't know why there is some I know restriction or something like that.

C

Alex, can you hear.

D

Me trying to understand is.

C

It possible to pass it to some separate resolver for an hour in a box.

D

C

Would like to pass output, this output separate to another and.

C

Can can delete for now.

D

Yeah, you can do it, but you have to create a chain of resolvers, so it will say you cannot assign it is over on type like where exactly you're trying to and greatest resolver declare this over here for.

C

D

Yeah like on this fine.

C

D

On line, six is no, you cannot do that. You cannot.

C

D

Can do it only fulfills, and this was actually one of potential.

E

D

You can do it on fuel and.

C

D

To do it on like parent field as well, you have to have customers or grandparent field.

C

D

And why it's not possible on top, because you can reuse the same type potentially for different use cases and for different entities, and then there is no way know how to fetch data for that specific entity.

D

Okay, it's usually when you resolve specific entity, you know where to fetch its fields and that's why it makes sense to put this over on the field, but not on the type.

B

So you can create new resolver for addresses, for example,.

D

Yes, yes, you have to create basically like top-down. You have to create resolver for each field until you get to the future. You wish to like resolve like this car car, tidy or cart. I mean I'm, just not sure how exactly this field is used on top, but you need to have channels resolvers. You cannot just have our solder on top.

C

Okay, great clear so far- and this is it for now- yeah.

D

And if it doesn't work just be me and we can figure out how to do it. Okay,.

C

Thank you very much. Thank you for having me.

B

Silky and continue working this tomorrow on contribution day to you, so see you tomorrow, and we will try to make this okay next, our presenter is Tobias from Cole. Looks like this. Only one guy who.

B

F

Thank you, I'm actually working in Berlin and we don't have to public holiday. So we are all working the colleagues in Cohn they are not. So let me share my screen.

F

To tell me when you see it share it, no ok! So, as you mentioned, I was dealing with this sent email module in the front end. It looks like this you're on the product detail, page and, and you are just pressing, this email button yep and then you can recommend this product to a list of friends.

F

By filling out that form and I have implemented a simple resolver, who is doing the basic logic that the module was doing before and here's one to do left yeah? We need to clarify- and that makes sense to dispatch this event or not and yeah.

F

Basically, it does the same logic and the only thing that's missing was the testing and I can show you quickly how it looks like we have here different input fields and we need to specify which product ID it is. And yes, then, if we and that we should get some data back like so and then we should also see you know, dispatched.

F

Yeah, so there were two recipients and both received notice, standard email.

F

That's it! Basically, if you have any questions, yeah.

A

Can you can you clarify again what your question about the the event is, what kind of it is it? Is there a standard like send email event, or is it something more generic.

F

Yep, let's have a look so.

E

It should be this frontier.

A

Yeah, it's a send so actual friend. If so, it's a it's an event specific to sending this product to a friend right like specific to emailing this product yep looks like that yeah anyway, I think I think my recommendation would be to fire this event. If you know if this is called via graph, QL API, then I think it should be that you desired to.

F

You I create, but every because I think we wanted to talk about it because I'm not sure if it should be. If it's necessary or not. My suggestion was I think to fire it because we don't know if some business logic relies all right. We honored or not.

B

It is not clear. Question generally looks like we need to fire this event, because if somebody create extension and depends on this event, we also need to fire this event. Yeah.

A

We had we had issues with arrests previously, I we've had some experience where you know one when you have rest calls that do the same thing as somebody. You know an admin pressing a button in the in the UI in the widgets admin panel. Then, basically, the expectation is for the system to behave in the exact same way as when you do something via the UI. So in this case this should be equivalent to someone filling out the form and pressing the send button to share with a friend. So if.

F

G

Page reviews I mean, and we have here the time I mean the time, the query, reviews and a mutation for creating product abuse.

G

So basically, I'm just gonna go with the main idea is because I had the phone with with Alex this this week and we kinda into I mean I kinda need to refactor everything as it needs to have a bit more sense, running the implementation. So here on the product, if you square e, we have an entity, ID actually would be product ID and then imagination, and we also need to have a sort order faith.

G

Then the product review will return okay for that review. So what is the result? Okay, that is almond, is type of lead use which is located.

D

G

So the the main issue with with this and this implementation correctly, is because of this. This method here, that is, that has different implementation on the review, collection and product review collection and I, probably have to even create a new method in one of the collections or other one of them. So they have the same logic, because currently it kind of it doesn't really help me so going further.

G

We have, and it will return an array of reviews, reviews which contain a new idea at the ID which was signed customer ID. This would be dropped, title details, nickname dates that was created in the ratings that are assigned the review, and then the ratings are described by rating objects. That will contain the rating name, the percentage of the votes and they actually finally removed about that is.

G

Described by values from one to five and the percent is values from twenty. Twenty-One an equal zero to 100, not to 20 to 100, with the 20 step.

G

Okay for fun, for this we have another page, were returning only only approved reduced and sorted by default, created dates or descending.

G

G

And then we can, we can have a look at the reaction implementation, so we have. This is the this this. What we have here in the right panel is is the query. So I am Mike wearing any ID, with fidelity. Six and I got two votes, and just for an example on chance and a runway mutation as well and create a new video.

G

Okay, so I have I, have another review with ratings and sign things. Basically, the mutation returns an object of type video, so I have.

G

An overview, what's on what I have said, the same also I think I need to put some other values in here, but I'll talk about it with which one of you guys, if I, have any questions. So, let's see.

A

Hey for the technical people on call should we should we be using ID in this case to filter products, or should we be using something like skewed, it's worn so.

G

I'm going to change it to a sk use, we're basically from what I a likes were dropping anything that has IDs, then we're replacing it with sk use and some other value that it can be used to extract data here for ratings, for example, we're not gonna use rating ID when I use the rating name that is defined by the admin and then based on the rating name. We're gonna obtain the rating ID and here for option.

G

Id were gonna, pass the value 1 to 5 and based on the rating ID, and the value would not obtain the option. I did this. Come is gonna, be in the background, so the customer can no can input. I mean not the customer. The developer can input only values that he knows off doesn't have to query the database obtainable. Give you or something like that.

G

Ok, great, that's pretty much the logic. The logic here as I said I might need to change.

G

Add some some data or methods in a number of the review module. But when I get to that, I will ask someone if it's okay, where we do it some some other I in some other way.

G

Yeah session, it's bad yeah. This is pretty much it if you have any other questions, I'm open for it and also another another thing. Important thing: sorry I will drop the full request for, for.

C

Customer product reviews and I will continue only.

G

One for requests, because it's kind of a pain to go back or back and forth to contain both of them. If that's okay with you.

D

Yeah, that's fine, don't give me thank you for watching this I supposed to have great. If and just a reminder for everybody.

D

So now we are creating brand new graph kill api's, and we should try to focus on the experience first and don't look at existing implementation and we should create interface, which makes sense not necessarily look at how it is done right now, because current implementation would always make sense. Okay,.

G

D

Also, we should try to avoid usage of actual database IDs on storefront as much as possible.

A

Yeah another one more question: actually that has so with this implementation, and maybe I missed this. But do we add a rating field to the product object as well as part of this ranking? What a field that contains a product's rating like if I.

G

Understood the question: well, I haven't thought about that. What can be done? Just I mean for the listening part. It should be done, but what I'm listening and widgets, because.

G

I mean I, have the product in the basics and the rating data and I just don't know I just.

C

Put some minimal data there and.

G

If the developer.

F

G

Have more data from the database? It's up to him. It's usually a bad idea to bring too much information or listing page yeah.

A

I agree totally agree, but yeah. It would be good to extend product with this rating information, because I I know that those are some of the few fields that we were missing currently on to render like a full page.

G

A

Would keep the same names I think what you had in what you had in the schema was what's good enough: okay, okay, but if you, if you have a question, just hit me up on slide, we can talk sure cool. Thank you. Well,.

G

So this is this: is it for my part, thank you. Thank.

B

You van engine, what so grace looks like it's all for today, so thank you for your contributions. Thank you for your great presentation, and maybe somebody else have some updates.

H

No okay, so guys see you next week, good work, everybody thank you. Bye.