Magento GraphQL Community, 9 Aug 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 9 August 2018

Description

Agenda:
1) Render Categories Descriptive Directives https://github.com/magento/graphql-ce/pull/148 (by @Yaroslav Rogoza, presented by Alex Paliarush)
2) Categories Endpoint (by @Umar Chaudhry)
3) Checkout Schema (by @Alex Paliarush)

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

Thank You Misha second story will be about categories endpoint, Marvel presented I, don't see him during the year, but hopefully huge Universal and the last one contains on the costume architecture of check out and she called chemo for grouchy. It will be presented back so now Alex. You can go ahead with the first item.

B

Hi guys so this pool request was prepared by years law and it is covering noticing of directives. In Category description, we had similar tasks presented by our staff last week, I implemented directly processing, full product short description and product description, and this time he did four categories and I can just show you what exactly wasn't formal here. So we have new rules over like four categories: tml attributes.

B

For now there is just one attribute, but potentially it can be reused for other tributes, and what this has over does is like fetches, the category model, then through name which is going to be resolved and processes. This will value using output helper that you already have in court and after that we declare this is over in category schema.

B

So you can see that this is category interface and in description for the category interface and there's lots declared customers over so means that all fields for category will be resolved by category resolved, but description will have customers over which will also process HTML directive.

B

And basically that serious levels are covered, the changes is why we've got graph QL functional test, and here we create category. We create something. We had some directive to the category description and after that, like here we add this directive and after that we perform graphical query and we interested in description specifically in this task and after that we assert that basically directive was processed so that they don't have media URL like which was part of the execution.

B

So they show that there is no media URL in description anymore and we make sure that base URL is part of the description.

B

So that's how you can write the functional test for graph gel and also there are some limitations like known limitations and our architect for base builder right now is discussing this users love in comments, but basically not all. Directives are processed for category attributes right now and the rest love gives an example that a block directive business process right now- and this is limitation of current filter in the core. And after this, after the discussion is done, we will probably have some resolution.

B

We will either accept this limitation for now or we will have to modify existing filter. So any questions for this one.

A

C

A

Comment from my side, this is very good. Code. Change is covered with unit tests and a bunch of them it's a functional. So this is very important direction for us to have to request color to test, and we have special label test coverage, so it should apply to the school request as well. It indicates that the spore quest you smoke oil just for coloring. The changes needed a.

A

Little bit on you or morning.

B

So if you know other questions for this, one and I give screen back to each in and hopefully tomorrow and.

A

So I don't know, mark okay, he is joined, so you wanted to discuss the end points for the categories and if you can share a screen and talk about that, okay.

B

More muted so far.

D

D

Can you hear me yep all right, I'm, sorry for that delay, my task was to create an end point for the categories. I will just share my screen with you guys so I can show the work I have done so far can see my screen yep, alright,.

D

So this is the new end point which I just created and.

E

D

D

It is something similar to product and it contains two different like filters. One is search and the other one is filters.

D

I haven't read it yet about the search filter. It is similar to the product search and in the result, you can see different things like items name description and in case of what you can just place in the filters. I have short description and I'll just show it to you.

D

This is the graph close here is 10 point I, have you search, filter, page size and front page? These two all already have the default value, 20 and one in the same way we are using for products, end point and in case of search, we are just inputting. The string in case of filter I have to find a new time, and it is here up till now, I have included these things name description. These two is the anchor level and always for using like multiple category filter inputs.

D

So I will just show you how I am inventing it so.

D

This is the resolver class. You think it is exactly in the same hierarchy as we have the product here resolver, and this is the category trees to the overclass right so here which, since we already have the categories, so I am not using that this is being used in product products. I think so someone mentioned in in the comments that it is already being used. So I have like made the plural of category tree in the category.

D

Please I am building a search criteria for being used like filters and Peggy nation and sorting know when now, if both of them are here in the same way, we are using for products either, we need to must input the search field or the filter field. So if in case of search field, I will just show it to you in later on, I will try to focus on this one in case of filter query.

D

What I do is I go to this and from this this category data provider, I, am getting the list of categories by giving it search criteria, fields- and this is an additional research I, don't think so. We need to use it right now, so I'm not doing anything with this, so in case of get list, what I am doing is I am making a collection of category, and this collection is being processed in this election process, and so I have defined this in two different classes.

D

This is the composite class processors, and it in basic has in this same interface, has two more classes. One is attribute processor and other research criteria attribute processor dislikes. The attribute which we have just defined in the query. In the same way, search criteria is using the default search criteria, interface of sorry class of Magento, which is already there like this one, so I'll be using this. So for now my filters are not being like worked so I'll just show you.

D

With using the.

D

Default delay no.

D

Yeah, so it's here, this prints the search criteria. We just use the category name here you get name, and this is representing to the category end point. Reading these end points, and here we are studying the grant page in the salt criteria and in the same way page size. It is 20 by default and now I will go to this layer.

D

This is like getting the result of all the matched categories.

D

And in the item verse and just looping over the all the items and so using saving them in the array.

D

Here we need to apply the filter.

D

Let's just bypass this one, alright, so I want to show about the filter and I'm facing some issues in that one as well. So basically I'll just go through that.

D

So if we go to di cottan tomorrow, you can see this is the search criteria. Plier I have just seen that someone has used its spiritual types for directions, processing and if, if I go here in the catalog.

D

So, are you guys with me.

D

Alright, so so this is the virtual type used, and here here what we do is we like redefine this type, to use this model, a bi search criteria. So what I was missing is I was I, am not having any collection processor for categories, so I think we need to create an in in the catalogs modules and then, in that case we are going to use the default Magento filters right now it is using it.

D

Right now it is using it is using the product filter processor from the API framework, /ap glass. So what we need to do is we need to implement the category collection processor for in the catalog module, or if you have something better, then you can suggest me that answer I just need to use this product like like this I I, just need to use this collaboration processor right now. It is not using this once.

A

You are injecting a new processor instead of that one sorry, your goal is to inject a different processor, fluid collection or.

D

A

D

My goal is to create a new virtual type like like someone has defined here. I can search criteria of Meyer, someone has defined this collection processor, and this is just a virtual type in the catalog module at this place and they have injected the filters from this class. So I think we need to create a new new filter class for the category as well. So we need. We need to redefine something in this di dot XML. So is it something within the scope or should I? Do it in the catalog graph, QL module.

A

Yeah from you think, written question is really worse: introduction of new processor over the reefs in the fourth one in the category collection already, but it would please, then, probably worth doing this.

D

D

Because it is not available right now in case of category collection, so this is the use case, because we we don't have this thing yet because the existing end point was this one and we were able to only define the category field. Sorry I defeat.

E

D

We can just define that Friday and it gives you the list, so it gives you the category. Pre-Ind results.

D

So, if, if, if I can just like I.

A

Sure I would I would suggest you to put those code somewhere so that we can start working on that review, because I seem here couple questions the best way to see you through the collection and either a default filter in the core already actually.

B

If you can create wealth and markets and how in progress, then we can continue discussion in our quest and we can discuss any questions that you have as well there. It is.

D

I think that would be better than okay.

A

D

A

Presentation and thanks for working on that yeah.

B

Actually I would like to mention also that probably we don't into introduced categories is over all three categories: three resolver and instead I was just to move categories resolvers on the product, because it is used some products and one and then just create categories as, although not category three, what category and also category three resolver becomes irrelevant. If you do this changes, because category till is over is currently used for and point that Xian modified, alright, so indeed, actually I was expecting to to modify distant. One not introduced new one.

B

So I see that you still keep category resolver, but we probably need to remove that one category three women and replace it with this categories. One changes, so we can delete it or we can start all this in comments for all of us, like if you're grateful, but.

D

All right, I'll make a full request by the way I am I, am just naming it category 3 and because my end goal is to return the list of categories. So that's why I use this one. So we.

B

Can talk about name in in okay, okay, perfect and.

A

Just in general, it's a good idea to always create pull requests early so that you have some prototypes. We can iterate through the prototype and usual, see the feedback earlier that the poor can playing deep into implementation before we get thirsty, especially.

B

On the task, vision of completely clear and larger ones like this one yeah.

D

Perfect so I'll just finish my my work like working on the filters and then we can refactor the code later on.

D

So that was not seen from my side or drain.

A

Thank you. So that's it about Katie Greenpoint, the.

E

A

On our agenda is checkout, chemo and Alex would present like next step is defining that.

B

Okay, so, basically, during this print, I continue to my work on defining schema, for she calls for different aspects of code and just a reminder when we are just opening a store. But as a reminder, we have already covered on previous mission. Add items to card scheme on so I do not probably go through that again, but I will cover what was what is new in like after out Brisbane.

B

I would like to mention that we have a decision on a synchronous, server-side mutations, and the decision currently is that we are not introducing them at the moment, because it is non-standard waiting for graph kill and it may be difficult for clients, because client libraries are not supporting this and you might have to implement some custom logic if you want to basically implement integration with asynchronous endpoints and for some specific merchants which need this because of high road or for some other reasons, it is possible that we introduce it later on framework level like we did for us.

B

So when you have I can just how is done in rest, and we can think about like how to do it. In similar way for gram, gel and rest is basically special layer on the waveguide in Roatan module, which exposes most of mutation operations like post and delete and boot.

B

So it's oldest those operations as a synchronous, so in generate custom schema for them, because, obviously, response type changes for decoration like instead of getting regular, would say when you create a product instead of getting product record in response in revenue instrument, stress you're, getting operation ID, and then you can use that idea to get that show response when the request is processed a synchronously using that efficient. So similar approach can be used here. So for now we defer this and we assume that majority of the clients we won't need a synchronous server-side at once.

B

So this is one one decision which we made abilities to this mission.

B

Also, I posted a link to proposal in our graph skills like channel, and the proposal is basically introduce rockers for all inputs and for all arguments and for all our code types- and this is like the main reason for this is because we cannot extend list of arguments from third party extension and the schema stitching mechanism doesn't merge them like it does types and input types and all algorithm in arms and for output.

B

There is like some issue like if you just specify output is a string here like in this, in this example, generate custom token and then example, argument email password and in response you we are supposed to get a string. So if you do that, there is no way for extensions of our extension for even us to expand the schema or modify the schema of out, and basically this is like another issue with extensibility to sell right now, so we propose to create proper slavery, simple type yeah, so we will go like next and ship.

B

So basically, there is also no way to typically to great to introduce breaking changes and the reason is we cannot just duplicate. Some there is no way to duplicate like this argument and change it for some stuff and same for after this output path and same for argument.

B

So the solution is to create wrappers for all outputs and inputs, and in this case it will look like this say.

B

Instead of just saying, output type is drink, you say, output type is operation, name, plus output, socket and then inside you have select open and for input. It will be the same so input you, one argument called input and the type will be operation like really a mutation name plus input, and you list all arguments excuse here. So in this case you can duplicate, extend and customized list of arguments and output, as you would any other type, and we already support accessibility for types and inputs.

B

So an example would be like for this specific. This is obviously a great example, but to let's say you want to introduce additional.

B

Like multi-factor authentication token, in addition to email and password and in in our original implementation, it is not possible with grubbers. You just declare this new field. It is eventually merged to the original type.

B

And then you have two three: some customers over or you can create plugins if you want, but for this field again to create resolve a problem and for output would say you want now to say to notify client about time to leave for the talking and again in the region, implementation when, if you have just drink as output type, that's not possible, but if you create rather in at once, it will be possible to expand schema and this PTO will be generated by again plugin or custom resolver.

B

So there is also one open question.

B

So basically, we have difficulty with types with introducing wrapper types for operations who don't have arguments at the moment, and the reason is because graph QL does not support empty path, so you cannot declare empty type without any fuels just to future extensibility process and so far I don't know how to go in process. So we can do this for all output tiles, because all our queries, invitations are synchronous and that's why there is output type anyway, but some operations.

B

So if you don't accept any arguments at the moment- and it might be a problem, so if you have any ideas for that you're welcome and after we resolve like this open question here, I actually items which I propose. So basically, we need to go and change, email for all existing queries and mutations and by the way for queries, the wrapper type name will probably include subjects like query input.

B

So if you have product query products, query we don't want to have input to the code like products in put all the stage you have card query. We don't want it to be card input because it may be confusion for other corporations. If you kill mutations, then it may be confusion and that's why I believe it's but I haven't mentioned it in the proposal, but I just thought about it yesterday. So it's probably make sense, though, for queries have statics like clearly in it.

B

Until we like card query input, and if you have scars mutation, it will be just say, card input.

B

So the action item is to go and modify schema for all these inquiries and mutations, and also the command is somewhere and make sure that for all new contributions you follow this. So it should all be significant amount of work, but still we need to agree on this first and then, if you agree, then somebody will have to go on my schema. It should be more or less like trigger trivial, minification. Well,.

A

B

A

So, regarding agreement, how do you propose to get feedback and volts.

B

First, so, first of all, this is currently open for discussion and it is part of Magento architecture depository, which is our new repository public repository for discussing any architectural proposals, and you can find this pull request. It's called like initial draft for buy and basically I referenced it in our graph. Just a channel as well so feel free to to go here and comment, and actually we already have quite a good discussion here.

B

So we have quite a good discussion like on different items and phenomena have just single proposal for all she calculated schema pieces like for adding products to card, and then basically all she cultivated schema is supposed to be in this proposal and I believe like if you guys are interested. If you have some understanding and maybe experience with working for Denise Karthik guys, please join and give you feedback.

B

So as soon as we discuss it here, we can run both for somewhat controversial items separately, but so far I haven't received any any feedback. Regarding, like the specific yeah.

A

I was suggested to put those questions and leave the proposal and description on how to participate, to repeal slack so that we can part with Tizen that asked for it.

B

Also, actually, as soon as I create would say, one section of the document: I posted a link to graphical chancel and I've, been planning to continue doing that. So since, if you like some meaningful piece ready for discussion, then I posted separately, because obviously you can go and try to review like the whole document or the hope with that. But it make sense to review it even in pieces and that's why I post a second piece cool.

A

And you guys also can join a contextual discussion that happens, I think once per two weeks on Mondays and the next one will be next Wednesday.

B

A

B

Like it, if you have any questions regarding this specific parts like input/output rockers,.

B

Okay, so hopefully you guys can hear us. So if no questions then I will move on to the next one. But you are welcome to go and read through it and give you feedback, and especially, if you have any ideas for these open questions, this would be extremely valuable if participate.

B

So then I have also couple pieces for card.

B

One complex piece is ready to cut prices and the main challenge is how to be organized our scheme of prices in the way that you get all data that you might need in all possible scenarios in check out like extortion, checkout, but at the same time we don't want to expose any sensitive data here and so far.

B

We are going to include basically this like prices field into card itself, and if you have price is relevant for the whole order for the whole art it can have food say all taxes applied to the cart it can have, hmm let's say, totals for the whole cart. Discount applies for the whole cart.

B

Then we have another level of granularity, for, like cart, actually might be like a dress is the next level, and this one has all the information about shootin like shipping price and why it is separated from the cart, because we have multi shooting functionality, and it's why you, you might potentially have different items in the cart to be shipped like in two different addresses and different taxes can be applied. Obviously, two different shipping addresses, and yes, so basically, this is why, like you, have the separation, so you can get prices relevant to shipping, for example.

B

As soon as you have a dress, if you don't have a dress set yet, then you will not be able to get them and they aren't available as part of the card price in behind and.

B

Basically, these prices are similar, but we will look at them later, but they're still a little bit of difference with them and the next level is called items will say. If you want to display some prices for line item I talked item, then you can get some prices for item as well, and it may be useful to understand would say how taxes or discounts will split different items. I would say if you have a part price rule which is applied for the whole card.

B

You need to also understand how this affected like specific line item, and you might display this- you might not in default blue machine. Such information is not displayed. Usually you get just the product price over there. You can get it like, including dogs, swing, docks depending on store preferences, and you also get line item price. Basically, this is product price, x, quantity of items.

B

So now let's look at this interface, which is generic for all of these three different prices, and this one has so far. So this is like working but like working draft. So if you have any suggestions, please please again give you feedback, but you have like card price enterprise prices interface, and you should be able to see total for the card for specific address that you ship into or for an item, and some should able to see like subtotals suppose with discounts. You can see, applied taxes and apply discounts.

B

Then you have basically card prices. Do not add any extra information about prices so on calculator. This is well what this is all what you get on address level. You get additional information about shipping prices, shipping discounts and one called item. You get product price information which is not available on other levels and you can also get custom price and probably you can also get tier price, but it is comfortable initially if you need to displayed and then we also have contacts item which is just amount and label so basically what it means.

B

If you want, for example, to show a slight axis for the car, you will get an array of these contacts items and you will be able to iterate three turns and say: I would say we talks, which is like recycling talks in European Union. You can do flavor like specific. We talks because there could be different.

B

We taxes and they put multiple for specific item and you just say what is mounted at talks or you just say just regular sales talks and you give labels of talks and you give them on for the top I'm sorry.

B

So this was about box, but for discount city the same you can just list all these counts, which were applied say for specific item in the cart, and this can include cars, level discounts and this can include specific item discounts and it can be like coupon based or it can be, just buy items for $200 and get like 10% discount. So it can be just cut right through based on specific conditions, not related to coupons, and all of them should be displayed here.

B

So any questions so far for this one.

B

Guys can you still here's.

A

B

So then, like again, you are welcome to participate in the discussion, because this is pretty complex one and would the I do if we get some feedback and I believe I have not seen anything for this yet so the next one is again. This is initial draft. It is not complete yet, but at least function is already alpha here. So this is what we get to cart interface apart from items and prices and coupons, so we basically can have like our query and again we will have that special input.

B

So I already use this wrapper proposal here. So basically we have community. That name is called clear input and then we have output. So basically you to provide cart ID as an input, and it is required for both guests and customers for customer. It may seem to be redundant because you can potentially organically get card ID from from your authentication token.

B

But again this is discussable. If you guys feel that we don't need to have it here or make it optional. So another option was to make this one optional and basically, if you are, if you can get this card ID from your authentication token, then we say: ok find work and would say if you send guests requests.

B

Obviously don't have authentication token. We don't know who you are. We cannot identify your cart ready in this case you will just throw exception, saying hey, we can't identify your car PD. Please provided explicitly. So these are like two auctions so far with this one is better because it is more straightforward for guests and for customers. You are supposed to have your cart ID anyway, after you create your cart and I.

B

Believe shouldn't be a problem to inject it here, programmatically with each request for card query or for any other place and by the way why it is optional for customers, because customer might have only one active current at the time. So if you say create a new cart, your old cart is abundant and I. Don't think you can even access it from store fun. It is tuned somewhere in database, but it is not accessible.

B

So the proposal for cart is to have like, in response to have called ie a list of addresses, also line items, count which is number of line items and then fact second quantity for items. This one would say if you have two items of same kind and then second item just one one quantity, so you will have two line items, but total quantity of all items in the cart will be like three and it is also flow because in Magento for specific products you can enable decimal quantity and that's why this rule is flawed.

B

And this one is just number of Finance and try. It's integer.

B

Also we selected payment method and started shipping method. So I cannot edit it here, but we inserted shipping method as well, and so after shipping method will be just like code and label so far, I, don't I, don't think we know, but any ideas are welcome and for selected payment, nozzles explain like master code and label which you can display for side, business.

B

So keep it in solids also treat amenities already here, so it goes, should keep in mind. It is relevant for addresses, because you might have this much.

C

Hi Alex, sir friend, interrupting you how in growth, gills planet, two together at least as possible shipping options and payment methods.

E

C

Kevin's includes a moon card.

B

You mean to provide little available options, yes, okay, so now it was supposed to be separate query, but yeah I will definitely think about this. It just.

C

Just from our experiences payment request, API, those well is like available payment methods and available shipping options, options related to some car details like addresses and so on. So.

C

They depend from other Wallace on cart, so it probably makes sense to have the whole list of available options and selected some of them with selected boolean. So it's like like additional one of the options, but probably the additional PM as a master datatype would be also a possible solution. Okay,.

B

Yeah thanks I'll feel bad good proposal and if you don't mind, could you please just leave a comment on the architectural quest, so we can just consider me.

C

B

Good point: it can save basically some extra requests or in case of gravity or you can combine requests, but it may be just more convenient to provide this information, as part of would say address, because from how the plan was to provide this rotation, she didn't mention estimator. We should request you to provide the whole address, but if you already have addressed as part of quote or card, you already have this information I believe it may be just easier for integrator I, believe ordinary-sized.

B

Okay, so there's no other questions for this item, and there is one more is for cards at the business events, cottages and the proposals could have applying open to card and remove coupon from card in Magento. You can have only one coupon applied to a card at a time. So that's why, like coupon code, is just a string and it's not like an array, for example in response requires like here like a flight coupon and it's just a string, and this one is pretty simple, so you can either say here is my coupon?

B

Please apply it or you can say like okay, so or you can say, I, don't want any coupons to be applied to my card anymore, so just remove applied coupon from this red card and in response for both cases you get cart, cart, object and if you need to you can get some seal. Some card objects yeah. So this is additive.

B

So any any questions for this one.

B

Okay, so I believe that's it from my side and again feel free to participate in the discussions. If you have any feedback leave it in in full request on github and current plan is that I will work on additional qualification and adding new items for the schema. So basically, the goal is to get schema.

E

B

Chicago finalized and then you basically not just but also, and then they will be able to create all coverage tasks like for mutations in queries for cards. We already have some of them by the way. Maybe I'll give you update on this, because we moved a bunch of tasks to ready to start and you should be able to pick them up so on previous admission, I believe we had around like five issues ready to start, but right now we have a bunch of them and I believe still have some time.

B

You can rotate any other items if lower than water. So then I will probably just go over all the items that we have like briefly and just visibility. So if anybody is interested in a specific one, then you guys can work on them.

B

So this one is for coverage for eighteen, continual products to card it is based on schema, which we have all discussed on previous and to its mission.

B

This one is for like agent, one dog items and just just okay. This is part of the scheme, as we have already discussed, and those mutations are supposed to be based on and all schemas, even though they are not completely approved yet I believe we still have quite pretty good and dependent on the main points to take away, spleen and points.

B

There might still be some modifications to the fields, but in general this key must not change much. Then there is task for it in the notable products groups, products will show product.

B

Then there is open like feature class / box because, like some people expected to do working already, but we don't have variables for the complex variable support, you can use simple variables like simple types and variables, but if you try to use complex variables in complex types in variables, the framework gives some error and basically just work. So if somebody needs is functionality feel free to contribute, then coupon operations based on schema, which I just showed you.

B

It should be again pretty trivial task, because we just need to declare new graphical schema, create a new resolver and resolver is supposed to invoke the distant service contract. So all this logic is project service, contract.

B

So when the constants for category I believe this is the one which is is working on provisioning, so progress.

B

We'll check it later and then, let's general documentation. This is just to go to our deduction document, our graph key testing framework. So if somebody is interested feel free, this one is for configuring, our graphical test from Travis, and this would be useful because you guys work on this, like property, pull request and graph kill, test, I, believe and currently excuses and Travis, and it means that you cannot get instant feedback for for your work and how it works right.

B

Now, like we start, except in the pull request, and we run all kinds of tests that we have internally on our infrastructure and couldn't graph kill that, but since like this is graphical project, it'll be perfect. If contributors can get quick feedback on the changes, a little.

B

This one is about a race like if you have partial response, and you have fifteen now.

B

So if you have now in in response, you can still do that, but, like it's it's part of the race, so you can see that you have like array of items in response and one item was successfully retrieved and second item was not received, and this is confusion like we should not have no value and we also need to add error message of environmental she's already added, but I personally have no value here, because when you just compliance, I'd try to iterate over this array. This confusion for you that you are getting discount.

B

This one is for Change Password mutation actually described here, but it should be similar to what we already have in our rested time. So not much to discuss here.

B

This one is about which was supported like a vehicle, and this one is about displaying active categories only so right now we display all categories, even though they're disabled that say here.

B

Got it from our previous.

B

Category three enabled handled fragment, so this might be some bug in one of those overs and by the way, these bugs are pretty difficult to spot immediately, because graph QL is extremely flexible and you can specify all kinds of variations for your queries and as soon as you not test specific variations, it's possible that there will be like non-working clearing, especially now, because you don't have like real ones and obviously don't have a feedback. So as soon as somebody starting to use our queries, people start finding like issues and yeah. This is one of those.

B

So it's like specific use case when you try to use fragments on category three, it doesn't work. I believe it make sense to postpone this one a little bit or do it. Maybe after Mars done is he talk, because it is for the same API.

A

And the minutes left so guys it seems people today. Oh all, your questions are welcome in the chat and let's meet next week. I hope you'll get more updates about our progress and yeah, as I said already back from vacation, so feel free to kill him about questions, how to implement different stuff and the status of the champion, and he left thanks. Bye.