Magento GraphQL Community, 16 Aug 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 16 August 2018

Description

Agenda:
1) Allow changing logged in customers password with Graphql mutation #150 (@austris-argalis, @vnayda)
2) Customer Edit functionality and Customer Subscriptions management mutations #56 #55 (@nuzil)
3) Resolver output type proposal (@Alex Paliarush)

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

It's time for vacation Oh guys we can start our weekly miss graph, killed, sim, Cup and I share today's agenda.

A

First, our ticket, it's about possibility to change customer password via mutation via graph QL, corresponding to request, was provided bust-out easily make cannot visibility join us today and I will demonstrate this functionality.

A

So, first of all, I have some recognition. I have already created user and first of all, request for gauging customer token.

A

And need to put this token in header.

A

And our body, you can see that my current path of the graph QL I changed this bastard on some wrong password and perform request. We can see correspondingly errors. The parcel does not match. This account need to verify password I teach as for improper and provides some applicable new password.

A

You see the corresponding perils that we need to have some rules related to our new password and, for example, I, create a change on proper Hospital, but after a laptop top global deal, we can see that we don't have any roles and password was changed and, for example, trying to change via version.

A

Yes, we change password again.

A

Yes, I, since it's all related to this ticket and more details, subsequently exception criteria so on you can find our github issues ikut and send kiddo ostrich contribution and next update from my site. You can see that we have some cubed requests and our first goal spacing and margin a lot of requests. We shall open now, so it will be our main goal related to the next week, especially if we have a lot of guys who now on vacation. Thank you.

A

That's all from my site related to this ticket and next our president Alexander is topic. Customer added functionality and customer subscriptions yep.

B

Thank you, yeah. It's also shown on the screen, as I already presented like two weeks ago, I started with a customer update mutation calls so customer when we can update we as a graph to the customer information.

B

It wasn't a ticket with the first name last name an email, an email can be updated with the password together and also there was a ticket number, 50 or I guess find it now, but we was related to subscription customer to a newsletter which is quite similar and can be done within one call: yeah that's journey with a part. What I showed last time?

B

First of all, even before I will start. This I just show the previous presentation, and there was the call which called chage cust, no chage customer password, I, guess right.

B

And now I'm thinking about what about the bags that we defined general names? Let's say if you customer update to changing so mine, my code is customer, updated I, know if it's good or not I want to have some feedback from you guys and if we have change customer password, maybe we have to change it like customer change, password that we have all started, at least with the same products. What do you think.

C

So actually, there are two main approaches which we can follow. First known as prefix was a customer update, customer password change, and in this case it will be easier to sort in schema and it will be visually just easier to see all the relations to customer. The other way is to start from.

C

Well you say change, customer, password, etc, and in this case, like you get operations grouped by the intent, but I don't think there is like right solution it we just we are doing it in the same way and that we are aligned when we name our operations. Yeah.

D

My preference would be hmm so are the two approaches: I think my preference would be to start with the noun so start with the entity that you're that you're, changing or updating or modifying so I think I. Think customer update is good and then, consequently to be consistent, we can change. You know the password endpoint to be what customer password update or customer password change, depending on whether it can be used to create a password, but if you're changing it I think a customer update, I'm, sorry customer password update sounds good to me.

D

I, don't know if anybody yeah.

C

I'm also fine with it smells good yeah just need to make sure that all operations really specifics so.

D

For yeah for all the product mutations we will make sure to have product well, product update should be just the generic. Oh.

D

Yeah, that's right! So, yes,.

C

D

Basically start with the entity that you're modifying yeah, so card card update, maybe like cart, shipping address, update.

C

I know I to be honest, like I suppose we should probably do some both it's not like really important, but it's more I suppose matter of preference and we just need to make sure it's real liner, yeah I agree. I mean we can make a vote in in slay, okay,.

B

Let's do that cool okay, then I'll proceed yeah general. There is a short last time there was a small prototype now I like made it more completed so first, my last name, I showed already so edit is subscribed field, which is that exactly the same as I get a graphical query, and yes, it's a certain boo. So that's currently that's my account and refresh it.

B

Yep I'm not subscribed currently and if I will send it like this, so I try to subscribe. Oh it's! The biker is enable sorry. It will take some time.

B

Then, after execution, yep I'm subscribed to the email, also added some check there in implementation that if you're, let's saying this call, if you already subscribed, it will not trigger the subscription again. So it will check if the customer was already subscribed. So for did not pausing sources too much and the same for the false and yeah and in addition so I have here the email changes. Let's say: I have an email, food, I'm attracted.

B

Good, so I have an email here.

B

Which is currently my email address and it will not do anything here, but if I'll try to change it.

B

Generally, I will get an exception that.

B

Does Bigpoint already mentioned I need an error message here, for the password field is required and Jennifer could hear the password field which it's gonna, make it like. This yep then I'm getting exemption invalid, login or password, so especially with the wrong one. Here was also the question to the community more about the exceptions here. So I can give you the default exception, which we have in a graphical model. This authorization exception currently being used for authorize the customers itself.

B

So, with a bureau talking and only just was good advice should we provides it to create a new exception for such kind of like look for customer actions like login and password when you make any mutations or it's fine to use in the current one.

C

So is this exception happening when customer is supposed to be authenticated by his password, but a syndication failed or not.

B

Really, no, that's when you changing your email address, you need to provide your current email and yeah in this case is the email, the counting will this roll 1b hey? We have an exception in current passport.

C

B

Also return passport right, I suppose.

C

It's fine to keep it like this cuz. It's some kind of authentication authorization exception, good good,.

B

For me, thanks then yeah in general. If we keep the password and we'll draw requests.

B

So you put the email address which we have dated with a break password, and here it also changed yep. That's all from my side for now, I will proceed with it. I will Jenny make a code clean in there we'll make a pull request out of it. Then maybe we'll switch to test.

A

A

You could stop share screen.

A

Last hour presented its Alex Belarus, who provide information about summary texture changes about some architecture, proposals Alex, please.

C

Okay, so one of the items which I would like to present today, I mean signature of our is overs I already posted this in graphical channel, so you might have seen it, but I will just briefly give an overview. So if you look at implementation of our solvers at the moment, usually you would see something like this at the end of it over just before we return the value. Let's say: if you're at lower returns, I know you are trying to get talking for and yours over supposed to return the token string.

C

You will have to drop it into this go back and again, you will have to be white. Go back to the third value factory, to create this different value of escoba and how this is the post work. I can actually briefly show you like what I'm talking about. So this is like. The third is mechanism for solving and post one problem in graph, kill and, and once one problem is, let's say if you in this example. If you want to go like stories, you want to get like ten stories and for each story.

C

You want to get author like it's, not the object. In this case you will get like, let's say one query, to get all stories and then you have to perform one additional request for each story to get also. So, in our case, it's let's say getting list coded and also getting information about prices and any additional relevant information for each product. So you basically can use collection to get list of products.

C

Let's say: I get 10 products if you replace it like these products and then you have to iterate for each product and request information about prices for each them, and that's why it's like n plus 1. So you get like one top level request and and request for each item. We should get respond, that's why so I can't respond, and obviously, if you get deep nesting, you will get even more trouble so and the solution is actually. We have example in our products.

C

I can program, you get two products just to make it more relevant and what we do here. We resolve products. You can notice that we add school of products, some product data provider and then like somewhere. Here we like in this go back. We used data provider to get information by school and what's happening. This data is shared, object means it's like Google object, shared between like within the system, and it works as a registry.

C

So we just register all schools that you'll need to load would say if this collection of products and then a callback is invoked and you actually try to get value of specific product and what happens we already have accumulated like by invoking like this resolver group invoke multiple times each time for different product and each time you will add different scooty registry for each product that you want to to load and then, when you try to actually use the value of the first product, what we will do inside of this get product by school, we will load the whole collection with filter by all school.

C

So it will, it will be like single request and same same can be done like by for attributes or for anything, and we will just use it as the registry and we return product from the collection like requested product from the ordered collection and when you get towards a second product and you try to fetch actual value.

C

The collection has already loaded all the data and you just get it from registry and that's how you get optimization and avoid unnecessary database calls, and that is just a small background like why do we have these different values overall, like any questions for this one so far like what? Why do we have it.

C

Questions and current implementation of resolvers in Magento specifies that all resolvers must return this default value and one of the main reasons for this was just to unify interface and see like if it will be easier for developers to work with, like in Fred interface and eventually looks like it leads in most cases to this boilerplate code. When you have scalar value or you have like array of scalars or like basically some simple response, and you have to wrap it in this callback.

C

And then you have to wrap it in the fruit and it's just unnecessary code, and the proposal is basically very simple. To extend the interface actually so here to extend the interface of.

C

Resolvers to allow scalars and allow arrays in addition to default- and in this case you will be able to just like basically in this example, you will replace this code. We just returned data and it should still work unless you need to perform optimizations for this n plus 1 problem. If you have this problem, you will still have to use default, but if you don't want to solve it all, you don't need in your in your specification.

C

You can just return your data without any callbacks, so feel free to go and vote for this or just leave comments on our architecture.

C

So we have special github with architectural proposals and design documents and we have pool requests there and one pull request is this initial draft for consultations and other graphical improvements and one of the documents here is basically this proposal.

C

Somewhere here this one.

C

Also I would like to mention: I would probably not go into too much details, but I would like to mention that we're still continuing work on schema for checkout and in this print schema for card was extended like for clearing card information and again it's the same.

C

Who request in architectural repository so feel free to go and leave your feedback do code review and if you're interested in architecture of card feel free to reach out to me directly, we can work together and hopefully this proposal will be completed next week and we will be able to create all necessary tasks for which code and at the moment, I will probably go and show you the list of existing tasks.

C

So we have Zen hub and then in ready to start, you can see that we already have some card operation mutations like adding all kinds of products to card, and also we have some mutations for coupons and I believe the old in progress.

C

Oh, it is the one progress so as soon as we complete this scheme of car key, we'll be able to groom and move all cards related mutations to ready to start so feel free to participate in schema design if you're interested or just pick up any tasks, I suppose that's it from my side. I don't have.

D

C

A

You Alex and looks like good, that's all for today, and maybe that's somebody real question who maybe noches.

A

Oops, no so guys see you next demo and maybe we will demonstrate more functionality as I say it, because we are waiting a lot of guys from vacation and also you I believe we will demonstrate some good statistic related to our open water quest. So that's all for today and thank you for.