Node.js Internationalization Working Group, 17 Apr 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Node.js Internationalization (i18n) Working Group

Description

No description was provided for this meeting.
If this is YOUR meeting, an easy way to fix this is to add a description to your video, wherever mtngs.io found it (probably YouTube).

A

A

Alright, it looks like we're live so should be working alright. Well welcome to another amazing round of the internationalization working group for nodejs thankful for everybody here today. Who's joining Alexander has been doing a lot of amazing work and just pushing some things forward and he's going to update us on that. There is an issue open that I'm sure everybody is referencing right now about the agenda today and if nothing is you don't see something on there you'd like to add, please do, and we haven't really been great about here.

A

I haven't been great about keeping minutes in the last couple means I've been in. If anyone would like to volunteer to keep minutes, that'd be great. If not I can do it and I think I'm gonna, kick it over to Alexander to kick us off on the agenda. So progress from you, yeah.

B

Thank you, hello, Zeke, nice, nice to see you nice to see everyone. Oh yeah I'm, going to show my screen and.

B

So I just want to firstly, I said the first step in agenda is progress review? Do you like to give everyone an update that we what we did for this week and we finally merged the guidelines? So it's already live and that's why I also created announcement for teams I have to open this quickly.

B

Just a second, so yeah I create an announcement in teams. We we finally done with a structure of teams that was discussed in this issue like a new structure. So we now have the structure like this. We have general team for the managers and sub teams for each project. It's it's created for getting notifications for crowding managers to add some to change. Some stuff related to crowding project, for example, make someone proofreader or adding some language and other stuff.

B

Another thing is global team called no GES translator thanks, read reach to help help that we are really just renamed team localization to translators, and now it seems like okay, I have admin permissions to this team and I write this quick update for everyone, because we here on this meeting, we know what is going on, but all our community of translators probably doesn't know and that's why I created this announcement here, like I, wrote all key point about what we did and what we are going to do and like it seems like someone started reading about it and it's great so yeah, that's!

B

What's related to team structure and yeah in general, I'm going to post in this team feed some our announcement, general announcement related to teams, I I, think we have some something to discuss at the last point here. It's really interesting stuff about. Let's do this and the last step yeah and, as I said, we merged the guidelines and it's already life. So if somebody have a question, we can just refer to the our guidelines.

B

I'm I started using it before rumors, but now it's like official. If someone find any problems, any mistakes welcome to create pull requests or issue and I think we will resolve it as soon as possible. Yeah.

C

B

B

Yeah well, thank you because.

B

Yeah so yeah, that's like a general progress that we have also we merged some stuff related to synchronization scripts and for testing and perform. Unfortunately, I we are have some conflicts like I am and unique. We created the same functionality and it's so said that we are like we're, can't merge, NIC changes and we merged my changes and I feel so like so sad because I think it's my fault, but unfortunately it happens, and we should close this PR but yeah what what this change is doing.

B

It's it right test is that check-in for any deleted files in translated content, because crowding cannot handle this stuff from their site. So, for example, if something deleted from original source on some previous versions, it's going to be deleted from translated file. It's never going to be deleted from translated files and it's going to be deleted from original source in in one day in like in our synchronization period in 24 hours. So it's it's.

B

How it's working and my functionality like just testing, push it updates from crowdin for this like deleted files and it testing it and if something like, if some files now deleted, we are can no we shouldn't delete it manually, should delete it by crowding, but when you just wait a few one day before merge sample request, so that's. What is that is.

B

This testing is like can flag us that we shouldn't merge this PR and we should wait yeah and also we are deleted all the files that already have this issue like if it was pretty previously deleted from original, and we are deleted this the same content from translated files and yeah we're merged it. This is what happens on this week, so.

C

I just started a comment to that request, suggesting that we closed it yeah.

B

A

C

Was good of you to add that comment saying you know, I want us to work together and I, don't wanna.

B

Spend time yeah it's it's really uncomfortable thing to.

A

B

So it's like a progress review so next that, if you want to discuss, is like go through the issues that we have open now, the first three, the first one is protecting content from direct changes, so I described it here and my idea is is like is understand like to protect sunset content from manual changes through github flow, because we wanted to move to crowd in oh and we don't want to go with github at all and so yeah. We should protect in some way.

B

My idea is to use github actions to check each pull request, and if this pull request contains some changes for translated content, we are just automatically close it and write. Some message like please go, please read our contribution guides and you should use Crowden instead of github PR system. Don't you little bit so.

C

I think that might be a little bit too extreme because there might be like a an owner of the project, who has a good reason to touch the files in there.

C

So if the PR was just gonna, automatically close I think maybe something a little bit more lightweight like a github action that detects changes and adds a comment that says hey. It looks like you touched files in the translations directory just so you know, that's not how we do translations, something like that, and then another human can become involved in the conversation you know.

A

B

I think it it works, but probably we can like detect like write. Some additional rule to our github action like admins, can still can push something to master and make some changes, but we just protect everything and it changes from simple contributors, because yeah yeah I understand your point. It's reasonable, but in the same time, here's possible case that someone create a PR and someone make a proof without investigation and that's why, like it can be merged, it's not very critical. In general, we can merchants crowding synchronize everything, but it's like anti-pattern or yeah.

B

A

Yeah we're just preventing, emerge, I guess like preventing a merge unless it's reviewed by an admin or something like that. Probably yeah good. You know so like I, guess you could that that would be just as effective. You know I can it wouldn't be as lengthy as far as closing the issue? But if you did throw up a comment saying this is how we do things and yeah then prevent merge, you know, must review or something I guess that would be compromised. You know another thing you could.

C

Do because I mean the goal here is to educate contributors so that they don't accidentally spend energy in the wrong place. Yes, we could also have a get hook in the repository that we used like husky or something to add where, if you try to do a commit, basically a pre-commit hook, it says: oh, it looks like you're trying to touch files in this directory. Those should not be changed that way. We stopped contributors from doing the wrong.

B

C

Earlier in the process, so they don't go all the way to opening a pull request before they realize that they wasted their time. Yeah.

A

Yeah, that's really greedy.

B

Yeah sounds great yeah.

B

Yeah good idea, so, let's think about it more yeah and second thing is infinite. Pending checks on how to create appears yeah, this stuff is like ID I found when I think we wouldn't a how to generate appears. So here, I just opened two examples that we have, and so this original content update is like the stuff that we also. Finally, merchants is weakened on this week. Oh yeah there's also one great feature that we don't this week.

B

It's like we make night sync with original repo and fetching all content updates to our repo and fully automated, and it works now. But I am also going to add some mentions for a team to review it because I configure it actually like it should add some reviewers here, but it doesn't I tried to the reviewers as a team members, but it seems like not work. Well, so I'm going to add it here in the description of PR and it will works in the same way.

B

So yeah they're problems that I faced is not going to like check.

B

It's not going to pass workflow with github actions without additional commits, and it's like not very good, so I, don't know why. Where is the problem because, as I said before, I'm not very confident with github actions, I just started with it, and probably someone this bigger experienced, have some idea what is going on so I tried to google it, but no any specific issues. Explanations. So probably if you have an idea, so if it's, if pull requests created by github actions, another github actions not triggered and something like that yeah.

B

A

B

I, don't know what is it? What is it yeah to merge this pr's I just make some trigger commits and it works so yeah, that's a problem and it's open. Probably if someone have time you'll be great to investigate. Yeah and big discussion welcomes it here, so we can finally talk about it because every time is going from one agenda to another agenda. Yeah.

B

Like you said, will become of NPM model how we're going because we here, you can see a list of issues and pull requests related to NPM model and I. Just when I try to clean up all stuff in this repo I discovered that we have a lot of that related to NPM, and probably something is duplicate, that something is actual, so I need to understand and understand in general, do we need NPM model?

B

So I start with this conversation, and here like just two opinions, my MZ and if you're not wrong, oh yeah and as I also edit his opinion. It's great here is something about progressive web application and I'm, not sure that I understand this point, but yeah so I understand your point: Zeke it's about! Okay, don't push it to NPM and just make this repo like NPM model and okay is okay. Let's give an ability to install our translations asks and be a model from github and also github is part of NPM or vice versa.

B

I, don't remember so it should be like easier in the future. So I'm, okay with that.

B

But my question is how so yeah we have one full request from music and you need like to complete with that, because it's still draft and what we are waiting, I reviewed it and it seems like okay to me so I I'm, okay, with the structure. But after we are merged this PR. We need to understand what what issues and pull requests. We still need to keep open and what are that we can close, because here's a lot of stuff, yeah, yeah.

C

Okay, yeah, so yeah I think the the github based npm install' approach is pretty lightweight because we don't have to add any more process for publishing to NPM. We don't have to think about versioning, necessarily it's just kind of like you get whatever is on master. Of course you can also install from branches and tags with installing from github as well. So I think it makes it convenient for people to be able to just bring the contents of the project into their project without having to know too much about it.

C

So I just took this PR 250 out of draft mode and I will make sure that it's up to date and I'll ask for review, but I think it's it's lightweight enough that it's worth shipping yeah looks great they're, probably I want to. Actually you know what I should probably follow up with some documentation for it. So if we're gonna do this, then we probably want to have something in the readme as well. That says you know you can npm install this from github, so I'll do that I'll, take care of that and okay I.

B

Can also follow.

C

Through on all the old issues and PRS as well and just close them because I don't think that anything is really active anymore, yeah.

B

It's it's great, so yeah, it's also seems like solved. So we have a big progress today. Meeting yeah, cool yeah and last I think it's just I. Add it like it's the last point and I added this five five minutes before this meeting and yeah. It's just to talk with everyone is about standardizing l10n repos.

B

So as I described in guidelines, I hope, you'll read it as this repos is going to use by utilization teams, and this repos should be used in way like write. Some language, specific guidelines, discuss some team management stuff and and that's it basically so my idea, we need to structure all the repos in one way like initial step, because for now some repos contain translations. Some repos contain nothing. Some repos contain scripts ant. It's it's!

B

Okay, if you understand all all project structure, but if you are new in in this process, it's can confuse you and I think we can avoid this by making some readme structure trim readme for everyone for all locals and they can like translate to their language, and something like that. Oh yeah, and also one point for this repo is to discuss glossary.

B

It's like language, specific stuff, so yeah I think we need to like make a boilerplate readme and propose it to all teams to just remove everything from variables and make readme and propose to the teams to make their guidelines, probably if they can translate our English guidelines to vary language I'm, not sure it's very useful, but probably, if he's okay for someone and also proposed to them to like write their rules, how they won't wait. They rules how to create issues, probably some boilerplate of issues and other stuff.

B

So my idea is to remove everything from the repos and set a one readme file for for a first step and then team can decide what they want to do, create guidelines and did you see, but for the first step it just readme and remove everything. It's only.

C

B

Like that idea, I.

A

Think there are some stages, probably to like there's a lot of RF, like you said, with the scripts and stuff there's a lot of artifacts and things from you know, past iterations of internationalization, so I think what we're gonna have to do, as you said, is like templatized.

A

You know contribution guidelines and that sort of thing and saying like hey this is you know this works with a new structure, the initialization team, and then you know, like I, think the the one thing is predicated on is just knowing knowing who is you know the the manager of each localization team and so being able to have that conversation with each. You know each maintainer of each localization team. This probably is what needs to happen.

A

So if we can get that a competition very long and then kind of give a template over to each active group, that should really work and help them be in sync with us for sure. That's right, yeah, okay,.

B

About this, maintain their stuff I think we need to write some instruction in structure before.

B

Okay, so firstly I explained the case. So, for example, we have some l10n group repo. We maintainer that don't want to work with translations more and they he is not we're, not active. So as a result, we haven't many maintainer and we need to write an instruction, how we can give a permission to some contributor to be maintainer, because we we still need to have a maintainer and neck connective. Maintainer is, but is not where it's not our way. So we need to fresh refresh everything so I think.

B

Firstly, we need to write instructions and then we can just post it here like in general feed, and then you team members of each team can like post their status or something like that. So do we have active maintainer, we haven't, we need help and, if based on instruction I think it should be like create an issue if you haven't active maintainer to ihe and repo, and we will make us maintainer if you propose your yourself, yeah I think it's. It should be. It's long.

B

We have a channel to communicate with everyone with all teams, with all translators, so I'd like I, think it's the best way to do that because researching and try to communicate with each member directly. It's probably it's it working, but it's it's some headache.

B

A

Directly, there.

B

Yes, okay, so I think I'm going to create another issue to to write guidelines for about updating they repose and about resolving maintainer problems for first step and post. It here I think I'm going to write it. You know next week, yeah so and seems like we are done. Is our agenda? Do we have any questions just just.

A

A thought for making things more accessible on the translator side of for every, like localization team, I, think whether template it might be cool to give them a template for or get on page as well.

A

Just to like you know, make it less, because if translators are going to be working, you know like in crowd in you know they might even want to make contribution guidelines for how to do that, and you know make it get hub page, that's localized, to like each community original position group that might be that might feel like nice and welcome. Okay, okay,.

B

I agree: yeah any other questions.

C

This is not just not a question, but I didn't realize you were developing on Windows. So that's pretty cool to see that, like no.

B

It's just temporary solution, because this current team stuff is requiring me to move from my like from my town, where I I work in and to go back to my hometown and I have just my laptop yet I bought in a previous month and I just started using and I haven't I I! Think I don't want to install Ubuntu here and I'm trying to work with Windows. It's a bit tricky yeah.

C

So, are you able to run like the test suite and everything on like? Are you able to use the I 1889 project? Yes,.

B

Of course it's running yes, yes,.

C

I didn't know that we were like already set up for that yeah.

B

It's working fine, my uh I didn't face. There's any issues, it's all sort of that. It's.

A

Really is a localization like what what we're using before anywhere Windows.

A

What were using before you were on.

A

Has your experience with like localization, been any different? Why do you prefer one over the other of.

B

Course, I prefer one too, because I'm developer, it's like any database, is running. Click from I, don't know from core any SQL database is included to bone to build any other stuff. Is installing really quick without problems. Environment variables pass? Oh.

A

B

C

There's a there's, a NPM package.

C

So that's why I was saying I'm kind of surprised that everything just works like out of the box. Yeah yeah, it works. I think I will probably also add a Windows test to this module PR, because we can test on with github actions. We can test on them different operating systems, so I'll put in Windows and Ubuntu just so we're covering our bases.

C

B

Okay cool: they want to include it to your GRP RVs and be a model structure, probably yeah I'll.

C

Take a look and if it makes sense to do it.

A

There's a lot of awesome conversation today and yeah progress. This npm module thing is awesome. Just thank you for all your work there and for helping us plan that conclusion today and thank you for your continuing to kill it and impress things forward and make internationalization over you. So thank you for that.

A

Yeah just excited. Thank you for joining us was a if there's.

B

A

Anything we said today was super quick and you know sorry to understand and feel free to ping me on on slack or anyone here and we'll try to help, explain anything or explain anything and yeah I. Think anybody who is listening today and we're just grateful for is this team of this progress and looking forward to next week. Yep.

B

Yeah, thank you.

A

B

Thank you, guys, I'm ready for a nice day, bye.