Open Telemetry Uncategorized, 31 Aug 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-08-31 meeting

Description

OpenTelemetry PHP SIG Meeting

A

A

Hello, tobias, how are you.

A

Yes, I'm very well. Thank you.

A

Might be a short meeting tonight if or today, if it's just you and I I think uh prishmek might be along, I just so we're updating the meeting notes.

A

All right, it looks like it's just you and me, so we can probably need this very quick. uh Tobias. Is there anything that you wanted to talk about with the current pull requests that are open? No, no.

A

Nothing special okay, how's how's 809 here gets to open. Do you want me to review it yet or have you still got some more work to go on it? There's some work left, but it can be reviewed. Okay, all right, I'll review that as soon as we're done here.

A

um My two- I think I'm happy with um feedback's welcome, but um I can't do anything with them until bob comes back, because I need him to approve them. So I'm stuck on those two uh amber's refactoring.

A

I think we were pretty close.

A

um Sorry, you had it uh sorry you've reviewed that, and uh there are some more changes for ever to make. So we'll leave that, and these two haven't been touched in a while I'll ignore those um and over in control. um Carol's thing, um I'm sort of talking to her uh on slack uh about that.

A

We'll um review that sorry I'll I'll commit that merge that when, um when she's fixed up a couple of tests- um and this demo is interesting- um you probably at least saw that I started a new channel on slack just to talk about photo instrumentation.

A

um I think you're by far the furthest along. So hopefully, what you've got can be the basis for auto instrumentation, depending on what what other people are thinking. um I did notice in your pull request that you've created a.

A

A php extension um is that, somewhere, where other people can look at it yeah I uploaded that last week it's very basic.

A

um Maybe if you just, let me know about it or um where it is just so that we can link to it in, in slack, for others to take a look um like preacher mac, hello, welcome,.

B

A

uh You've missed uh this- is it's very good to be a very short region today, but we're just talking about um auto instrumentation. So it's it's a good thing. If you've arrived, um I was just asking tobias whether the sort of the code for the extension that we've got a demo for just can be made available somewhere, so that um so that we can have a look at it and try to understand what it's doing and see whether it's useful for you know. Can it be the basis for your work, pressure, mech or um yeah?

A

How we're going to move auto instrumentation forwards.

B

Yes, so I looked at this code and for me it's the right way to go. Unfortunately, I haven't time to to run it and test it, but uh looking at the implementation, as I understand it, it we have a car functionality implemented in c. So this is a base extension and then all the hooking or instrumentation is uh exposed to php right and we can do that in php.

A

B

So the only maybe question that I have is how nature is current php uh uh sdk uh implementation?

B

A

It uh it's still it's still alpha. At best, um we look. We think that we're close to beta um okay, at least in terms of the sort of the issues that we've got, that we think we need to to action before peter are mostly done. um So most of the most of the changes that I'm seeing now are just people improving things, uh refactoring things just to make them improving the code quality, um so yeah maturity, no still not still not stable.

B

B

Yeah but anyways, I think that's uh right direction regarding this uh tobias work and I think the other option that you were discussing before was to have a whole implementation in c right.

A

uh That was yeah that was proposed a few weeks ago. um I I don't know whether they're still thinking that, certainly there was I'll, say resistance from from sort of the maintainers, because we don't want to throw away uh the current implementation.

A

um So if, if they go ahead and do something at all it would, I would imagine, be external to to this project almost a competing implementation.

B

A

um So twice did you say you would made the code, the instrumentation c component available somewhere yeah. I posted a link in the select channel ah fabulous. Thank you. That's all! That's what I was going to ask you to do so from there. We can take a look at it and um yeah that that helps us to move along. So that's probably all you need to do for that. For the time being,.

A

uh Well, let's just finish this meeting out with uh issues. There are, I think, only a couple of new new issues. This partial success. I've started to work on as part of updating protobuf, um and I think this issue is related to protobuf version as well.

A

I I haven't replicated it, but I think um I think what they're referring to here is that there are deprecation um errors coming up when you've got a certain level of um error, reporting turned on in php, so I suspect that will go away with with um um upgrade to the latest version.

A

uh So that's it for me.

A

um Was going to raise a question, but he can ask that on slack, uh so if no one else has anything else that they wanted to bring up or talk about, then we might be done for today.

B

A

Excellent going once going to us all right, we're done! Thank you very much for your time. Thanks for coming along, see you on slack or we'll, see you next week.

B

Thank you very much. Bye, bye,.

A

A