VMware Velero Community Meetings, 14 Jul 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Velero Community Meeting / Open Discussion - July 14, 2020

Description

July 14, 2020

Status Updates
(ashish)
Community support last week
Fix for capturing version of CRD before version remap plugin:
PR 2683 (https://github.com/vmware-tanzu/velero/pull/2683)
Merged last week and is in this weeks 1.4.2 release
PR reviews:
VolumesnapshotProgress design proposal PR
merged last week. 🎉
Ordered Resource backup design proposal
Couple of passes at the
Fixed Issue 17 with PR 60 in the velero-plugin-for-csi repo
allows users of the CSI plugin to keep regular volumesnapshotclass separate from that used by Velero. Primarily to allow different DeletionPolicy.
(carlisia)
Community support
Blocker (BSL controller): https://github.com/vmware-tanzu/velero/pull/2674
(nrb)
v1.4.2 is out!
Includes fixes from CRD
Going to try to help catch up on community support this week, particularly on GH issues/PRs.
Get master to main transition done this week

Discussion topics
Emmet
cacert integration w/ restic & rancher
https://github.com/vmware-tanzu/velero/issues/2675

Contributor Shoutouts
@a-mccarthy: add style guide file
@firethestars: Added Arm Multi-arch Make Logic
@ehashman: Fix missing quotes that are breaking page render

A

Good morning, good afternoon, good evening, everyone and welcome to the valero community meeting and open discussion uh meeting today is july. 14Th 2020 I'll be your host today, jonas rosland and with me we have the belero team in the the lero community. So thank you all for for joining today. Let's uh roll and get started with some status updates. I'll share my screen, so you all can see it as well.

A

All right so uh to start off, we have ashish.

B

uh For me, I was on community support. Last week I had a bunch of issues to triage and some pr's to review and quite quite a few uh interactions on slack uh with folks, so I was doing that uh last week. We also got the fixed, the crd version, capturing uh bug that we surfaced uh dude and that's in our 147 142 release that we published yesterday.

B

And then uh yeah, I got a few pr's out of sorry. Pr's reviewed uh the volume snapshot, progress, design proposal was is now merged uh and thank you vishnu for your patience on that uh and the I think um the proposal from phong uh that is almost ready for merge and I took a couple of passes at dc spr of the backup storage location controller. I thought I pasted the link. Apparently I didn't uh I'm going to do a final review of that today.

B

uh Apart from that, there was a long-standing issue in the csi uh repo where um it was not. uh If there were multiple volume snapshot classes for a single uh storage provider, uh the plugin would pick the first one that matched the driver name.

B

So I put in a pr to let folks add a label on that, and belarus will look at the label to select the volume snapshot class to use. So I have that pr out for review. So if folks want to take a look, uh please do so.

B

uh That is mainly to let people control, like the deletion policies on the volume snapshot class, uh so happy to answer more questions about it. If anybody has any- and that is all my status updates.

A

All right any questions, comments for ashish.

A

So you're, um would you like some reviews on this one.

B

Yes, please, the pr yep.

A

Perfect so the pr number 60.

A

Awesome all right! Next up, we have carlysia.

C

I'm on community support this week and the vsl control api is still sitting there. It's blocking the external contribution and sort of blocking my uh other conversions of controllers.

B

I I will take a look at that currency. I'm sorry.

A

Okay, do you need anything from the the rest of the team and the community members here.

C

I need for it to be revealed.

A

A

Any questions comments for kalisia.

A

All right next up, we have nolan.

D

um Yeah been working on.

D

Been working on some um internal stuff last week um got the 1.4.2 out um kind of skipped. Over 1.4.1 there was a little hiccup with the transition between travis and um github actions with 1.4.1, so we had to move up to 1.4.2 there's some fixes for crd.

D

Backups there, as well as some issues for additional backup item actions when the item can't be found on the cluster.

D

As far as this week, I'm going to try to help get caught up on the um github issues. I know we were a little bit behind on those and also um there's a bunch of pr's out there. um I know we really need to get the backup uh controller or bsl controller in in and I'd like to get uh final reviews in on a couple of the design prs, particularly the restore hooks design. So we can start implementation of that um and then also on the docket.

D

This week is getting the master to main transition work done. It looks like most of the documentation fixes are done, but I want to take another pass through code to make sure any branch any scripts or anything that reference branches or things like that are updated.

D

And I think that's most of what I've got.

A

Do you need any um any assistance with the transition here.

D

I don't believe so. I the the main thing that's going to happen um so the the main thing that will happen for folks that have in the community um is instead of just renaming master domain, we're going to create a new main branch and update openpr's. To point to that.

D

If you have merge conflicts already, she'll still have merge conflicts, but um I was gonna uh myself and, and hopefully the team we could make some time to.

D

Edit those prs and just redirect them and then close down the master branch, so this will be more less disruptive than what we talked about last last meeting. um So I don't think there's there's going to be as much noticeable. Two.

D

A

All right sounds good. Any questions, comments for nolan.

A

All right, uh then, we're diving into the discussion topics. We got emmett here on the call you can unmute yourself.

E

Hi, how are you doing? Jonas, I actually don't know I just added it there at the last moment. um It's just it's an issue that we have open for a couple of weeks on the on the github there in relation to ca, search integration. um Again, I'm not too sure this is my first time in the community discussion. I'm not too sure if this is the right form for it. Welcome thanks, very much and we're using a rancher environment, and um we what we've had to do we're using the latest d.

E

Well, we're not using 142 uh we're using one four uh in order to pass the certificate to the valero installation, we have to annotate the uh the deployment it doesn't seem. There doesn't seem to be an option in the helm charge to include the ca cert.

E

I could be wrong on that uh from what I've seen there isn't anyway, um so we've included, we've included, we've added the annotation aws underscore ca, underscore bundle to point to a persistent volume that we add and stick the certain there that manages to get the valero deployment to have some visibility on our internal s3, but it doesn't seem to pass it to the rustic deployment.

E

So we've tried various different methods of trying to force the rustic uh deployments to see the certificate by uh adding a second by re-adding, the repo from the restrict deployment manually by adding the certificate in the same way as we do with the valero deployment, but uh no matter what can't seem to get rustic to recognize the certificates so we're having to do our backups over http and that's where we're at again. I'm not too sure if this is the forum for it. If we want to address it in the actual github issue, that's fine.

D

Yeah, I think good.

C

D

I thought I thought.

C

We had added that to him I'll have to look.

D

Just doing a quick search on the commits for the home chart, I don't see it, but that doesn't necessarily mean it's not there.

D

Yeah I'll have to double check, and we can you know this is one of those areas where I intended to go through the github issues, but yeah we absolutely and I and I think um the helm chart might be missing some feature. Parity right now.

B

Yes, especially with like really uh flags up added in certain releases, we don't uh we have not done like we've not been on top of keeping that at parts. So you need to do that.

E

Sure that's fine uh that can be addressed in the in the github ticket itself. I don't want to use up the uh the community time here.

F

Oh, don't don't worry about that! uh This is great. Thank you for for bringing this up.

E

I did see another. There is another ticket. I think it's actually on the vmware uh tanzu helm page in relation to a ca search.

E

Option for the helm charge, so I think some I think I linked it on my ticket there, uh but it's it. There is an issue there for it as well. Yeah, it's the second one there there it is there.

E

So it's the same same topic, I'm sure, there's something I'm missing to get uh to force rex stick, but no matter what it does seem to be a manual process to have to.

E

To get rustic to look at to look for the ca cert option it doesn't valero doesn't seem to pass the cert to the rustic deployment.

F

I definitely seem to recall: we've had similar discussions about this a few months ago.

B

I think that was when we were implementing the cs: support, uh see a custom, ca integration, but uh let's, let's triage this issue and figure out, what's going on it'd be hard to triage. It live.

E

Yeah uh we can. We can dig through this on the ticket itself, thanks.

D

For watching yeah and I dropped documentation in on this um into the zoom chat. I do remember the code changes had um the the code had changes to rustic to the intention is to pass this down to rustic um there. There were changes meant to pass the the custom cert to the breast of commands that valero issues, um but that doesn't necessarily mean that we couldn't have a bug or something.

E

I did follow that. I just saw the link that you said there.

E

I did do a manual valero install rather than using the helm chart with the ca search option and uh unfortunately it it still didn't push it down to the uh to the rustic pod um yeah, no matter how hard I'm trying, I don't know, maybe if it's something related to our rancher environment, oh okay, yeah, but um I couldn't I I configured the um direct I just I I deployed it directly from the node so completely avoiding the rancher environment using the palero install command um just to try and kind of roll the rancher out of the equation um sure.

E

But I I did it still didn't push it down to the part to the rustic part. Okay,.

E

Anyway, I'll leave it with you guys.

A

Thank you so much evan.

A

uh All right uh does anyone have any other discussion topics for today that you want to bring.

A

Up all right, then we're diving into contributor shout outs, nolan.

D

um Yeah so um abby added a uh from from vmware added a style guide. um This is for writing, uh documentation and blog posts and just any kind of pros. I guess words um for uh the for anything valero related, um so we're gonna try to follow this. um Thank you very much abby for contributing this.

D

um So if you're, if you're, adding um adding documentation or blog posts- or things like that, um use this as a reference and try to follow this, and we will try to follow this as well for doing reviews um yeah and again. Thank you very much abby for for spearheading this um and, like it says at the top, it's based off the kubernetes style die guide, but it is adapted from that. It's not an exact replica.

D

um Next we have um this whose fire the stars um this was for the. I think this was for the yeah, the aws plug-in, um so we got um it says multi-arch, but it's mostly for arm builds. um So we have arm builds now for the um the aws plug-in um we had arm builds for core valero. um We have not made new releases for the any of the plugins with 1.4.2, but we will definitely have ones for 1.5.

D

No guarantees yet on any plugin releases between now and then, but thank you very much for getting this in. um This is very helpful for people who aren't running on the standard amd, 64 architecture and then finally, um we've got uh a fix for our page rendering uh from e heisman um elena. um Thank you very much for this. This just fixes some rending rendering on um our yeah this. This right here uh was not rendering in uh fixed width uh because there were some missing uh backticks. So thank you very much appreciate that.

B

Awesome on the multi-arch image building pr, uh though we don't have a release with those changes, the images for the for those should be available on docker hub with, like the master.

B

E

B

Yep, just in case anybody runs into this and wants to use the.

A

Images uh does anyone have anything else to add for the meeting today.

A

All right short one today, uh thank you, everyone for joining and have a fantastic rest of the week. Everybody hey.

G

Jonas uh hold on just one second before you, you drove off uh really quickly. Carlesia, you sent an email to the channel to the google group about apis. um Is that something that might be worthwhile to talk a little bit about today, or should you just push that discussion for uh for another day.

C

I don't know how we could handle this. We probably should mention it every minute at every minute at every meeting, so that wasn't a new issue. That was an issue that we talked back a few weeks ago. We started talking about this. uh We are going to start moving cold out of packages that are public, so just I guess we should add it to the discussion every meeting nolan. What do you.

D

Think sorry, I lost my zoom.

C

D

Yeah, I should probably just add it there every every week and just bring it up. uh That's been my intention and I just keep forgetting uh um yeah just a reminder. Well, this would be an ongoing thing.

G

Yeah and essentially, there's there's two things that we're doing right so number one is that there were a set of private apis of alero had which are no longer going to be maintained. There could be change and and and either if there are entities or users or automation that made use of them would like to know, because you know they're private and they shouldn't be used. So that was one part and the second one is. There are public apis that potentially um uh that you might want to change as well.

G

Right so was, or was it only the former thing which is private apis that people use as if they were public apis and they were not supposed to be maintained.

C

It's mostly the prior thing, the public apis that we have what we think of public apis, the ones that are intentionally public are the ones listed there and right now, we are not thinking of changing them.

G

Okay, so we should basically say if you're, using apis or valero that were accessible to you, but they were not documented. Those are not public, they're private, they could change, let us know because you'll be impacted and, and you will get uh deprecated.

C

Yes, that will be very accurate, yeah.

G

C

Not documented here on this issue, yeah.

G

You might want to re restructure your email from yesterday as well to indicate that I know you added the github ticket but make it clear to them, because uh you mentioned they were making many changes to the valero public api and that confused me as well, because I was thinking. Oh we're, also changing the public api on top of the private ones being deprecated.

C

I think I said that michael. I would check okay.

G

C

G

Yeah it's it's okay, like maybe I'm misunderstood, but um yeah yeah, excellent. Let's, let's talk about it every community meeting. Let's make sure our community is aware that these changes are coming and uh some folks may be impacted, and hopefully we can work with them to reduce that impact.

G

Thank you. Nolan and carlesia.

D

And I think 90 of the code that people are using is right here, um so I think we're well covered here, but again, if you're, if you're using stuff that you don't see listed here. Please comment on the issue. Let us know um yeah, I'm just going to keep saying it.

D

If it's, if we don't know that you're using it, it runs the risk of getting moved into this internal directory and not getting exposed any longer.

A

Sounds good, thank you, michael for bringing and bringing it up any other last questions comments for the meeting today.

A

All right, then, we're finishing now. Thank you all for joining. Have a fantastic rest of the week. See you all next week, bye everybody.

F

Thanks very much guys, everyone.