VMware Velero Community Meetings, 25 Aug 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Velero Community Meeting / Open Discussion - August 25, 2020

Description

August 25, 2020
Status Updates

stephanie
building the priority/stack rank list for the 1.6 release
this will be published after we complete planning next week for the community to refer to and will include additional details that compliment our current product roadmap

ashish
Community support this week.
Misc work for the 1.5 release:
Pre-release is out. Try it out in your non-prod environments
Bug fix for server version not being correctly displayed as output of velero version.
Updating some docs
Getting PRs reviewed and merged.
Testing out the release
Will be taking another look at the exec restore hooks PR.

carlisia
community support last week
ServerStatusRequest PR (migration to kubebuilder): https://github.com/vmware-tanzu/velero/pull/2838
wip: DownloadRequest migration to kubebuilder

nrb
released v1.5.0-beta.1
testing the beta - please try it out in your environments, too!
planning for v1.6
Owe a review on the restore hooks exec work

Discussion Topics
nrb: We aim to have v1.5.0 out by September 1
Let us know what Velero code you depend on
Defining printer columns
Do we need to get the exact same values as Velero’s CLI in kubectl printer columns?
Not necessarily - they can be raw values, but we can use webhooks for calculations.
Phuong updating go modules
1.5.0-beta.1 generating CRs having issues
The error has an issue with missing a context argument - related to upgrading to Kubernetes v1.18
ERROR] generated/clientset/versioned/typed/applicationtemplate/v1beta1/applicationtemplate.go:73:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("applicationtemplates").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
[ERROR] have ()
[ERROR] want (context.Context)

Contributor Shoutouts
@a-mccarthy: add index files to api types folder
@ipochi: docs: add metadata to resource-filtering.md
@bgagnon: Override logrus.ErrorKey when json logging is enabled
@jenting: doc: fix feature flag EnableCSI on velero backup describe command only

A

Hello, everyone and welcome to the valero community meeting for tuesday august 25th. uh I will be your host uh john, since jonas is on pto um going to go ahead and get started with the status updates. Again so looks like first on our list. We have stephanie.

B

Hi everyone, so I just wanted to mention again that we will be building the priority stackrank list for the one sixth release uh performing the planning with the team this week uh after we've completed that we'll publish the list in the form of a prioritized backlog with the 1.6 milestone attached to it to our github, so that you can filter against that milestone and take a look at what we have planned.

B

We do encourage, as we move forward with this type of process and and continue to grow it uh that the community engaged with the upvote down vote uh feature on each of the issues to let us know you know, what's most important to you and as we progress with the releases uh heading into one seven uh in q1 2021, uh we should be able to publish these prioritized lists um much earlier, so that we can get your feedback in even sooner.

B

That's it. For me,.

A

And stephanie, where will this be published? It will just be published in zenhub, will be published in a document.

B

Well, we'll include it in denhub and for those that don't have the plugin, we will be publishing it as a documented stack rank and I'll also make sure that the 1 6 milestone is included on the epics, as well as the associated stories, so that folks can filter on the prs. That way.

A

And and if you don't have the plug-in, um xenon has a a straight web app view too. So you can go to the the web app and it will present things that way.

B

I'll update the notes with some of those links, cool.

A

A

Any questions any other questions for stephanie.

A

Okay: next, we have the sheesh.

C

For me, uh I'm on community support this week, but I don't have pretty much as status updates. I've been doing like miscellaneous work for like the 1.5 release.

C

The pre-release is out, so please do try it out in your non-broad environments and give us some feedback there.

C

There was a bug that we noticed when we cut the release with the server version not being correctly displayed as the output of weather version, so I had a fix out for that and then some documents uh that we published needed updating. So uh I was doing that and other than that I was reviewing prs and getting them merged and also testing out the release to make sure we have everything working as expected.

C

So if you've had a chance to test our try out our releases, our free release, we would love to hear from you other than that. I don't have any other status updates.

A

Okay, um any questions for sheesh.

A

All right, moving on to carlesia.

D

Hello excuse me, I was on community support last week. um Did some work prioritize some work related to the 1.5 release as well. The server status request, pr has gotten reviews and they addressed everything.

D

There is uh great suggestions from ashish to make the the patching of status or patching of objects, uh genetic helper functionality, and I I have been working on the download request, and I did that in that code and I really like the way it looks and I use the the the the helper from the.

D

What was it again.

D

C

D

Cathy thank you because I have always take cluster api builder, okay cappy, so I use their function.

D

If anybody objects, let me know, but it looks really good. Basically, you do a defer patch and then do all the the setting of what updating and that's it looks really clean and what else so I do have some refactorings.

D

I rather push that pr, because it's pretty much ready if it works and then I'll rather do an update for that separately, because I'll have to update the backup, storage location as well. So maybe I'll even do that separately, but I'll push the uh the download request first to see. If that, that's what we want.

D

I hope that made sense. I just I don't know I haven't had enough coffee yet.

C

Yeah that that seems fair that seems reasonable to me. uh Yeah, that's good.

D

And- and I think, depending on on how fast the pr turns around, I think, we'll be able to do to include the download request migration in the final release- I'm hoping for that anyway. So I'm trying to push that through.

C

Yep, I think I think the surface area for that is pretty small and we can test that out really well uh yeah.

D

C

We have good amount of time, so we should be able to include it in the release.

D

It's pretty easy to test, that's for sure, just to think the things download or not.

A

Cool any more questions for carlesia.

A

All right um for my update um release the 1.5 beta 1.5.0 beta um friday. We did it right along with the rest of the core maintainers, so they can kind of see the process. um I've got some pr's related to that process that are up.

A

We noticed some bugs in the scripts that need to be fixed, so hoping to get those in by ga, so that that process can be a little bit less bumpy um and trying out the beta to make sure you know, we've got our our keys crossed our eyes, dotted that kind of thing, but, as she said, please try it out. In your environments. We've got the defaulting.

A

The uh we're enabling uh rustic support for all volumes, um so you don't have to annotate individual volumes if you want to get rustic support, got the delete item, action, support and we've got early preview support for restore hooks. um But I owe a review for the more the um other half of that work.

A

So if you're interested in any of that, oh and um the ordered uh the ordered backup of staple sets is also in there. So um if you're interested in any of that and want to try it out in your non-production environments, please give it a shot and let us know if you find any issues.

A

Also like stephanie said: we've got some planning exercises for 1.6 this week and we'll get that published and look for feedback from the community um and uh yeah getting some more reviews out in between that testing and planning. So that's kind of what I've been doing and what I'm looking to do this week.

A

So any questions.

A

There one more thing I'll throw out there is um the 1.5 version bumps are supported or bumps the included version of kubernetes libraries to 1.18 that only matters if you're, including valero code in your own projects. So if you're doing compilation, then that matters, but if you are just installing valero and using it through the command line, that's not a big deal.

A

And then, following up on that, our goal is to have the 1.5 ga release out by september 1st. So next week um we're going to be testing that and looking for feedback and barring any showstoppers.

A

We are going to get get that release cut by september 1st.

A

And we have our forever discussion topic, it seems uh or a long-term discussion topic. I can let release you. Take this. uh If you'd like.

D

Sure I think I'm well-versed now that's how to go through that. uh Basically, we've been raising this awareness every week that.

D

Velero has a lot of public code that we never intentionally made public so now we're trying to assess we're not trying to assess we're trying to uh remove move that code. That's public! That's not supposed to be public to an internal package, make it private not not acceptable and the pub the code that we do intend to make public are listed here and if you are using any package from the valero project that is not listed here.

D

Please include it in this ticket or let us know in some other way, so we figure out how to make this change and not break anybody's code.

A

A

um Yeah, so um with that, do we have any other discussion items folks wanted to bring up that didn't get added before we started the.

A

Meeting, if not, I have one.

A

um I see fong is on the call, and I wanted to bring up, uh there's an action item um for investigating uh this proposal to enhance item selection um from last week, and uh I realized this might be complicated.

E

So I I'm just wondering.

A

What the status of this is.

E

Hello, sorry for the background, noise, uh yeah, look! What happened! Yeah.

B

E

To my team about what task we have performed on that to verify some of the items that being suggested and.

C

E

uh Gave the feedback that the um we have tried to use the exclude resources um yeah that that one? We have tried to do that and it didn't work for us, because it's also exclude the pvc that we want, and that is not an option and we also try the idea of include resources and that doesn't work either, because if we do the including resort without um setting the cluster resource black, then it will not work. It will not back up any of the cluster resource.

E

So we for the action item I haven't have chance to work on it yet because of other higher priority. My work, so that's when I still. uh I still owe it to your guy.

A

Any other discussion topics that folks might want to bring up.

F

Can I ask a quick question about um something that I started working on?

F

um I don't know if this is uh the the right form to discuss this, but I just um so I've been working on issue 1780, which is to add additional printer columns for the valero crds um just to try um and replicate some of the information that you get from the valero cli whenever requesting information about um the different objects that you have um so one thing I've noticed is that for the additional printer columns you're supposed to extract information about the object, I use jsonpath in the valero cli, there's processing of some of the the data that happens as it's being printed, which can't be replicated um with the json path syntax.

F

um So I was just wondering for for things like that, should we just opt to exclude them or try best effort? um I don't know. Maybe this is quite trivial question to bring up at this forum, but uh I figured I'd. Ask well. I've got folks here.

C

So I wanted to see if we want to hold off on this until we get uh all our crds migrated to cube builder, because with cube builder, it is easy to add printer columns. I think cardesia added the a new column for the backup, storage location and it was as simple as adding an annotation. I suppose.

F

Yeah yeah, so I that's what I'm currently that's the approach that I've started doing with some of the the existing ones which have already been migrated to builder and which is.

C

F

Annotation, but it's just if you want to do anything more complex other than just extracting a single piece of data, so, for example, um so I mentioned the expires column which we have in the letter get backups. um It will do some calculations and then formatted into a human readable format. So if um the status dot expiration field isn't set, it will fall back to calculating it based on the ttl duration plus the creation timestamp.

F

I think, um and just things like that you can't really do with jsonpath syntax, which is what you need to use in the cubebuilder annotation. I can answer that because.

D

I looked into that.

F

D

I was, I saw your question that I was going to answer, but I wanted to look closely if this is not a duration that, uh because some columns, the the api server calculates- and just if this is a calculation, that's happening on the valero side, you're right, you won't be able to display it, and it's fine. If, if cube builder, uh not your builder, if q ctl doesn't display all the columns that we display, it's fine one way to get around that.

D

If we really wanted to display that value would be to to add a web hooks. So when that is, that's crg when that resource is created, the web hook would calculate that and inject that in that fields on the on the kubernetes side of things. But if we, unless we, if we don't do that, then there is no way you are you perceived it correctly.

F

Okay, cool um yeah; no, that's good to know just because this is my first time working on this uh particular area, this type of stuff. So I wasn't sure if there was just something that I was just flat out missing, um but no it's really good information. Thank you, carlesia, so I'll just submit anything um which isn't which we can't replicate.

F

Yeah awesome. Thank.

A

You yeah, I think this is a, and I think this is a fine form for asking these kind of questions so.

F

Good to know, thank you.

E

I also have a good feedback on the valero 5.1.0 beta.

C

E

Download the container image and try it out with my.

C

E

D

E

D

E

D

E

D

E

Pretty good uh when I.

B

E

Try to um view it with my goal.

B

E

Hit the problem I was talking to nolan earlier on.

E

Other problems, I think I will continue working with nolan on slack on to fix those problems, but I I anticipate that other people might end up having that same problem is in my boat, I'm using, uh I have a crd and I usually run food generator to generate the cli, for I mean the the many of the hope for that cr, and uh I mean crd.

C

And then, when I do that.

E

With previous version, I do not have any problem, but when I switch to.

C

E

C

Anticipate that I would hit the same problem.

E

With the 5.1.02 that it, it is saying that the exact error is not enough argument.

E

And the client is the rest client. So it looks like the do function that the version that being generated in my code do not have any parameter.

E

C

E

Expected it has.

C

In the context.

E

In the new function of the last client, so I will put that detail in the bug that.

C

E

And I are chatting, but I just want to say it here so that in case someone else may also have the same problem.

A

This yeah this may justify an issue.

A

I'm not exactly sure what you're trying trying to do, um because I'd like to see the commander running, um I thought you were simply trying to build something with the go modules not generating custom resources, you're, generating custom resources that may have some consequences. Based on our switch to cube builder um yeah, I see the error in zoom chat. Let's, let's put that in an issue because that'll be easier to debug than in zoom chat.

E

Yeah yeah, I I think we can continue on the continue to talk about it now. Slam conversation, but I want to bring it so that people might have the same problem.

C

So this is this: is an issue upgrade with upgrading to the 1.18.4 uh client, so I I can help you with this phone. If you want to link me to your code, I can uh try to help you fix this. Thank you very much. Thank you.

A

Yeah that context argument is um so one of the big things with moving to kubernetes uh kubernetes version. 1.18 was all of the why all of the client libraries added a context argument to the beginning or if they had no arguments, they gained a context argument.

A

So um they the signatures, changed on a lot of functions, so um I'm guessing uh the the do um or the client.get. I don't know looking at this, I'm not sure, but um my guess is there's a context that you need to pass in somewhere. That just needs to be.

A

A

Yeah, that's, uh that is a question that will probably come up again as people as people upgrade their dependent code, so we'll probably need to get some documentation out for that.

C

Yep, I I will work with to figure out what the resolution is and once we have that we can have that documented. Exactly. Thank you.

E

Yes, I will be a happy guinea pig.

C

C

C

A

Okay, if not we'll, go ahead and move on to the contributor shoutouts.

A

First, we've got a couple that fixed some issues we found in moving to hugo on the website, so uh abby here on our docs team um added some index files for api types folder, so that uh these will be found through the table of contents.

A

So thank you abby for surfacing those and uh also ipochi or imran koji added some missing front matter metadata to the resource filtering document so that that will properly render. Thank you.

A

As part of the json logging formatting with, um I believe this was with elasticsearch yeah, I believe yeah benoit um found and fixed some logging issues with classic search. So thank you very much. Benoit.

A

And then finally, um genting fixed some documentation with the feature flag for enabling csi the documentation said it supported more than it did so. uh Thank you, genting for correcting that and um thank you to everyone. Who's been reporting issues, uh computer fixes and things like that. So uh one last call for any anything else. That folks would like to discuss on this.

A

A

All right, then, we'll give you all a half hour back thanks everyone for coming and we'll see you all next week.

C

Bye bye, everyone.

E