.Net Foundation Design Reviews, 27 Feb 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: .NET Design Reviews GitHub Triage

Description

00:00:00 - Approved: [API Change] Drop `IMemoryList` and replace with abstract `ReadOnlySequenceSegment` https://github.com/dotnet/corefx/issues/27500
00:16:25 - Approved: Add GetPosition overload to ReadOnlySequence that only takes an int/long https://github.com/dotnet/corefx/issues/27403#issuecomment-368977923
00:21:28 - Approved: [API change] Move Memory.TryGetXxx Extensions to MemoryMarshal.TryGetXxx https://github.com/dotnet/corefx/issues/27451#issuecomment-368979558
00:28:35 - Approved: Change new QueueUserWorkItem method to use `TState` https://github.com/dotnet/corefx/issues/27464
00:29:30 - Approved: Expose Thread.GetCurrentProcessorId() as a public API https://github.com/dotnet/corefx/issues/16767#issuecomment-368983869
00:40:36 - Approved: SocketsHttpHandler: Consider exposing setting for maximum response drain size https://github.com/dotnet/corefx/issues/27329
01:47:22 - Approved: New APIs in SyndicationFeedFormatter https://github.com/dotnet/corefx/issues/24668#issuecomment-369004374

A

B

A

Alright, so let's do some, but it is a it looked at all the reviews that are marked as two one. So if yours is not on here, it might be because but I suggest we walk them in some parity order, which we probably make up as we go. But is there anything that is super important that you should look at first from these things here the first thing yeah.

C

D

Be biased, yes, number.

E

Well, you asked a question. The answer was.

F

A charge under.

E

Syndication so.

F

Father I never proposed that I read memory. This was.

C

An interfering implementation, you have an interface yeah.

F

It's not that I pushed for it. It was an accident.

C

F

Yes, but then we decided that one of the API reviews to not do it, because basically we would have I eat only memory too.

C

If you're fine with it so.

A

Let's just do the syndication one first, because I think nobody here really cares much so.

E

Let's actually just.

A

Approve the day, sir, if nobody comes no, no is it like telly, we did it for read, I. Think there was something I mean this this one and.

A

What was this doesn't mean.

G

Again, like doing.

H

The audio that it.

A

Alright, so I think last time, maybe you today had this shape here and then we said constructive generics, three strings and nobody knows with these things. They should just make it a named one: that's what they did.

A

Yeah I think normal funks work when the arguments office, but to take string string string so.

I

A

G

A

Your second I don't know what taps.

C

Are fine, there's? No, no, no curves to be your client. So what this.

A

Is ability to be game? You should.

F

Type all the parameters as objects- and it was.

C

Dictionary dictionary strings.

F

C

Almost as performant and.

F

We could reuse it, so the only thing I'm thinking is so it says in the syndication namespace. Is there delegate more generic, like user parser, URI, parser, delegate, I.

A

Mean my only ship, it will be able to name indelicate but like besides from that I think it's specific collection now.

F

Okay, then, but yeah I mean definition is about parsing XML. The name is pretty generic parisa long rabbit, it's fine and you write it shouldn't be called delegate should be strictly delegates, a fixity control back.

J

F

To our Navy diamonds, no comma, something like this holding! Oh, you are a parser Kohlberg finance. Your eye partner doesn't picture. We're gonna have a right parser. That is not gonna, be a directive. In this indication.

F

Have you ever tried to use components where there are types of the same name, different namespaces, yeah,.

A

But how often the ever using for syndication to begin I see you never use syndication like once in my life I know, I think it's very narrow, narrow. It's not like I think it's really bad when the databases are only important but like.

A

K

Well, you have a delegate first thing: you want to parse what this is grown totally add that.

A

They want to add looks for professional the problem that they have is they're. Only there I can forgot the exact scenario, but effectively will end. Is that as it is, things are not super well defined and so yeah? They basically have like a default hunting for daytime, but there are some things that have some whacky parsing rules and they're like well, here's the callback that you can supply and like apparently, the rest and Adam or whatever the thing is implemented.

L

A

In strictly look like fixed, so I, don't think I mean I. Think the ask the same question like we and eventually hunt up like 20 delegates, and they said no so I think I.

A

Don't understand why we did we just strip the suffix.

B

Names of common types, if you derive from system delegate, add either event handler or callback depending on whether or not your event handler even.

E

G

B

What year was that written that.

G

B

1772 I, don't know why they put the call out.

D

B

Do not add the suffix delegate to a delegate.

G

Thank you very much like MLA, exactly I taught this.

K

G

Wrote did not Christopher in that book this way and if he doesn't.

F

Make any sense of the guidelines? I just wrote them down, and some of them I thought. You know.

J

The changes were, writing things out. They they for some kind of problems.

F

I was four: if I was writing six, if I was not just writing down the conventions that already existed about delegates I, the guideline would be don't use. Delegates is fun.

K

Always prefer fun, I didn't have a mean, update, look the participant data original team, app awesome.

M

F

M

Wanna, do it seriously.

F

Yeah, which is ridiculous for royalty, because the publisher has been asking me for a very long time for.

B

F

Should accept it's so labor-intensive that I'm looking somebody to help you it alderman is not a person.

E

F

Workaholic so like it's actually a good match with me: lazy person, work colleague, baby.

N

Christophe, if you ever do that, I'm willing to help you too nice.

K

Do not name your method, ASIC do.

K

D

Make everything they say doing anything.

O

M

Then we have done.

O

That what about a name of the argument, the URI capital who you are I, that's tough! Is it ok thanks? You alright.

P

Usually we write the our Lord.

Q

P

Again, but I'm not pushing I'm just asking was the guidance, the delegate that is now calling all back or this one yeah. We should.

R

All right, it's a night shift.

Q

S

A

I'm one holding it is it's not going well ain't. This used to Berg laughs, weakly.

E

Okay, you break No.

F

All right the title of this work, this issue is a bit confusing. It basically should say change. I memory list, we're abstract class. Well,.

K

Place concrete members hundred members and the care points in it in level, so there's no virtual calls.

C

Apparently Radames I mean.

K

Written a sequence.

C

Eggman is what it is.

K

K

There's one today I'm the one test: one test: yeah in pipes: we have a buffer segment. That is a segment of the big list in the pipe itself. So that is the only incident. I think that's real.

C

Basically, if you want to provide a source of multi, segmented, redundant sequences, you have to implement it, and the only thing that that's provided right now is five points. That's where his lab might have some as.

K

Well, but nothing.

C

K

C

That we brought over it.

K

C

Being an abstraction, it's just a poker that forces you to inherit from it yeah and said, feel it from it to be able to to.

F

Be able to start some context in.

C

Like this, if you inherit from it and make everything public it'll just get over our faces, you don't have to add more things. You're, not anything. Yeah.

F

So this buoy, so actually don't think that we need to add additional data. Why don't we make it a struct and then you can store it in like a bunch of those in an.

C

Exponent and then it gets boxed extract, cannot be recursive and that also hurts well.

F

It would have to like yeah I guess it would have to make an index of the next one. Yeah.

C

Taking this will drop away, leave your abstractions and even even ideas of things might not do interests yeah. We say that it's only increased, you cannot implement it on the array. I mean you can't put things into a right, but you still have to have a kid and open a little religion which it is right now we just we were trying to lie to ourselves.

C

F

Is remaking it? It basically means that tree down the sequence, can either support where a on memory on memory or when, ladies things or string yeah.

K

F

K

Work nothing else if.

F

We ever want to add more in the future. It basically would have some performance cost some some.

C

Some some some other real, like margins on memory into one one, one: building and TriCaster yeah for stream and the.

T

Green added, like example, where Ben was changing this over to use their API. Why does the drive type at the store next, if the basis story? Next, not just an optimization, you brought up store the field twice, to avoid a cast or something. Oh.

C

Oh because yep, because it stores the exact implementation to where the best you read yeah, when you walk segments, you don't want to cast next to it to yourself every time. So you store typed next segment, reference and I.

T

Q

All have setters.

T

Rather than just being constructor arguments, because we expect these to be cooled and reused or something yeah.

F

Yes, I, can you know I said it in the commenting I think we kind of I called it front-end design we kind of ended up in the middle. It's neither fast either flexible and I. Think this one has some negatives. It constrains what read-only sequence can represent.

B

F

At least it goes all the way to.

C

About your idea about your son and the one I.

C

F

Could still do this with this one great idea: yeah it cuz, it's completely independent.

K

So the the secrets would have to know when to call a method versus just give it and use the actual.

K

He went over to a calls in the fast path, so.

J

You could think.

K

Cheat and say like if this thing wasn't written then used next and skip the skip the call, if type equals on something crazy yeah. We do.

C

C

Even without still.

F

In the random axis is not this fast, no.

U

M

So I would still try and when they do measurements on.

K

That guys there is again benchmark and he didn't. He didn't show that there is compressor his bench more, but I think he got it wasn't 2x. It was like one point or 6x Florida yeah, then the original thing yeah.

F

It's getting to a reasonable place, but it would be so nice if basically random access into adonys sequence was oh one.

C

Because, if way, if it's only imagine you have to give your bed box like the guy a lot of data, you have large segments. If you have large segments, you don't have a lot of them and then mercial cool versus, like seven traverses of the pointer.

C

F

I would say through our call, is you know more expensive, but not seven.

B

E

F

Of for any of memory, that is very far away and not be that hard. You.

K

Are still doing yes, it's fine, so maybe in the future we either out of this class, or we had an interface that this think limit. That's someone downcast and it says, if you can seek, then I can throw.

C

C

No, it's like we are storing beats to avoid cuts. I thought adding another I.

F

Would say, let's go with this one and let's kind of try to do this- seek on top.

Q

F

What we cannot do it it's too bad, but I would not give it up because, honestly, when you have two gigs also, you know segments of two gigs they maybe even like page it out. Yes, so you know having to traverse all of them. So you can get to the you know, tenth one with the Supercross reaction.

C

Memory is separate from this, so.

F

You you would on each other Steve. Oh.

C

I

Yeah, maybe it.

F

F

A separate this is about the second separate biagas offense, which.

K

F

This will defect it. What so, this is good. What.

K

About New, River, I presume it's against or name it's super nice because it's actually like it says what it is. No wise.

K

E

Recommenced wait. Oh, he was fighting with himself, not gonna shut over here, pushing back. He did her hands.

F

E

His own proposal, good to Laban.

P

So how far are we with the Hopis parts? Are we ready? Is it? Is it the API surface? Final final at this one final final, as we can do.

K

In creatives in the framework, there's just one more big change, which is the value task by available yeah. That I saw there's that one and then that's kind of biggest one.

P

Yeah I mean there's: now we talked about like implementing something on top that we will see and that stuff, which makes me help it internal. So this is transparent to the the.

K

Last one is that we just did was public the.

P

K

Transparent to these pipelines yeah, it's a bass, bass, fishing. There is nothing or not yeah, so.

A

Like this related to this, one and I just talked about no.

G

A

Yeah, like it seems closer than the other one.

K

Since definitely one that had like a lot push back because order, the ordering of routers.

E

V

K

What usually wins in these arguments, like okay,.

F

So system may be more scroll down scroll scroll down.

C

F

No, no up a bit up, but there's like an API proposal. Okay, here, I I did a comment, so we want to add an overload, get position that takes just an int. You know yes get right, just an it. Today we have overload the takes int and a position.

F

Sequence start is a position, but the parameters in this overload are actually reversed. Today they are different than what the sample shots. The position is first and then they end. So I was basically saying that if we add an int overload, they should be in order like int is always first and then position is optional. A little much string that.

K

Seeks, let's expand that's what the argument was, but then the argument against it was it's rare to have an API where you want to add to a offset, and the offset is loop is first except for stream. That.

B

Seek where he islet how much to seek, and then say from the beginning, from the correct position or so yeah. This is exactly stream that seek better. What's the office or what's the basis should come? Second, maybe or we could make it well I'm like see. That's.

P

B

Matching Christoph's this the over abilities. It should be first and stream that seek says that it should be first yeah. English says it says it should be the other way, but English never wins in these arguments. I.

K

Think I think it's fine I'd have a push back, I, think Stefan's argument he's he's skiing summer, and it's no better yeah was that the stream itself has an enum where to start from the origin and wherever this is more like an integer and this operation is, is offset plus plus like well bunch of us offset yeah.

W

K

W

C

K

C

U

K

Officer argument: you do pasta, man, you don't pass, tart isn't start, isn't like it's not extreme. As then you're saying start from the origin is more like I'm passing a number and I wanted to add the offset to that number. But the.

U

Tattaglia, the.

K

Position is either pointer so.

F

That the type is the art.

A

Is actually not any new material? Is it when it's? What I.

F

A

F

No, but what it is it's actually, the type of this sequence start is sequence position. Yes, nobody knows whether it's an enum or like it looks like Anita, it's a pointer. Let's.

C

Not spend a lot of time, yeah.

K

I mean I think it's fine just know the person who's much cuter diamond here said it's fine. We've.

C

Been uh fighting it we've been so.

F

His brain has too much oxygen, yeah.

C

If you Chi enough, maybe not.

E

He's good for watches, go I hate, it I think it looks desk easy to.

F

C

E

His brain doesn't have rust.

C

Here he wasn't hurt no this year, his neo driving Utah. What.

A

I can edit it that's.

F

A

F

I used to go to Colorado and like for the first few days, I had like headaches, my nose would bleed and from skiing at 10,000 feet. We.

R

K

Leave comments on the YouTube TV. What can you do.

C

And result is the printer monic shredding.

H

A

I, like it we're getting some very easy man.

Q

Should ship off and they would force the right things to happen. um Yes,.

P

A

Is some venture we just eject based on principle view if we gave them one or we take one.

F

Yeah, so this one I read this one. So basically, when you have read-only memory it's over a string, it represents potentially a segment like subset of the string characters. But when you, when you coach, ikat string, it gives you the whole string and then it tells you, it also gives you two integers and tells you like. Please don't look at anything outside of the range that you know. I gave you same with array. Segment array segment is not super safe. It gives you you.

B

F

Subset of an array, but you have access to the whole array if you really want so today the api's are on memory. Extensions and Ben's argument is because the API is break yeah, encapsulation, yeah.

K

F

Information hiding, which one.

K

Is it about you break it out, yeah.

A

I would say our fault so.

F

He's saying like they should be a memory function. I would say that I'm not sure. If that's what memory marshal is for memory marshal is for unsafe operations. It.

A

Kind of marshal between- let's say you ever read, only span of chart and you get back a span of charge. The same thing you're not supposed to write to this. Now you get back to that, you can write, are not supposed.

F

A

Read from things are not supposed to event.

F

Well, you're not well. This was.

C

Right yeah this one.

F

Is about reading only it doesn't give you access from read only to read right, but.

K

It does give you the string, the higher strength, yeah.

X

So, let's you, this is out of bounds. Yeah.

Y

C

To make sense on memory, mushroom, yeah, yeah I mean just groups. Methods like I want to get something from memory. That's very girly. How often do you have to do that? Anything except this you're.

A

Interrupting exactly.

J

The marginal density, probably something that I'm fine, isn't fighting for well, I shouldn't, say if you rock in the sense like typical, be invoking.

Z

Fine fine, we will reject next to Ben's. It accounts I.

AA

Have one question II know my copy mom.

T

So for tracking array, it's a memory called read-only memory, but.

B

It isn't the memory very sorry, isn't the read-only memory, oh yeah,.

F

Yeah, the name of the parameter is strong.

B

F

And paste error the a variety and the second.

AB

For younger no I'm not sure we all smoke that we're doing memory, Marshall media, that.

F

One is probably already there, because that one is kind of unsafe.

K

For a super confusing than what the over those entire whoa like push it beyond memory or memory right, let's not say.

B

You see your rights more of them, so.

C

T

B

A ready as of emails last import is a number on memory. It's not an extension. Yes,.

K

For memory, but for really I think it you have to call it more I'm, not regular it. We.

F

Do you know the one that gives you from read-only memory.

T

We are, we already have striking array for on memory, marshals, read-only memory and there's a.

B

T

Memory to read only memory do we need the second owner. We just get radiance obsessive, yeah.

F

That's actually a good point too, since it's not an extension metals, we don't have the issue with having to have the exact type, so this one is covered by what we haven't. We basically have this method that takes read-only memory, so the first parameter memory.

B

Marshall has try get array of T that takes a read-only memory. That's all.

C

F

T

K

K

There was a thing about converting from a rated spot is not very fast cogent by I.

F

Mean it's all degrees correct. It depends how fast what you mean by fast, but anyway,.

K

H

No II was like I think the.

A

Reason that moves it is because this one exists on memory right now. If you just kill this one, yeah yeah.

B

So, are we getting rid of it? Yes,.

F

C

Will break that is the 30 sec sheet. That leaves us.

F

I mean: isn't this the core of the proposal? Will you do.

B

B

I'm, just making sure that.

G

F

Know you cannot get yeah, we were trying to imply to implement to strength to be just the.

B

Little trains and you.

F

Cannot stan is a black hole there in Spanish the black hole.

F

X

F

Constructor is the event horizon.

A

Yeah, that was him I guess. That's me like I, just.

F

So awesome, since some of these changes cross Reaper boundaries, you should kind of scream if you think that any of these are longer than like. You know a couple of hours of work. Everything.

AB

That you know so scream you.

F

Know I wonder whether a better way not to do those is to first like add new api's move the whole world to the new API and then remove the old ones. Then you don't have to deal with the you know the world being broke. It.

A

Is long about that were collected for, like tactical stuff, do a bit ik anything else, otherwise, just over then move on. Yes,.

F

A

Let's do this actually have a chance walk into this all right. So now this one was one of these more contentious issues. Right so like we can easily promote remaining.

Y

Our is anything else we need to look at first, that so two seven three to nine should be very fast.

T

Okay, so we already added a new API and two one and I'm just suggesting we change the signature, just something else. We added the top thing like a few months ago. That's using the same delegate so that fool you, this person, other user work item and taking an object, but it'd be much more general applicable and less allocating. If we instead just took a generic delegate and a generic state see nobody disagrees with that.

C

So that's just super.

W

G

C

G

You yeah I'm, trying really hard to come up with a.

G

Consistency, it's been said.

A

I think the last one was also easy.

A

K

G

Yes, two point: one: is this the magic nice? So it segments point your thing: yes, yeah get we'd only spent from template, yeah.

W

G

Does the API stutter okay.

F

All right, how would we implement this feature? The API is simple and is probably like also a rubber stamp. How.

E

Do you implement this mean for blurs in general, internal yeah.

K

F

K

I, don't think it works for it.

F

So how would it work, oh.

A

I know how our brain works, but it's fully my thankful I would.

L

Guess it would be not correct.

C

For me, is it really do we? We.

F

Already have surface area for a net net crap only yeah.

AA

AC

Surface area yet again.

F

Cuz, you know like this method would basically not be implementable as a portable API.

K

Carolee call it Mary.

C

If you happen to.

K

Get a copy right yeah. So how would it detect it aren't any API agency.

J

I know for the library that.

C

Has to meet either call or the thing is no I think the idea is, if you have, if.

J

You, if you come to see that see ya, know.

C

Me works I, just I'm not used to this working based on the DFM I'm, not.

K

Like you know, you.

C

Get an API and we.

K

Add that thing that the compiler can detect runtime features specifically for this, but this is Napier I guess.

F

So who's gonna, implement it yeah and bloody, mean or Yan Yan I was guessing well.

A

I think what he is saying is that is like the compiler will call this thing. Yeah.

F

A

You write it literal, so they're.

F

Willing to do that work, yeah well,.

A

F

Are willing to do the work in the compiler who's.

A

Gonna add this.

F

M

B

Unpromising I mean I would be like as far as this room is concerned. It's just like is this the right API for the compiler to call and whether or not Yan or someone.

F

B

It like tomorrow, for them, is yeah.

F

Young added some comments: I didn't person completely. Oh.

W

F

A

Positive, let's.

Z

A

U

A

U

E

B

Is it should be able to write it to the data segment and then just write? A pointer based span pointing it like this.

A

I read this today: I realize that same thing, right, yeah, there's some I'll go with the area Exodus, but the day is some things that the compiler in its initialize.

Q

A

M

Right if we this feature, is so awesome, yeah two point one: we can do it so, let's chase it up, I.

F

Don't know this one is so we'll see it seems, email Carol. How should we think about these API changes versus schedule when we're getting it to go forever? We just like epi.

AB

Is correct, whoever.

F

Does the work in two point on it's up to up to the person cool.

M

Okay, okay, so next.

A

One this one I think, is something that Iran also proposed. We should be doing oh.

Q

I think there was an API ship on the air yeah that wasn't one of those things that by the time you call it. You don't know that it's the right answer. You don't.

D

We have an ad like this. No.

E

F

Cameras use, what is the difference? Do you mean.

E

F

In this we already have something like processor counts, or some number.

K

B

Which? Processor.

F

B

Morning on now, oh it's isalean.

F

B

The question and if you don't.

T

We he'll be the next line of code.

B

You might be on a different process: yeah yeah.

T

I mean it's: it's generally is that we use it internally, just as a best guest, for example, if we have a partitioned data structure and we're trying to kind of minimize contention well, we have an internal implementation of this that we call and we use it to determine which partition to go to it, doesn't matter if we hop into poppin processors. Afterwards, it's just sort of best guess.

B

If there's a consistent notion of a processor identifier being an integer across the platforms, we care about who.

F

Cares, but what so, why is it on environment.

F

A

Count is there amenities, they're, just letters we.

C

A

Don't tell me, we have thread.

C

Where we can put threaded processor that we could put programs or things.

F

J

Which they can't thread this yes, but the thing is the change like between this time for the methods actually.

J

Yeah, it's employed. You don't want to have unstable well,.

F

But Steve was saying.

J

It's kind of like just an.

F

Optimization like, if you happen to be lucky and the in doesn't change, it works better. Otherwise, it you know too bad. It takes Empire. Oh yeah,.

K

Yeah I think it should be called approximate. It should be on call.

F

Approximate yeah.

J

F

Isn't it on thread like you know, carrying current process or ID so thread, let's first analyze.

S

What the API is, because there's.

F

S

Meditation are parsing it current.

B

Interest, your processor, can you ask what processor and other threads probably not should be instance or static is, can you can you ask about another thread or if you have to get reduced heat all that process.

C

K

These got close and reopen like 50 times laughter.

K

G

K

With comments I commented, it she'll be an environment, nothing. Sir.

K

You've over it right cool, so this link bugs.

A

So see when you follow this closer like. Is it fair to say that we don't have all right? Here's, the final I guess is, that is that will be all of us. The right thing should be a thread should.

P

Be neck ignoring.

A

This particular thing, I think this is mostly about like what what do we actually expose, rather than.

G

B

A property instead of a better.

R

You know you still, there.

AA

T

Because you were commenting on anything as a static property, I think it's time to.

B

Meet the property feels more like it would never change, but a static method. I feel like it's giving the sense of like being more. Do.

I

L

B

When this program to.

A

B

Poverty is more consistent already have we have heard.

A

B

Don't have a thing that gives you an answer by the time it gives it to you. It's wrong. Yeah can change.

T

F

I think I think both of these changes actually make the make it clearer what happens with the idea I like moving it to thread and making it into a metal I think it communicates a bit better that it's not like a priority of this thread. You know like the thread is not Affinia ties to the processor, which somebody may think it is when it's.

Q

B

F

B

Like it I like it, there's a method prefix with get better than a property, so.

K

You agree with me: I guess, top rule, seven, oh six or three don't make it spin down well.

B

I know the somewhere we do have the rule of like you should use it when you need to convey like.

F

Differences, so you still for rotate yeah, you call it in a loop and it keeps returning different values. That's a weird property yeah. Is it yeah? If you didn't, like you know, if you don't change anything in the system, it changes for you, yep.

K

A thread thread and method make a count of something yet.

F

Processor ID to.

E

Processors have IDs, or they have numbers, get passer ID. A mobile number sets thing. They talk to y'all. You.

G

Get the gist are we doing it? Yeah right, they're,.

B

Calling the number twice in succession and produce different results so.

K

X

Knew the vegan.

G

Will see sharp I got sure.

C

What our rules on betting means to everything in Kramer to all public repair at all new public affairs that take slightly larger threats, I think.

E

C

F

We had a discussion about this on you.

K

F

K

F

This, oh, is that.

K

F

K

Trucks will do it for big 104, like really big ones. Don't ya.

M

C

Sequence, its small.

M

Before, in that's.

C

M

On convenient but in.

C

M

C

F

We're on there on the PR when we had the discussion. Basically, Steve commented that there is a negative of adding in the callers, now have to call it within and like it's weird.

B

F

Better to fix it in the jet then make API suboptimal public ones. Now, having said that, I I kind of think that there's a limit to it like at some point jet will just say no and if the API is not usability oriented, then I think it's fine.

H

Yeah, you know oh really,.

C

F

Should discuss it with Steve is.

C

K

The signature Lee use.

H

K

T

Beyonds comment was that it makes it actually perform worse on certain architectures, specifically.

K

But for bigger, struts I think it for.

T

Bigger strums I'm I like that's. Why?

T

C

Bigger, let's define a bigger.

J

B

T

Only knew me remember.

J

Something more than like two rows order that would be weird: okay, yeah, so.

C

Redundant sequence is more than that: yeah.

AA

F

That really we would just use in for all starts. It's.

J

A bit bigger than.

F

J

I don't know it's.

J

B

Pretty sick as itself, but for this the bumper.

T

Is not right? That means basically any generic structure we have. We would pass around as begin.

F

That there's a hit in terms of usability, because now you have to you know the coal site is different. I'm hearing that the coal size doesn't have to use in.

K

9 C sharp F you're, passing it I guess if you cross language, if you're writing I all, why don't know such sharp doesn't have n? So, like oh you're, saying well.

F

When you're writing il someone.

C

To just pass it like general.

F

C

You're writing. I am passing.

F

It by in explicitly.

T

My concern wasn't really so much the call site. My concern was just we're, adding all this gunk to the method signature. So you go and look at the docs and it says- and you say, wait cause.

J

Cards, yes, it does.

B

Good, like I, saw.

K

F

If there's no usability.

C

Hit up the concept reduction.

F

C

There are problem that.

X

C

Cannot even invoke.

A

K

Yeah but everybody would add into everything new constructs yeah.

F

K

C

F

C

F

Have some ideas that are performance focused, yeah and I think we should add in okay for large trucks, because you shouldn't be using the reflection with performance.

K

Much larger than the ones in the Oval Office. No, no! You can't. We have to pass into some big announcements because they had interfere to our taste in a coordinate. I didn't present English. So.

A

That means you better, don't have the case where it performs better on one architecture, person that was.

Z

C

Why would it perform worse if it's the same thing, just less cooking, no use the end.

A

C

One is the point of the other one you possibly imagine.

A

That you know, if you put it on in a register, it might be faster than having a dereference somewhere right. That's a little bit harder. So.

J

The for example,.

J

Then would be faster to try register.

R

That being said, Oh, like you, said.

A

G

Right this one I think.

A

For some time so see me, you want to give us a rundown on where we are and what the issues that we still need to close on. Yeah.

T

So I have not heard any dissension to the core idea. So I'd like to just consider this a given now I'm going to check something in.

T

That something is a struct that's available that represents either you already have a value or successfully completed with a value, or it represents a task or tasks of tea or represents an interface that can be used to plug in your own, a sync operation behind it and use this when you've done, you have a new async API like streamed on read. Async you hand, one of these things back if it completes synchronously can just give you back one of these things wrapping the already available value.

T

If it completes asynchronously as an implementation detail, it could either wrap a task if it wanted to or if it was able to do some kind of pulling up the objects it could maintain its own pool of these interfaces, implementations and hand you back one of those which allows them to be reused.

T

The we already have something that is very close to this called value tasks. We only have the generic one, who would need a non-generic one as well. It represents two of those three things they could represent a tea or a task of tea. What I proposed was allowing it to represent the third. We introduced an interface in this case. I called an ID value task source.

T

We add a constructor to it that can take one of these, in addition to the constructors that take a tea in a task of tea and most of the functionality that's on it just works.

T

If all of the functionality just works, I just worked, I think this would be unconscious.

T

The contention comes from the fact that not everything that you can do with a value task to do. You would be able to do with every possible high-value task, source implementation in particular, because the very nature of these things is they can be pooled and reused.

T

You know today you're, given a value task. It's essentially immutable. You can await it any number of times you can hook up any number of continuations and whatnot, because tasks allows you to do all those things, because once the task completes, it's never going to become the incomplete again. But if this wraps something that can become incomplete again and could have been given out to somebody else, then if you try and for example, await this multiple times, you may actually be awaiting something that you no longer own on one side, the argument is well.

T

That's like the point, zero one percent case and let's just use the thing we already have and augmented and the other argument as well. We already shipped this thing and it's very closely tied with the semantics of tasks. So, let's add something else with a name that is more closely tied with just being in available, but has less guarantees and we can craft the surface area to be the minimal thing that we want and associated a bit from task. And so the question is really in my mind: dewey augment value tasks or do we add?

T

Basically, a copy and paste of it with a different name.

A

And that is something that is more. Like a judgment. Call people like you that know all the stuff works, but if it's literally like one one percent case, but you can observe behavior difference, I don't think it's worth it because effectively having come up with a new name. That is basically a task, but not quiet. You just increase the the content count. People have to wrap the head around and I. Think if we say look, it's basically a task, but it's a struct.

A

So there's some things are different because it's a start, I think the names close enough to be true. So like there's just by yeah, you meet the dog.

A

You know if the vast majority of our customer is able to write. Great, probably repeat this whole Matt. Yes,.

I

J

Least, the life change is still working. What.

V

You've never heard must.

J

Be the docks great.

A

So you almost have everything greater, don't have to know in the environment. um So then I think we are close to like just calling it video tasks and and say you know if there's more years, to figure out and if the docks as usual, because if the majority of the cool that.

Y

You ride doesn't observe the behavior difference seems fine now to be the the vast vast majority use case is.

T

You're calling us a a space call the method, you're calling an asynchronous one. You will wait asynchronous method and if you just do it as because one iterate has one you just there's one line or one statement or expression or others await through. There is zero, observable difference right. It's when you separate those and you you know, get a reference to it and you start calling things on the instance that you can start getting into trouble. And if you know, if you wait, whatever is the 99% case, then 0.9% case is well.

T

I actually do want to task, and so you called on ass tasks on it and then you party, to your heart's content on the tasks, and then it's that remaining. You know 0.1%, where you're doing fancy things that you need to be very careful.

I

So, what's the weights I just get the wrong way that we blow up.

C

A

It is tied to whatever machinery you, you hook it up to it sure that's an.

T

Arbitrary implementation.

T

Source that is effectively immutable for the extensive tasks and then there'd be no problem or you get multiple times or you could in. You could have an implementation where, as long as you haven't done anything to the the API that you've got it from it as long as you haven't called read again, it may be that the thing you got back is perfectly away double multiple times, and then there might be other implementations where it just you get somebody else's data, so.

F

It basically you either get the right result or stale data. There's no. Is there any other error condition besides they you.

T

Can you can screw somebody else yeah.

C

T

C

Like people throw in uncompleted sorry.

Y

C

Supports only one the combat, so if you try to completely you know, explode if people get away, they get results. It wouldn't work like for.

T

Example with those semantics you could cause somebody else, voila I.

F

See yeah, if you.

F

K

Y in pipelines is completed, cannot be called multiple times, because we don't want to support well for flush. It could work for reading mister. You read them. You advance.

F

T

You call this a very expected it's fairly expensive, to implement, because the implementation, if you considered something reusable the moment that get results, has been called for example, then you have to do reference counting to determine how many times uncompleted was called and use that to determine whether you know whether all the things that have hot signed up with you have completed. And if there's been a race between people calling uncompleted I.

F

See, basically, don't want to rise to result in incorrect value from is completed, because you could basically just like return. The last value that you create on about.

F

K

F

You probably have to series I'm, not in certain.

K

Is because, as task is the escape hatch, if all those are all your contacts and then also.

K

F

Well so this is, you know: III made a comments, kind of a suggestion to add a property to value task. Saying like am I special.

T

If you really wanted to, like you know a name appearing under the hood like we do with memory and whatnot, you know, we could add a like. Tell me about the implementation of this thing. Is it? Is it backed by a t, a task of T or an I value test source of T?

T

If you really wanted to do something based on that.

T

K

I think maybe I mean if you want to get your ass back here.

F

Well, I would say it's so you know like I would say. The only scenario that I could imagine is if you write some kind of Combinator's. So basically you write Combinator's to accept value tasks, and then you check, am I special okay, I feel special. Then let me give you the you know: pull out tasks there.

C

Are no if you're not special, then it's a stress all right. You have to get test anyway and then.

K

You can't not allocate so like if it is better than you got asked simile.

T

The only one that seems to be more value would be if the value task of tea was actually wrapping a tea rather than a task of tea or a it was wrapping a tea or a task of tea. You can cash the thing to your heart's content, because it's never gonna change. So it's only if it's the, if it is the as Krishna, says the special one that you might need to call as task.

T

If you call as task on a tap on that backs of tasks or backbite, ask there's no allocation its returns here with the original. You have to call it if it was the special one, but if it was a tea, we would actually end up allocating a task of tea to rapid, even though it was unnecessary.

K

hmm But you tossed mrsa blood, whether I get.

C

Sterilized they don't want to turn up. Will you toss it back down to the form of all the room can be used, yeah yeah, that you know either with what's inside or just return itself. I like.

F

C

I think it's good. It just is a better name.

K

We serious about that well,.

F

It avoids the problem that, basically, if you want it for free, if it's.

W

F

When you have tea inside it just returns the same value well,.

T

The other nice, the other nice thing about it, they picked the right name. Is it kind of conveys the very fact that such an API exists conveys the fact that if you don't call it, you can't trust that it's stable.

K

As the better world freeze.

C

V

Good keep finalized.

AD

So what would it do? It would basically do back to beta-test to this yeah brilliant.

T

If it was wrapping, a tea or a task of tea would returned this. If it was wrapping an eigenvalue type source, it would return a value test that wraps dot as task yeah.

Q

T

K

Stabilizing, oh, my god, stabilize no, it means deficient unstable by default. Your cover is stability.

B

Is not guaranteed ed.

G

A

I think talking like making multiples at work is over. This may be good enough because he basically based with what prison would convey said. If you don't do it, you don't get it and secondly, like it, kinda describes a bigger.

U

Move to your weight, it's my.

U

Snapshot all right, you want to snatch on the current state.

A

This means mostly about like, if I.

F

Cannot come up with a good name.

K

Where do you think.

K

Z

Not bad, which.

K

Is not bad anchors.

F

Basically, preserve means I wanted a value that I can start for sure.

K

Alright yeah, it's like it makes it storable, yeah and as preserved. Is that or just preserve, preserve, preserve a man for Ernest preserve preserves the name.

E

Green is my proxy. You have to beat that mother.

AA

F

Worried without crazy issues, no, no! This is not the only thing that will work. There are many other things. Steve has a list of like five things that don't work with the body tasks.

L

Give me give me promises so so Steve put on your p.m. of of.

B

Tpm library, do you like preserve sure why not preserve a.

B

F

C

Us to remove one preserve.

E

Well, because no method reserve was not doing this.

E

It was a retaining retaining.

T

So do we there's the three.

Y

T

Introducing a non-generic value task preserve on the non-generic dying task has no value, there's no benefit, because the only a default value task is a successfully completed operation with no result. There's no.

F

So I also noticed that you have get result on the none non-generic, so does that returns returns, void.

AA

F

Are the exceptions and I.

T

F

T

That's actually one, that's just on the value task of a I. Ask yourself: yeah.

F

J

F

When you look at the methods, it looks very weird what.

T

Result you know on this interface, we can name these things whatever we want, because the compiled this is directly available, so we can rename these to our hearts content. If you like, no.

K

They're so similar yeah, there's good in use by you TAS source on computers, like that, the use cache line contest is that, like the same context,.

T

So yeah, so you scheduling context is continued on captured context. It's the pool argument to configure wait. I didn't want to just call it continued on capture context.

T

When I call it use sync contract, sync well,.

K

T

Like when you wait a task, it's not just factoring in synchronization context, it's also factoring in the task scheduler and I thought, maybe in pipelines. You might also want to factor in the pipeline schedule. I, don't know how that works. It seems like there are potentially multiple sort of environments you might want to factor in.

K

Okay, so the implementation is supposed to capture the same context when what is said when.

T

You schedule in context is so uncompleted is called by value tasks. Api calls the interface that are completed and passes in these flags, and the implementation, if you scheduling context is set, is supposed to capture the current context and then, when the operation completes use that to invoke the continuation.

E

K

Have to be, there could be honest, I he'll, be in the pipe where we schedule the schedule on the same contact item well,.

K

Is computer is computer successful or the return title document cancellation or bolted, but done yet.

T

Yes, it is completed successfully. Is there it's not? Well, it actually is necessary to make the public API of solute s reasonable, but it's there, it's pretty common to say it as an optimization in various places. You might do something like you get back the value task and then, if the operation has autocomplete Nadi completed successfully, you just get the results. If it hasn't, you do a bunch of other work.

T

I have I, have omitted here, he's faulted and is cancelled, his faulted on value tasks, I've just implemented as not, but he is completed and not his completed successfully and I just had his cancelled returning false always for these things we could expose both his fault and his cancelled and I could make them work on on value tasks.

T

The reason I didn't was because if it does wrap an ID value test source, we effectively need to call its cancelled before we call get results to know whether the exception that emerges was for cancellation or not in order to determine in as task whether to fault or cancel to return tasks, which means that instead of two interface invocations, we've now got three. But we couldn't say well, that's the price you pay and we expose this cancelled, and you know we we maintain as good.

Y

Parity as possible, very occasionally may regret that choice, because the detail phase is when it's very hard for us to add them in the future. Well,.

T

We would regret it in a case where we actually wanted, where the we wanted to allow an implementation to have the tri-state of successful completion. Exceptional completion and cancel completion rather than just successful and exceptional task maintains such a distinction. I'm, not sure it was a good idea, but it does.

T

K

The result itself turn.

B

K

So pipelines hat is canceled, but on the teeth not on the a waiter itself, if we add it in to cancel I, don't know how.

F

You get it so, why don't we? Why don't we have a property, something like stauros and it reminds it basically returns. You're, not floods, but returns you just an either one of the bodies of the Nina yeah.

F

So you can you call it once and you get the students as opposed to coming to Colville to be like is complete. It's completely success right.

K

The task liked.

T

D

T

Sorry, you got out for a minute: are you saying, rather than he is completing it's complete successfully, have a status that returns like a value that source status you.

F

Know yeah exactly and then you know it allows us to expand it in the future and also it's one call to get the status as opposed to several calls. Yeah like that.

G

T

Think that's reasonable I'm thinking.

T

The thing is: it's bolted: are you really going to do anything other than cold get results? You know I'm trying to understand what you do with that information. Well, it's.

T

C, so someone can yeah the only one that actually seems like I've used. It is completed successfully because I want to say look. The common case is a success case that is already completed and I can get the value right now and not worry about exceptions or possibly the biggest reason to have is cancelled, as purely so that value test is cancelled, can work correctly because value task is the only like these interfaces are purely for the consumption in value test. No one should be consuming these things directly.

T

So the only reason to add those is so that value task surface area can remain, for you know functional okay, so you're saying we add the get status on I value task source, but for value task itself. We expose as completed as cancelled, something like we.

Q

Already do okay.

T

Oh no I know they're there I'm just saying we wouldn't expose a method on value test itself, correct.

T

Yeah I think that's reasonable.

T

We just need to figure out what that I guess. The enum would basically have four values in complete. Success, halted cancelled or something like that.

T

Hey guys so that.

C

T

Disappeared again, oh.

C

Yeah I think something happened.

X

E

B

B

Can you hear us yeah.

H

Do we exist? This might be.

Y

H

Y

Guys I have no idea what you lost heard me say.

A

Basically, the news when you were asking whether everybody was there, we kind of realized because we're you, but you couldn't hear us to be it's on mic issues. I got a question so.

K

Is it a contract violation that it is capital to set I get result, has to throw, or can it not throw.

T

It could not well say yes, that's interesting, because.

K

Here's what I want to do.

T

What do you want? The answer to be do I.

K

Want to be, it doesn't have to throw.

T

I, don't know that if it's explicitly documents anywhere that value test.

K

hmm Here, right here again when.

B

Would you want to not throw when it was canceled.

K

So my plant has as part of the tea result and it's castles like to avoid throwing click on I communicate state via, like the other, not giving.

T

Back a valid results of the result itself communicated something so isn't that actually success, yeah.

K

Okay, I get rid of the it's canceled. Unlike the reply, so I.

T

Don't know how like, if you wait, remember that if you're just awaiting this thing directly, which is the 99% case like and you didn't throw for cancellation and someone just assumed that the result was valid, seems like you got a whole bug. Farm yeah.

J

This is almost something that you could address herself via, like.

K

Today we do so it's today today. The result itself has the is castles lioness outside of the actual task, and it works fine, it's just not very all.

F

Right so I have one question so, as I said in the email, I think this makes our async model awesome. Amazing, it's basically, you know, we've been thinking for a very long time how we get from just having a task that is very heavy. We had it final task, it improve the situation, and this is the next step it makes it awesome. There's one flaw in this model: no there's almost no flaws, but this one you can only if you, if you have a type that has two async operations and they both returned an INT.

F

You cannot use this model, so I was thinking. Would it be now I'm kind of almost brainstorming? Would it be possible to add additional type parameter to this thing, from 1 to 2, to 3 to basic.

C

F

Be able to implement this interface multiple times on the ground is staying, ok on the same class, yes different.

K

Operations same result, Oh correct.

T

F

The whole point this this thing.

G

F

One object and it I don't have to have allocations for async operations, but it happen forces as long as the operations on this object. Different, I would Howard values has no, which interface.

T

Like no, which, how does that even work with generics.

K

F

If you, basically, we had their base interface and then the sub interface has two parameters to fancy to value tasks. You would have to cast it to the base interface and then the compiler would will not let you implement the base interface twice. Ics.

K

C

Okay, we cannot solve.

E

F

We cannot solve this problem. I would.

C

Gonna shoot like continuation source implementation, the lightweight thing now, Jeff.

T

Jeff was asking the same question. My difficulty here is I've now implemented a few of these and they're all subtly different I think we should at some point, but eh I, haven't I, think it would take some effort to figure out what the design for that thing actually looks like and be to actually make it as broadly usable, as we probably want it to be. I think I probably need to be a struct yeah.

AA

T

Like super dangerous needle stroke, but yeah and and I haven't actually figured out exactly what that would look like, but I don't have to be strict, because often you already have a different base class. You need to derive from like in network straight Arion. Sockets, rather I implement, receive and send a sink. On. Top of you know socket a sync event: args I have to whatever this interface is implemented on.

T

It has to be a socket async of that darks or I have to allocate something else, and if it's a sock in tasting event ARBs, then I can't derive from some other object. So I don't need to allocate this thing or it needs to be a struct. You.

C

Don't get books when you create an instance of we're interested in.

C

Like you still need to pass reference to something to where you test so you'll have to allocate the thing, no matter what I.

AA

Mean that object would.

K

Cut up to the drop yeah- that's definitely yeah yeah, of course course. What the.

A

Server connection is all fixed. Can you guys hear it.

I

I

C

You boss, nothing is, but when you create instance, of where your task I we're just source, this I.

T

T

C

If we decide to shoot the type that allows you, if we ship task completion source for whether you.

B

Have a strap that lives in the yeah.

C

Then you need to implement type on itself and then you have a stripe as you're going to be stretched yeah. You.

B

C

Passed through yep.

B

C

It's not entirely test completion sources, completion holders- yes, it's like yes, but I was thinking about my real thing. You create a new you. Are you kidding you that, but then it sockets yeah, but it's resettable. So if it's long leaf, multi operation, thing yeah, it's.

F

Like sequence, position by people.

T

These things being allocated- and you know counting on pooling to help eliminate like to allocations instead, one there are a bunch of situations, I think we're going to face where you might end up for certain operation. You might end up pooling just one and then, if you had additional operations kind of concurrent with that you allocate for those, and so you optimize for, like the one at a time case. That's what I do in channels now and that's what socket does it assumes?

T

You only have one of the time and it allows you to have multiple, but if you have multiple, it just allocates a throw away and I wouldn't want those to be extra expensive.

T

AC

Sense question on I that source we have gray desert but returns void. Today you can support one. Generic tasks will not have the result properly. Why is that I.

T

Want to have a result: property yeah, because.

C

That's not camera, so non-generic relative does not come result. I.

AC

Can't ask for further, though yeah.

C

J

Be the believed house is or I believe tasks.

J

K

Correct so then sword in towards keeping the value task or having it by available I vote for keeping value.

C

Task meter: that's over this new nice but sir, you can say, make sure you're, safe mm-hm.

F

Now cutting said that not I, don't know how we feel about maths not being here in the Roman I'm, making a decision without it I.

A

Would say I would I will talk to any person. I, don't see how that goes. I I think. The other thing is to me, like the most important thing is to have a list on action items of what we just said and what I have is. Basically three things like I. Have the the preserve method listed I have the discussion.

R

On the naming listed I just added and.

A

Then the last one was the cancellation thing. What you.

T

See, instead of his complete, anticipating successfully.

F

Yes, Oh Steve, one more sorry, one more question: how large is value task? What fields does it have to write sooner? One.

T

Value task of T has three fields: a T.

D

T

What a fight for sperm like so so.

AD

The issue is we.

T

Need to distinguish there are, there are two flags: I need to pass around for efficiency, and I've opted to do so by making value got slightly larger, and that is the waiters need to know whether there configured are not, for you know, continuing on the captured context and value task itself, now that it has an object field that can be multiple things. We either need to type test, or we need to have a bool.

T

That indicates whether it's a task or in this interface and I've, currently opted to to do that by having basically a pool value, so they don't have to type check and then I use on safe as to cast I see. So we could get.

B

T

Byte field it would make I have the type test and it would it wouldn't actually make config the configure to waiters already need that extra bool. Basically, so it wouldn't actually make those any smaller and those are the ones, is the waiters that end up getting stored in the async state machine. So from a heap allocation perspective, those are the more important ones and the extra thing doesn't really affect it. So the.

F

Reason so the reason I was asking is that another approach we could Explorer to around multiple operations of the same return type is if value tasks could store. Like a small int, let's say we had like four bits.

F

You could basically implement eight different asynchronous operations. Returning the same thing by like always passing this in back.

L

F

To the source, the source has.

L

To like switch on it and the source has to switch on it.

T

F

You will return it, you, you give it the value, you basically say: I'm operation number, one I am operation number two or I'm operation; number three instructure.

T

T

C

But it's awesome: if we have onion, we can make a cookie thing right. We can, if, like no cookie.

F

Is called the reason the cookies heart beat is because you don't want to cook together, all over cookie can roll over. So you need a lot of bits to make it.

T

Well, if you were gonna, do that, if you were going to throw the steps of having an integer that you passed the constructor and then that have that passed back to the interface I, think I would say that that ID, that value is opaque to value task and the interface can do with it. What it wants. The.

C

Same thing, you can just use it for to.

F

Know but the problem is that you basically I'm saying we don't have a lot of room in Burnet, a stone that not make it bigger. We already have a bite and you're using if I understand correctly two bits from the byte, so we have six bits left. That's only like well.

T

You have six bits, but I mean no matter where you use this thing like it's gonna get expanded so yeah. This is 32-bit. It's gonna get expanded to at least four bytes, and if it's 64 minutes or at least eight bytes,.

T

F

Z

F

Like if that years, you know three bytes.

C

F

But you know what Steve, what do you think about this? Just having a you know opaque number that we pass back and forth between Veritas and this sauce.

F

You would ignore it if you don't care.

C

In this, in this part of our stress teacher explained, and if we expose it right now, we're like after another party for this I just want to store another bit, give away six by six bits of this by the next time. We need to score another bit like Oh, more.

G

C

Need another bite well.

F

C

Miss Rogers.

M

AA

M

Use the six around for something a.

AA

Big it we can start.

T

And people think they would really like if our concerns about kind of the waiting again I mean a cookie, is the way to address that.

T

So, if you know passing an integer around or we could do it as a short or something.

T

F

Can add it later? We.

C

Can add another I.

A

Give me just open design point, because I really think we did. We have like 25 minutes left.

F

What about this? One Steve just thinks about this yeah like if it helps in safety and in addition, let's you implement them the inter pares interface, multiple times and may be sensitive. You have performance tests, I think what they worry about is performance, correct.

B

T

F

That it's almost 6 bits it's a bit weird.

T

C

So you're willing to expend the dreams. It's alright.

T

H

Be funny, though, right.

T

C

Yeah or anything else that's bigger like it doesn't have to be exactly ones I know, but.

F

When, okay, once.

C

You much bigger, then it.

F

Kind of yeah I think it only matters for byte which transitively it can be an indoor Needham enum, backed by a bite. All right are we going to give 30 bits or.

C

Just that's it 16 bits so.

C

What exactly matters.

J

C

J

Yes, some guys just.

J

C

Things around say: your company don't step in if I.

J

So the thing is: if you're, if you have, if you have, if you have a tea field and a fight, aren't they going to be in different registers anyway, even if the tea peel itself is just one bite, otherwise, looking up the value of each one's all this far, but.

C

Isn't isn't the chip going to what often you think that trucks would get to registers but often times they're in this tech space.

C

C

Inside would you allow taking in and like just limited size, because we need two bits of it or would you expose it as a bite? Well.

F

If we wanted to limit the size, we will just trim the two bits like give you an int but like high order. Bits are always here. I will have to to check in the constructor.

C

Adjust constructor, we have to check like taking oh yeah. It would throw if you said, yeah yeah.

F

Because we don't have a representation for 30 bits.

C

G

A

Just edit, this is like I need to close in the name early. This okay I want to do today, offline and then I think otherwise, very good with the design or anything.

AD

T

Do we want to eat yeah.

A

I think that's something that I would like give you as an exercise for the reader to actually come back. We know what it is, don't be already have it internally.

K

A

AD

T

You know you're, actually, that's the follow-up yeah.

A

And then your sister to do the remaining design issues is the enum and then the thing we just talked about every enum probably would be like a task state correct. This is rough. One is the other one right, I think that I think we were happy. The name is happy as we can be, but, like you know, make sure the actually works.

O

All right so then, can we go back to the syndication thinking via via the wrong thing or you can we do.

T

T

T

Hey you know, we can't hear you anymore.

M

A

K

A

Conference calls what about that doing it alright. So what's the final footballs that they have okay, go up up up.

AD

We'll see pipelines in every good mm-hmm, oh.

AD

P

Putting on the same form, really in the arch looks like something.

K

W

The core effects was.

W

A

Know they have like enormous. You know, oh.

F

Now it's a what inventors without events where they merit we're doing the.

K

Worst date, time, arts, arts, well I- think events need to over be CEO. Events, just like are bad all up yeah. We don't.

A

All right, so here's the thing that they proposed after I cleaned up some of the name qualification.

A

Delegate very poor the argument names for a second but like I, think the tryparse delegate makes sense, call back. You know the names of just the shape and then naming wise yeah. You should do this, we said earlier and they probably should call this I. Don't know not art I.

S

Don't know why is it be heartless? Oh.

C

We are hitting the type why not at the real type. Why are we trying to stick things into delegate when it's obviously a type of thing.

F

Oh, why why not you inherit and create your person.

B

Yeah sure interpreter.

F

Yeah, so we talked about this in the first review. They basically said: G is in a lot of cases. You just want like one line.

C

F

C

Really like icomparer most of the time you want that one that you can create, compare.

A

And find the arguments I just don't think I would call it arcs ya.

I

Wanna come argument. Sorry.

A

I

Be dividing me that arts, because it's kind of they own the arts, if you have otherwise it would just called it all.

U

K

Seppuku, no, they designed.

F

It struck the name of this truck and.

K

A time raw daytime, bra, you're.

J

K

Don't look at something a verb.

J

I

K

Is nice we call everything, context nice doing it yeah.

A

K

Date/Time context, it requires the context, the part it's just closed, prostate. Our sir context, lizard rather than call input, is parsing and.

K

I'm memory and friend through that entire bullet.

O

Hole name on the namespace URI are.

H

We gonna install this thing so.

A

Then we said birthday time should probably go.

F

Through I'm I'm thinking, the Strax shouldn't have parse prefix, the basically.

B

F

Date, I mean days xml day time, information or contact.

F

Yeah, it's not the context believe.

A

The data, but it means you would call it xml date time. What did you say info.

F

A

F

Oh yeah, I, don't know stuff stuff.

D

F

D

Doesn't kill nothing to do with piracy Aras no.

F

R

Q

An unreasonable.

R

A

Well, you know, even if you spend like five minutes on it,.

AB

Jesse sure.

X

O

X

O

A

Well, like doesn't.

O

D

A

Interest so I give up on that turn.

D

F

And there is also something about inputs, participate time be put on jeans like what happened here exactly should have been.

R

Just data and they should it be inverter. It's.

F

Just XML date/time data two-minute date.

A

Just call it time data, it's fine. It's fine.

D

A

With that, yes.

X

AC

A

Well, the Constructors internal and here directions, making them public.

F

Me anything so I go here using the constructor, constructor names and no doctor names. No.

A

That makes sense. Oh yeah, this happens when you call outside RIT. Friends like this is yuck.

F

It's every step of the game, a football editor here also: do we care about these things being immutable cuz? It would be so much.

X

Easier just for us yeah.

C

Right but then Koba can modify it, so no it can cause it's right. You got a copy, don't.

U

Like it combats that modify that in okay make it ends, let's make it in and make it read only. It is.

F

Only actually, it's passed by value, so you can, if you modify it, nothing is going to happen. Yeah.

C

But now we're saying make them in it's real, like wow I guess we can't.

F

Well, if we ever need to add more fields to it like having a constructor, we.

B

J

F

Parameters, complicated situation.

J

A

J

H

S

Well, the other questions: why did you make the class is going to be like do.

K

I destruct what.

H

K

The purpose- oh, let's.

H

Look things: okay: we can move on well.

A

A

R

Didn't know any of it totally.

A

Suck all right so 50 minutes.

AE

Left, let's do what was the one I wanted to do? Steve mentioned that there's an issue.

AE

W

W

All right so some.

U

Drain: sighs, okay,.

T

So you make an HTTP request, you get back a response and for one reason or another you stop, you don't consume the full response. This could be because you get what you need and you dispose it or it could be a redirect, and you know it's sending the response data and you just redirect that's not an issue unless you're pooling, if you're pooling you can only put that connection back into the pool when there's no more data coming in when it's done, and so, if there's still data left, you can do one of two things.

T

You can either throw the connection away or you can drain it.

T

Cheaper than throwing the connection and having to open a.

B

T

If it's a large amount of data, you probably just one throw the connection away, but the user should be in control of what small versus large is, and so, when HP handler, for example, exposes Mac's response, train size and we're suggesting we do the same on sockets HTTP handler base. That's it I do know how much there is that yeah.

T

We can read up until max responds train size and, if we haven't finished the current chunk or hit the final trunk, we poor.

C

Chunk, it's nothing. They did when.

K

I have a time I said of a size.

T

Yeah we talked about that. It's certainly something that could be added. You could have both I mean you can go by size or time. Time is more expensive, yeah run taught just because yet the you know measure, but it can certainly be added if it was an issue. We started with this just cuz when HP handler already has it and we were, are we already needed to basically have you know something hard-coded? So this is just a knob. Instead of a hard-coded value, we have not implemented any sort of time. Yet what.

C

Would you set it to if you, if, like for perfectly normal, they should be connection to the internet, so.

T

We need TP has a default of one megabyte, so that's what we chose I believe I have to see what lip curls is I, think it's somewhere around there as well, so we could just pick whatever default. We want I mean it's, it's an implementation. You know if he really controls the efficiency of the pool or impacts the efficiency of the pool. It's part of a security review. These.

P

These are these kinds of api is the whole implementation will be secure, a review, but this has been part of.

K

An HTTP handler, so I know I'm mostly asking me if these parties are are coming out of security reviews or if it is, it's.

T

Possible this has past. Certainly the mass response header length, yeah.

V

T

Of you have to know if you can violate the semantics of the response at some. You know at some limit. This isn't really violating any semantics. This is just whether we choose to pool it or not, and if we want to pull it, we and we have to know how much I don't really think this one's security per se. Okay, just suppose that the connection.

T

C

P

Be draining more different programs, surprised a nice big to answer that the events I just heard from Jeff yesterday that even back and forth on this couple of settings before they finalize the mono megabyte it's like optimal, we can't we get for network, we find different optimal, but you know let's: firstly, gonna start with what we had. We won't be having inductance framework and then we can take it.

K

I'm mostly worried about like security issues that end up being service security issues, because the client is dancing asking from the server side. This seems fine. I mean.

R

I could I don't like long.

M

K

F

You like drain yeah now that I'm thinking it's.

K

Personal, it's.

F

Basically, that costs the opportunity cost is basically you just don't reduce connection yet yeah.

B

F

That's yeah I expect I didn't know that, like basically, if, if the threshold is exhausted, we just returned the college. Do.

K

The same thing in Castro, but then we have a time off work and put the consume.

C

K

You don't read the entire body's.

C

K

So we do the same: a catchable for security reasons. So if you don't read the entire body, then we read it for you, so we can keep reading requests and not have it like overlap, and then we have a timeout well clients using the server. That's my concern. Ok, we'll see it. The client and then it'll run saying your ABC Helen and, like you, have a server security. But if we as a server broke, you know I have no.

T

Problem adding a timeout as long as we made the default infinite, yeah.

K

I get it yeah, I. Think it's fine I mean this is fine too. It's not required.

A

Suited for them, and doesn't that, like it's basically configuration, is it secure by default? You just don't want that's kind of our attention that we have this very in.

K

A

What happens, is they push back and say you have to make it at all ten minutes. Does that break the performance or like? What's the vote, because.

K

You'll just open with.

C

The connection.

R

K

The server TCP socket, probably its resource, consumption or there's.

C

Force you to basically like the solution connections. Okay, if you're.

K

C

Your server is making the request something.

E

To some random yet.

C

E

C

E

C

E

Security, mr. Stites, up in the client this one with something you're calling so Jeff.

P

Stephen we dropped off before is the is the unit bytes over here, one minute behind the right? Yes, okay, cool.

A

We have a conventional it to become bytes in the name, so we.

P

Had like few weeks ago, something that, like kilobytes sure something was kilobytes, it was anyway see if your name is super weird, because we don't KB anywhere, but.

K

That one API I don't think yeah I do.

F

Bite I think it depends whether like what's the negative of setting it wrong. So in this one I mean the negative: is the code is not as performant as it could be? Fashion is the other one that we discussed. There was some like potential security related issue like if you said it incorrectly, you could be those basic yeah I mean like we generally in the Pharaoh can be.

A

I

Sizes always always look at time like because ii ii ii, like those.

AD

H

I mean if this is bytes I'm falling inside yeah, it's my size. It makes it alright. So then the viruses this is proposed.

Y

Let's see, we are pretty much what is span right.

Y

All the puffs one- yes, all right, yeah yeah.

S

We talked about the truck so.

F

These minutes left, how is it different than combined so.

N

Combined combined actually checks routing on the paths as they go along, so once it every time it hits a routed paths or something that's got a backslash.

K

N

K

Nice I love that yeah, you too, and it just works just.

N

Know we have a new, it doesn't work correctly. All these so we do have. We do have a new path to get full path. That actually does the right behavior. For, for what you would think path to mine should work for.

C

Things eleven lemons right is the current yep.

N

Exactly and that's that's the problem with so path path, people that has my face path on it now, like will actually give you a fully result path and you won't get. You won't get a. You won't get a partially qualified path out of that this one you get a partially qualified path out of for this and other reasons so joining.

F

Like how so I am not sure if it solves the problem, like people will have exact what they will be like, how is it they're buying I was.

N

I was join different for combined, not.

F

How it is like what you already explained, how it's different I am said, I'm just saying: how will users know, how will you know.

C

F

Could we just add some suffix to combine and call it? You know combined just just combine, combined, incomplete or something fasting like.

N

F

N

Combine because.

F

N

L

F

Different kind of combined, they are the same there's some small difference, because.

G

N

F

Like all over the place, the.

N

Difficulty there is that, like there's, a with the existing API is like getting the right overloads and things.

N

C

N

Term, that's used in some of the other frameworks as well.

A

In string Comcast ring conch, it literally just.

A

S

Is an implant equator? He was just a passive way yeah. The number one is the.

S

A

The con campus is joined for a second like it seems, work whether we should use something.

AD

Like combine, like compliance, optics, I think.

A

You visit the same other question, which is: are the existing combined? What's effectively deprecated.

S

Are we actually saying right.

N

I will actually would be recommending it, whether deprecating it or not, like in the docs.

N

Partially qualified pass, so the recommendation is not to use combining but to use a path, get full path. If you need that routing behavior, so.

A

The reason I'm saying this because actually.

N

A

No analyzer flex, the other one, it doesn't matter. If we want you to the white one, in which case we can decide to.

C

Go with some other name, it's.

A

A combined deprecated.

C

In pom try join method, isn't it can't you calculate the required size like it's just another, slash right.

C

So why aren't we returning characters required if we, if we can calculate it internally in the method and don't force people to calculate it? For you.

N

Deep arms, you can mean that possible, I.

C

Get I get that this is our current pattern, but this is more for methods that do not know what they mean exactly I know. I have no.

N

You know I'm, obviously calculating it so I know.

S

Because every API is different, shape, I think.

C

If it, there knows how much it needs it needs to return. What is that out? In the middle.

N

Middle because if we had an overload later for that one two three I think it grows yeah, that's rare! Only I don't want to do. I mean like it's been asked, whether we don't have the path, one two three to be get rid of it.

C

H

C

If there are no, perhaps we can put out the last one and as many as one before it there's.

AB

R

M

C

Cannot use params with sprite, so this this was only required only when we use params because perhaps has to be the last one it from it. We don't have. Perhaps we can put out the last one and stick as many of spans before it is was well me, I mean first of all, we can do cramps, expanded.

A

Decide it wouldn't work in this case so because you cannot have span but.

C

Yeah I'm saying you cannot have params offense not spent, but.

A

To me, that's almost a song I like every day, it's always sucky to have outs in the middle. Yes, I think we always have how's it play I'm. Fine with that. I was just following no.

C

Reason to push.

A

Right and I think in general speaking like even if we added say possibly possible, fine, it's fine, just in the middle, because yeah because.

S

A

This is the end. Okay, so then I'll be happy with the API I'll be happy with the deprecation anyway. That path combined is used to on, though okay.

I

F

You cannot get it like, so I still like that. I like the idea of calling the method, con card and joy all right.

C

It was the first two eras are the same and you see both of our laws. When you start wrapping- and you know people asked why.

K

There's two and then we'll just say you yet bro.

H

F

Join is powerful, it is partial such.

E

F

Don't know join.

E

Database giant Porsche. Do we feel, though, if the new name is shorter,.

A

I think we'll.

I

All we generally gravitate to that. So let's compare or join public. That's.

K

A good name, combined was a good name, is stuck away stuck away. My brain you.

A

Say that but maybe we should join, maybe.

I

G

AC

G

Can't be the one I thought combined so.

AC

They're easily, don't add the tried 150 pass right now we have a joined the teapots another.

C

24 hours Oh, what's what's our sound like when we do multiple thing, multiple parameters? What number are we going to Benz hell, costly.

F

Imagine that your operation takes five days to complete. You just take a right in this case, how far.

C

They go what I.

N

Think we have liked, we can, let me apparently yeah, but you know, for that, for the existing ones come on amigo up to four.

A

Just not too bad yeah, okay, the same on which actually.

V

K

M

H

M

Make a mess build like okay, let's do like a value talk to Poole does not afford it. It's something serious you're.

H

Running out of time,.

M

No more jokes, let's close on this is this: the API shape.

K

H

K

Passing in the first own.

A

Destination goes probably right before the hour and then both of them go to the end is that is that fair, yes, is that possible, then.

N

When you like, how do you determine which man is which.

N

A

It's basically always the one right before the out right, yeah and the eldest takes my condition.

C

And can we please change out to be how many characters is required not come in is really.

AD

C

White weight like oh, you don't know whether the backslashes would be add it or not, correct, but characters written. What do I do when I get it. You know how much was written to the destination cuz. It's like.

K

C

If is not enough, what if it is false, so it's not to enlarge its to just know how.

F

Much basically.

C

F

To pass a span, that is a the sum of all lengths, plus as many plus number of spans. Why don't you return.

P

F

C

But then you don't.

F

Know how much was actually what, if you just returned, if it Sam.

E

We never done, we are not done, but we will give you the room because.

F

You can write to.

V

P

One more thing like you.

AD

May do it or fly.