.Net Foundation Design Reviews, 20 Feb 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: .NET Design Reviews GitHub Triage

Description

00:00:00 - Approved: Consider adding MemoryMarshal.GetOwner(ROM) https://github.com/dotnet/corefx/issues/27237#issuecomment-367072826
00:25:14 - Approved: Add DecompressionMethods.Brotli? https://github.com/dotnet/corefx/issues/26995
00:38:11 - Approved: Add file enumeration extensibility points https://github.com/dotnet/corefx/issues/25873#issuecomment-367082482

A

Camera also works. We should be good to go.

B

Alright, a particular very order Hearst one egg. She is the one that powerful oh no, this is not. The one father was supposed to file one that he needs for pipelines. This is it's called he it's the worst thing and I'm not sure.

B

If he has it, hmm maybe we won't be able to review it today, because basically, he wants ability to get some internals from I think from sequence from sequence position and if you want to do it like March on like ap is but I, don't think the issue is yet filed and I told him. I worry a bit like we keep adding more and more of these Marshall back doors. So that's worry number one. Secondly, we need to decide how they go to the same class or they on some different I.

B

Think the position was just giving everything anyway, no yeah, but it gives you wrong information because, basically inside there's an intent and object, but they are like masked. So if you access it on on memory sequence or read on the sequence you getting some like negative int, which people complain that you know they thought it's an index. But it's a negative int. What do I do a bit while you have to apply a mask so now he wants an API to apply the mask for you and I kind of would like to discuss it.

B

But since he's not in the room- and it's not ready they'll just move on right. So then move on to the first one, because it's also kind of shipping its proposed by ban I.

A

Think they're in the business and it's now I think all the hardware one should probably skip and do them together. This is a general thing going on with hardware interlinks.

A

I'm sure was going with this one I thought very close out. There don't know. What's up this one on the top of this one, and actually this one we'll be talking about that's right, yeah and if you finish all of them I eat my head, put it on we're all right, so I.

B

See so basically so read, only memory of D and memory of T can be created either by just calling and constructor a passing, an array or or a string or you can create own memory, which is like a lifetime manager for arbitrary memory, and then you get rid on the memory out of it.

B

So Ben is proposing that we add an API that lets you fish out own memory out of read-only memory.

B

Kind of you shouldn't be doing it. That's why he wants to pull it off memory marshal and I. Think it's consistent. This one is consistent with some other ideas that we added to memory Marshall. The only thing I don't understand is: why is he proposing that the return type this object and not on memory.

C

Usage here we are one.

B

Exactly which has to incur it from memory.

A

His ban online, a man, isn't responding to my question. He reaches everyone. What I try to do, which is getting et? What's the use case so.

B

I think, basically, he stores additional information inside subclass of own memory, and now he wants to reflect the ideas, this additional information. What.

D

B

Be able to get to it? Oh so he has read-only memory and he wants to get the ID of that found memory. Yeah.

C

B

Because in Rio registered I/o you kind of kind of just referred to you know like past memory, lock you have to pass an ID of the problem.

C

So it it's a legitimate scenario: I'm not a oh I, can prove perfect this or.

B

C

Want to do a sneaky thing or yeah.

B

It's on its I would almost describe it as own memories, a classic and ferried from it. You can kind of extend it, but then, once you get into the memory world, they are all structs. They don't have more information to give you. It seems.

C

True, once it goes to this man, yeah.

B

Correct correct and.

C

They'll be within for sure, Oh try and rewind all the way back to an old memory from the stand.

B

Probably not from the span, it may be hard, but people are trying to do it. For example, there was a change that allows you not to strained Elvis.

B

What, if you happen to rap extremist.

C

A

We said it's object because that's what the unlike fielder's, you don't want to do the check twice right.

B

uh He doesn't want the past to happen twice, but why would it happen twice or.

A

Because he wants a car for drive time right. Oh he.

B

Wants to then get the drive time mmm there is sort of the thing is object. Well just gives you back what it is right. Okay, I I see the reason I wonder whether it's worth it because it makes the API so much less self, describing.

E

Isn't that better for these crappy EVPs, we don't want people to use moji.

C

Making it generic.

B

C

Where you going to type you expected to eat, when you can give it on memory, if you are going to do a wonderful cast, it.

B

That's a possibility.

C

Just generic methods are relatively low, concentrate story, your fields and generic types. Well,.

B

All of our genetic methods over like struts, this one would be a class, so it would be shared.

A

Except this can univision all right, because that would be awful to call I mean, like he's kind of like like this is all generic cup of tea right, so you would have to have two generics now and you count it further anymore. It's like well, yes, because.

C

It would be explicitly the return type generic. We don't remember if she is no.

A

I give that what I'm saying now you have to also positi right will you accept of us is a second yes entually. It's we're.

C

Fortunate astonishment, the.

F

C

The missus returns null. If it's not on memory this, do we then need an access or do we did invested to hide the owner from the get owner place.

B

What do you mean? I did like.

C

Are there scenarios where we think that someone shouldn't.

B

G

C

To come, you know it's.

B

A it's a memory Marshall. We allow people to do really dangerous things in some of these, but first a method needs to be genetic correct. It needs to have one T already and that's something so they would look.

A

Like this, which I think will be a fair, not creo que.

C

Alright, so yes, having a specify both I guess, I can agree that well.

B

The the only question is I mean. Does the API need to be? You know incredible easy to use. Siempre I go.

A

No I would say the people that will use the API, like probably doing something very similar to what Ben is doing, and so that means friends.

E

A

E

And interrupt, of course, everything is in perversion, objects.

H

That's a that's a great example, so without the CPR in like the walk round, is just to keep like that on memory with your original elder private life.

D

Well, that's what I love it very much overhead! No.

B

That's head: it's gonna work, excellent work, I! Think the problem is that the moment you you know want to keep them both. You have to change the type, so you would have to create the small strap that wraps measure your memory. Now you cannot like interrupt with some other api's.

C

So you still have zone memory, so kind of drop right, I assume the problem would be if you pass the memory into an API which will gives it back to you know it's a struct, so you can't reference the quality. It's something so now he's trying to get back to which which of my factories created.

G

B

G

Reasonable I don't think we need to abuse people he's an animal right. You'll get word, never.

I

Marshall right what.

A

Happens if introducing.

I

You type it is seen that it's not all family.

A

This one, just if there is no, if.

B

It's not then use your head are a gives you back in its already hardwired. We already have well, so you know in memory can drop string or a write directly. This API would already returned. You know if it's not this on memory of the homework before they.

A

Give you back whatever the field path, ready, I, think so. Otherwise, why would you do I mean I always do the cards.

F

Right mmm I mean: do we put the string in the other field? Yes,.

C

B

We already have an ID I, try guitar eight records string I, so.

B

Yeah you can get from.

I

D

B

Which actually now that I'm thinking? Maybe you should just follow the same pattern and should be triggered honor the memory of Edo? What it's directly on memory of Oh?

B

Try get array, because it's kind of not and.

A

Say and this one Polly.

B

Should not be a extension method either I should probably just we only have any well, no I think the reason that on memory of D, you have try gate array is that it's kind of nuts? It's not a loophole for the read on leanness of the type I think Ben wants specifically read-only memory, which then gives you something. That's basically read/write and all these are on memory power. Yes, interacted, like only March. We also have try gate array at exit.

B

We don't yeah because it lets us character it on Lina's, so I think this one kind of should be credibly. Kali get try, get on memory right and just follow the same pattern, and then we just add it. So if you have read on the memory you can get either string or on memory or array.

B

But use the same API like a try idea.

J

I get: how do you.

A

Call it on them. It's.

I

G

I

G

I

G

You're saying that screams, whoa I think.

B

We may only as they want to get stranger I'll.

E

B

There's nothing on memory macho I. Remember.

C

Heart rising like a rain.

B

A

G

Like this, an interrogatory.

B

Party called well it except the written parameter, is on so P ulnar or T. Sorry, it should not be this. It should be so.

C

Striking array that exact signature exists and at least in the current course he'll our version of member Oh.

A

Triple it be the whole memorized all memory of T. Well, it needs to.

B

Be so this is the question of you know double down cast right. Do we want to do we care about the double deafness? How costly.

A

Is so I think there's two different sides here? One of them is: do we want to hide the fact that, in the same field of restore their own memory, we also store the string and array? Because if the answer is yes- and you will always have to do a cos anyway, because you need to basic several doses that string and neck as they return now.

A

B

Because we encode in one it inside the index, whether its own memory or strip, we don't like a temp to cast within there- are you ancestry? There are some inside and like.

A

Range is negative that it's arranged, so we can tell people about during the class whether it's normally or not. Apparently,.

J

According out, we had it.

C

Already is well, it's less.

A

C

Zero, this yeah.

A

The different things look to the detention for array so like not just for strange but for anything basically know whether the object is for an old memory or not. Could it's so big.

B

So we know, but then we have to, but then it doesn't change the fact that we know now we do a cast.

B

It has some cost and baños been exciting, and now he has to cast again to a subtype of on memory which make up additional cost. Now the cost is small, so I wonder whether it methods, because what you wrote here is much nicer ATI, then then an alternative where it has a second type parameter.

B

Having said that, the you know now there is an out parameter. They would be both in third.

A

Point the code Ophion for that wouldn't be bad and it could even constrain this one right.

K

You could even.

A

Say if we wanted.

K

A

That being said, I'm not sure, once you add the constraint man, it's too late for it, so I have another another.

B

Problem, I guess with the API, so the one to get that gives you an array. It gives you both an array and int that describe the slice of the array. This one does it. So, let's say you have read-only memory and it's just a slice of the owner. How do you get the int.

B

A

B

He probably doesn't care, but he said don't care, he doesn't care because he just wants the ID. He just wants to get whatever he stored in the object. Probably but I feel like the API is now kind of incomplete.

B

It works for him to get the idea, but it basically gives you own memory. How do you? How do you know these slides and offset.

A

B

A

Are inside member.

B

Of T there are two fields: there's.

A

Memory of teen owner's home memory of T and so on.

B

All memory, you don't know what did everyone? Yes, a memory of T is just a view over all memory of T. So so it it's a pointer to own memory and to int you.

C

Had an own memory, you make a memory from it and you slice it. Then you can slice get on memory, you don't know how far into the old memory.

J

Using memory I also don't get to the old homeland, so we will give you the API. Think it's back in memory wouldn't have you do.

C

Essentially, it would need to help be toner and offset Emily, which.

B

Would make the API even slower but more complete, I, wonder whether we care, maybe we don't care I mean I mean quite frankly, is we care? We could still say: okay.

A

We have we just added.

B

An overall gap just at an overloaded.

A

Say you only pay for the additional extraction if you care.

L

A

Then it's you know, self-contained was.

I

A

K

It and of course it sounds.

K

A

I think it would be nice. Api I mean it's nice from the cell phone itself contained I. Had people play yeah, we care.

J

About this constraint here.

E

You're gonna return.

C

I mean like either we don't constrain it and if we add another magical thing in the future, and then this will start omitting those or we can train it and like all that this does is introduce a compiler check. Yeah.

B

I think, if we don't constrain it, it would also I would expect it to also work if it's not on memory, but rather an array or restrain it just returns an object, and then you passed it to whatever plus.

C

The fact we were calling and trying it on memory means diffusion. If you code.

G

In it, there's an expectation that it.

C

Is only a miracle.

B

I'm saying, then your key without the constraint. Well so I would say if we change it such that it doesn't have the constraint, it should be called, try, get I, guess and gives you anything. It just gives you the object view. Try get memory just you're.

A

Running sensing.

J

B

Would make sense for any of the other world that means yeah?

B

Having said that, I don't know how to use the idea, you get the object and then you try to downcast with their string or or order an array.

A

Well, even if you remove the constrain, you would pass in the t you want, but it would only table the last one. I thought the generic in here is what the power would be. If we, if we, if we just do this right, you can still pass in water, yeah.

J

A

B

A

B

I'm just saying would it would you expect it to work if I pass string as the owner I? Will you just get false and not well? Why.

A

Would we not get the.

B

String what if, what.

A

If it depends on what this thing, that's, why.

D

A

Exact, my stream, would we want this to return the string it? What is the only I would expect to subjective it. This one said it give you not the.

K

A

It will attempt to pass that well.

B

A

B

And then no alternative API could just not do any checks. Just give you the object view I'm fine with that.

C

Essentially, we would just be exposing they get I.

A

Mean Stephen.

D

Is also Nancy may have an opinion.

A

On it or you awfully quiet, I, don't.

M

Know strong opinion either way: okay, I.

C

Think this is, we already have tried, get a rain somewhere. We might have target string that we should later we find out that people wanted an unconstraint. We can add another API later.

A

I'm good with that I honestly already had the other api's I kind of liked it you that you can tell by the cap and what it would tries to do. You can make it too generic. Then it's like! Well, you never find out what people trying to do about it. Alright, then,.

B

Headed there constraint to the first one and let let's ask Wow: what's effects and- and it's been happy with this API.

J

Check the shed I.

C

Mean you would double down cast if you were wanting to.

C

Turns out that already expenses, okay.

B

He's happy and having said that, so one thing that you know people know we we kind of have a schedule and I'm not sure whether we can even add this API still now. But you.

N

Know Josh should make the call so.

H

This week you have to finalize the guys and Fisher. This is what I hear I mean.

C

There's a proving the API it's done and there's somebody actually make oh well. Another.

B

Thing is so if you've been so cool I also I think the biggest problem is basically, we don't have people to do more work because they already scheduled with some other work items. So if Ben actually submitted this PR I assumed, we would take it. I suspect.

E

Refreshing you're gonna take everything till we get that cutoff point yeah.

A

Somebody's asking why we don't make these api's already make this API static, it's hard to mock I'm, not sure that they can, of instance, methods make it any easier to mock me Dave guys like that. Just not.

G

A

This stuff works. Let me just fine. The labels API.

A

Everybody, the discussion we just said we don't want to make it object, because you want to constrain it to the read-only memory, so that we know that this is the only thing people can actually get out of that.

A

But yeah it's a bit more likely in c-sharp this, because I believe this one meets i7.

O

I

O

I

A

Right, Stephen, you are out so.

M

On the new socket HP hammer: well, thanks aback I used to be client.

M

There is a timeout that represents the entire request so from beginning to end, if it takes longer than that at times out, but some folks want to be able to time out just the connection phase so that if you know if it takes a long time to connect to a particular server, they can just timeout that part, but once they're connected they can have a very long operation and it could take as long as they want and so in some other places, there's a similar connect time at expose, and this would be doing the same thing.

M

Basically just a fine-grained timeout on the connection phase of opening a PHP connection assume.

C

This is the same name of the timeout on the underlying socket.

M

Know think in our minds socket has long. Does it minute cancellation token, where we register with it and dispose of the underlying connection. My screen, I'm. Sorry, no for the connection base socket has a static method that allows you to cancel the operation. It's like cancel connect a sink or something like that, and so we register a cancellation token and we fire. We can we invoke that operation when cancellation is requested, so I can't find.

F

The type so it should be handler. This is actually the real type name. It's the new thing. We were adding a new one.

E

We just reviewed just a couple weeks ago and came up with this name. Maybe right here.

O

E

Don't know why, anyway, so yeah I mean even akin to the type I'm API itself called manage handler before I think she was previously.

C

Possible this hour, the ODBC drivers call it connection timeout. That seems to be the only I, don't see any connect, I guess single connection string builder called it connection timeout there lots of things call it connection, I know, but.

B

It's too mean connection, so you know, if there's a consistency argument, then we should go with consistency, but connection timeout to me is I already a start. I have a connection I already connected this one is I, wanted to connect. I, don't yet have a connection.

B

Well, I mean the way that works in I already yeah I have a connection and now I wanted to, for example, timeout after some time, and you know we added some ideas to basically, you know, recycle for exercise or something.

L

Because the method.

C

Is called Connect I was looking for consistency so and it's possible with the connection type out to the.

C

C

M

If you looking for consistency, you alluded to how this socket is under the covers. Sockets method is called cancel connecting.

C

Okay, it is the timeout for Connect, which is a socket all right, so that means we seem to be happy.

F

With this one close.

M

So another timeout, when you enable expect 100, continue for an HTTP request. Basically, what you're doing is you're, rather than sending all of your post content you're, sending a header that says, expect 100 continue and you delay sending your content until you hear back from the server that says: okay go ahead, but sometimes you never hear back from the server and you just want to send the content anyway.

M

So most implementations will just send it after some period of time, regardless of what that you're, not from the server and we're currently hard-coded to one second, but we'd like to be able to make that configurable. So this is the API that would let you do that if you scroll down you'll, see that this is exposed under different names and other places.

M

So there's it's called continued timeout in some other places, I think that's sort of too generic name, but.

A

As I like continue the time with a little bit more because it's not quite as much legal like you, don't have to read this back to know. What's going.

F

On well I mean, but you need to read the documentation to understand right. But if it's.

A

Like names, a number of sounds like okay: this is internal good, but we will never beat the dog right this one. This one looks attractive to drill into oh this one turns me off right, bad name. Second, I don't know. Maybe this is how I work, but it.

I

Depends how many people we expect.

A

This to set right, the answer is, nobody may be there.

B

So what what happens if I search the web for expect hundred timeout.

A

In search engines.

A

They should be coded really so.

B

Dog shows up and if I search for continued timeout just continue, I believe it's between the next subject: no, no! No, but to remove everything and just search for continued timer. Okay,.

B

All in all out fine, so this one is specific. It seems like the hundred hundred, whatever expected will.

A

D

That's pretty good, it's.

A

Like so, you can totally think your search engine test, but the bug publicly what.

B

Did you Bing get.

A

Any storm Athena I wasn't going to prove with this.

A

Consider any memory Marshall get try Gatorade. If you just literally talk about that I really, guy I, don't know if it's enough.

B

That's a different one: okay, no literally like look at this yeah.

A

G

B

A it basically does a similar thing from read-only sequence, but Oh.

M

Rotation detail: this would require pudding, we'd, always sequences there. That's quarterly right.

M

B

Is it only signal I, don't know at it? It's read-only butter. It was.

A

Renamed to eat only.

B

Sequence with the.

A

Maltese malti.

B

Spam, oh, that guy, is this ready. It should be postponed this and like well, so.

G

B

Thing is that sorry I see that basically he is is powering online. It's probably not.

N

Is rid of a sequence? Yes,.

A

A

What is awesome again, I hear something right.

E

And we looked at, we launched equal, yes,.

A

Let's make sure we have those in the room, whatever I think. Instead of this week's and another meeting people, they have to burn like I, don't think it's because.

B

It would be good to discuss it with him. I have few. Maybe you can right something but like, for example, so read on this sequence is a sequence of buffers so which buffer? Does it? Give you the first one only.

C

And the sequence have like I said: I have no. If it was the empty sequence that all the participants yes is there. It was there too.

C

M

Seems like a fairly uncommon thing would only be useful first specific thing: can you not just enumerate the sequence and then call try again.

B

Yeah I mean the you asking a question that I would have that's why it would be good to have family in the room. I'll greet on the sequence. Can.

C

You get a memory from those, yes, you can you just like.

B

It's entirely possible; it depends what this API does. Maybe it gives you the memory correct, my god, yeah.

C

But anything like you think from the read-only sequence, you can hit the memory. Yours.

B

C

You can do whatever you want with the primitive that we disapproved. If you want to get the fist one, you can want to get first one you can. You just have to memories yourself, yeah.

A

Let's, let's understand.

B

That you may be right, maybe you know like oh okay. They also say that they need to get a memory list yeah they need the list. What should mix up the list is probably not the items in the list are not inherited from anyway.

B

Actually can you also like oh shoot? You are very close if you're good add a note to pointing to the API that we just added asking whether it whether it.

C

If we can solve it in terms of API, we've already added, also.

B

Been added, some information about the bag may be quickly at the back.

B

Yeah: okay, okay, fine Hey, yeah, the bag is already closed because.

B

It's not a bug, it's a confusion.

M

We talked about this briefly.

M

It's not critical, though, if we want to talk about 2.1 things. First, that's probably a.

A

But we really have a problem fermentation, we just don't have it, but it seems reasonable to to have the decompression method scene and reflect what the server can do. What the client can do and.

C

Then you know around the thinking you need to use it till later. Then it's.

F

Just basically identifies.

A

The elevator any any concerns in that it is the BR thing is in.

O

The iron-rich, so when we will get time it's a common source, let me I.

A

Think it's similar to the deflating you folks, some stuff and records, so alright, this.

E

One, let's just skip this one one second I just wanna connect two dots, at least for Jeremy and I, that read-only sequence is formerly read-only buffer, which we did review. I just didn't know that you changed the name to read-only sequence, I, think I've, missed that jump, I.

O

B

Remember whether it would changed it during the review or after yeah I think.

E

It was after I think.

C

E

Recall I remember view read-only buffer quite extensively, but I. Remember that name change just.

H

This meeting yeah, we didn't change the name.

B

During I think we changed it possibly after the meeting, because I was some issue. If read on it, oh I know I know. I know there was an email threat because Steve had concerns about it being called with only records right.

M

E

J

To connect the dots, so we understood.

A

All right so 30 more minutes, let's go through so what's open here. Didn't we already like beat the horse of that.

G

Most part, of course, is still alive. There are a couple. We should go one last time over counter with the bits that are potentially we consider options on one of the being the properties of each bit. We expose on the file system tree right so, and there was a question specifically for you on that, like ghost even brought up the whether or not they should be, you know an entire version stream. Well, it's I like it down further than being the file system.

G

Entry right there, yeah so was exposing string for directory or sorry for the root directory in original director. Those are the so original to root directories. What you pass in to do your search there, conceivably and probably will be an opportunity to pass in a veto expanding for your your source,.

G

Mumble too soon right.

G

It is a string though. However, now you don't track that cast it well. Do we do the comparator.

C

G

Only the demo, but then that only works with that's only for.

B

Memory, that's what it's fun.

G

Yeah, you don't have a, we don't have a way to get it out, yeah because or uh-huh span. Let's get out.

B

This stuff, out of it.

C

B

Even slows fun, doesn't it it's.

G

B

G

There is one in there.

G

There is some possibility here that, like actually creating the the.

G

Creating the route direct, the word charter is supposedly gonna also be didn't on static. So it's just calling normalize and like I plan to actually convert those to the most systematic stuff to actually normalize into a buffer, preferably on the stack when we're doing stuff internally. So.

B

I was recently writing some code, and you know it's like a comment: like gets a command-line switch I slice it now. I have a directory, but now I just have a slice, so you know not that it's super important for command line needs to be as efficient, but it may be useful in some cases. Yeah.

G

um You know I, just the only reason. I didn't add it right off. That is because look, it wasn't super surprise there as far as a constructor for the numerator, because it wasn't super high priority, we're trying to like shape the tree as hard as I can to make sure the other stuff actually just working in a way. That's describable.

G

There are some definite subtleties about how this stuff works. I've been iterating on, like the differences between units and windows and stuff, find rational ways to expose things, because one of the things that came off that is also you know it, which we knew already like Windows, gives you back all the data in one chunk right, UNIX does not that introduces a bit of a timing question there. You know if you don't actually go and act access, the things that require doing doing the Van, Eps tab or saturate.

G

You don't get the data as it was, and you've got the original data back. So it ends up that like doing that makes the cost of an emerging on UNIX like three times as much as it is to not get it. So that's what that one I'm, just kind of lean I decided. The best thing to do is just describe when you're. Actually looking at the data being passed to you, it's imperative to you can actually grab the day. Didn't care about it not like sit on it wait.

G

So the behavior of the API is that it won't fill things out like that. It's actually gonna call for it, but it won't change after that back down there. So whatever we get, it will stick and I constrained it to the one thing that we can't get so like I get the get the existing flags for units right before whether it's it's the point where I can't get, which is read-only real ones, the only mode we have to make other calls to go and see, but that's the only flag, I switch from that point.

G

So I keep the original said that I do without that, but I can make additional decisions on internally and then that particular flag could change for what would have been when it was attending. The other ones, of course, are the size of the timestamps.

G

Those things you have to actually go back in again as well, but for the rest of them you have its directory things like that, it might be prudent to add an is hidden as well to make it super consistent and not costly, because there you know, if you go back because that's another common one, you want getting.

G

What can you don't get? The I could add these hidden as well, because it's another common is on both platforms. So I already have it specific the convention out of crept, but we have that convention is what we map to okay, all right. Something about where are you yeah sit? The caveat to that is that you can check, you can see. Well am I on UNIX does my filing it begin with a period, but there is a tax with that too, because then we have to convert from utf-8 right to utf-16. So is it.

B

So in most cases is it actually utf-8 or its asked well.

G

I, don't think name stuff outside of the ASCII space and do you so that's. Why like, if you wait, whether it's asking or now, no no tell me well cuz they match right. I mean the first starter. 27 code points make some things really easy internally apply it like so like hidden is easy because you just look for space, then export you keep it on. We.

B

N

B

That, like compression from a 16, is like a vector eyes, widening.

G

Operation so, but like though, there are certainly optimizations because of the code, the the the optimizations for hidden, you don't have to convert right. You can look at the utf-8 buffer, which we actually have in this case and I can say. Look good. I certainly do that for the special directories I look for period in period actually.

H

A ship Wyndemere and if it is, as you say, this is yeah.

M

G

The special ones, we're looking for sure, is like those things, are, or are available to be checked without having to do any sort of conversion. The space in the period stuff right.

H

Yes can be non asking to write, you can have non ASCII spaces, but.

G

The ones that have special meaning, if we're looking for things its period, is the name one yeah.

M

I mean like the period does not.

G

Have any you can't use a different type of period? It has to be that period to be hidden energy, that special directory stuff. So those.

C

Checks are cheap, but.

G

C

Definitely, file system support, that's required for non ASCII, because I think that 16 is yes like that's. Does that right? Well,.

G

C

Depends depends it.

G

Depends on which back you're talking a spice okay, most.

C

G

Actually support the Unicode. It's just like what implementation of that Microsoft wants to I guess.

C

It's just a quite like because Sega spats just bites so TN.

G

What bikes did.

C

You write down since it was written before the creation of utf-8. All bets are off yeah.

H

Yes, so I have another question.

L

H

Like anyone won't use, the CBI's has to to understand like the differences. If you are running in Windows against running on Linux, there's not much difference, so you want to go to the scene.

G

H

Of implicit, implicit decisions, we are taking the codes, that's really different between Windows and there's, not a lot. That's.

G

Different, that's that's the main thing right there is that the data is not it's not populated at the exact it's not on Windows, it's atomic UNIX there's no way to make a bitonic.

M

G

That's the only cabbage, that's you only get into that. If you're, actually, writing.

G

It's most, people are gonna, be hitting the options. That's.

B

Some of the conversions from utf-8 to the 80s 16 correct.

G

You know there's a tax on that, but that's that's an implementation. Well, the only thing that like really impacts your code in any significant ways, just the the atomic the audacity. Actually it's getting some of the rockers, but that's again if you're writing custom thanks for that, and it's not it's really kind of hard to fall over in those cases too, but it is possible. It's just the.

I

A

Beast there's no way around it. Yeah I mean like that. I didn't ever like this many things that could happen. I did this follow like if somebody writes the directory while you're writing it also crazy things can happen yeah it all all.

G

F

Of crazy things can happen.

G

F

Just like the data.

G

That you get out is not an atomic there's, no way to make it atomic communiques right. So that's just right. We make it as atomic as we can be, and we can help push that a little further. If we had it's hidden to it as well, because then, then you can get all the attributes are very few. The attributes are actually get back on there to try and map them, but then you get all of its pieces. Can.

B

You at least get the last time the file was modified. I, don't agree with everything else.

P

B

P

You had that you could cut up on top of it. Implement your own animals bills. Is the incremental check right there, less money right there. This work.

G

P

G

It's it's there or you get it. There's no.

P

B

G

At the Thomas yeah anything yeah, you cannot get it atomically with other things that you carry well when you're narrating your numerating, you get.

F

You get back just the file title, so 104 listen, closer, there's any concerns.

A

About the API share, we talked about a bunch of behaviors right now, but at Indy. If the I ship is fine, so I mean like stuff from strings. We'd only spend I think those ones you added.

G

I

C

Have their those ones I, it started.

C

What do we want? We want the properties, read-only span, charge, string or read-only memory attached are the.

G

Can't be read over time, the the file name actually has to be read-only spam, because it's actually neither stuff that's part of strokes in some cases. Yes, we could think.

G

The consistency there I think it's far better because look I I can and probably will change some of these other ones either. Some of them will be passed in those arena. Lee I span a car or I'll be actively putting some portions of it on the stack I.

G

Actually you know, as I went through and I changed it to use a ray pool to throw like all the directory games and that one faster and something slower so like I I'm, not jumping forward on that when I had to spend more time with that, but like there's, clearly lots of opportunity to continue to make changes here that that could that will in some cases, will definitely get better, but when week 12 I mean internal stuff without changing the api's. So I'm, fine with that, are you, okay, with adding his hidden to it?

G

Yeah I think it's I mean it's all I'll.

I

G

I

One and then in his only hidden right, it's not trigger for system pausing.

C

There are different attributes.

G

Isn't that one yeah there is no system all.

I

Right I think we should hopefully review this one as well, and then, if that this one yet okay, that's.

G

The exact so those are the the exact same guys that take the existing setting of the options search option instead of search options, region options.

A

And so we went to liberation.

I

A

Match casing mesh type remember this is the all entities to my all and then those ones just take that guy, it seems reasonable, I think I'm, not Tally's, shown the existing API, but I think these ones are just all those on the existing ones. Right, yes, like past heart pattern already exists, and then there is a search.

I

Option immediately, it's exactly the.

G

Same signatures of the last organizers and.

I

Of search options.

G

Information options yep for.

I

Both sir in directory.

I

They need to reuse this, whatever, which one these ones are never used for. Yeah.

I

C

I

Pass this match type does match our name.

C

This one's awkward, especially because it says dose yeah.

L

F

I'm just wondering if that's us well, we know it's selected part of the guidelines, information.

C

According to the guidelines, we.

F

Make up any rule that we want you to justify all? No? No, it's the diversity rule. If it's a two letter abbreviation it's it's, it's kept all of our case. If it's it's two litres or more it special okay, unless it's RSA or those ones, are all incorrect and it just close your eyes on that one. So.

G

The only other alternative means for this or earth great, the technically. It's the win32 style yeah, but I.

F

Don't camera that we call it like when 32 or das I mean you know how they work and win32 actually would.

C

Look better as well: I guess, Kamiya sense of aesthetics, because then it.

G

Doesn't say: DOS, it's more, it's more technically correct than dos, because.

I

It's not toss toss is different. All right, then it's called win32, because then the audio press identify that term to show up just.

A

Add this anything else, otherwise it would fool. Dizzy. Gif, put.

F

G

F

Like years yeah, we may have been.

G

Looking at it, there was, there was I, have been documenting this stuff and fully and I have all the comments in here, but like one of the behavior changes that come about, this is actually a feature request that people have been asking for and it's like, but this this is a change in behavior to our existing stuff period, so we no longer match against 8.3 following night.

G

There's a consistency problem there that's been causing people grief for some time and that that a top-three filename generation is slowly Peter in a way it's not created by the the properties not turned on that says the volume setting is not turned off by default anymore, except for the system of Drive.

G

So right now, people visit those ticking time bombs that they get is like well.

M

We're 8.3 Bauman's turned out or not I used to explicitly turn it on so I. Could you start out CSP tab and get CS ROG? We.

G

M

I decided I can just type that into letters well,.

G

And now now we have the ability now to actually to mimic the sort of behavior if you're like looking for dot, HTM and HTML right now, you guys can do that efficiently. So that was the only other day. All right, then.

I

I think that's just so I'm going to have this hidden change, that to a 32, and this isn't one we just talked about. I was just all.

D

A

And I think no way out of time, because they also have to run to me need to come back to you. Sorry, thanks for showing up.